From: John Garry <john.garry@huawei.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Olof Johansson <olof@lixom.net>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Jeremy Linton <jeremy.linton@arm.com>,
"Arnd Bergmann" <arnd@arndb.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Hanjun Guo <guohanjun@huawei.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH RFC 2/2] soc: Add a basic ACPI generic driver
Date: Wed, 29 Jan 2020 10:27:30 +0000 [thread overview]
Message-ID: <651c836a-327c-f91d-fc5d-ab6f59c1b8db@huawei.com> (raw)
In-Reply-To: <CAJZ5v0jbh_zU8getDO2VdsQ7qzjnwkTXjsNd+j+j=K4PPDO05w@mail.gmail.com>
>>
>>> Any reasons for not putting it into drivers/acpi/pptt.c specifically?
>>> .
>>
>> I don't think so.
>>
>> One thing is that the code does a one-time scan of the PPTT to find all
>> processor package nodes with ID structures to register the soc devices -
>> so we would need some new call from from acpi_init() for that.
>
Hi Rafael,
> Or an extra initcall or similar. [Calls from acpi_init() are basically
> for things that need to be strictly ordered in a specific way for some
> reason.]>
> Why would that be a problem?
I don't see a problem if we want to use a soc driver, but that is
starting to look unlikely.
Alternatively, if we want to create some folder under
/sys/firmware/acpi, any restriction comes from the folder location.
For a folder like /sys/firmware/acpi/pptt, we need to ensure acpi_kobj
is initialized; acpi_kobj is set from subsys_init(acpi_init), so
module_init() for pptt module would suffice.
However if we wanted to make pptt folder a sub-folder from those created
in acpi_sysfs_init() - then we would need to make that parent folder
kobj non-static. Again, module_init() would suffice.
Thanks,
John
next prev parent reply other threads:[~2020-01-29 10:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 11:14 [PATCH RFC 0/2] Add basic generic ACPI soc driver John Garry
2020-01-28 11:14 ` [PATCH RFC 1/2] ACPI/PPTT: Add acpi_pptt_get_package_info() API John Garry
2020-01-28 12:34 ` Sudeep Holla
2020-01-28 14:04 ` John Garry
2020-01-28 14:54 ` Sudeep Holla
2020-01-29 11:03 ` John Garry
2020-01-30 11:23 ` Sudeep Holla
2020-01-30 16:12 ` John Garry
2020-01-30 17:41 ` Sudeep Holla
2020-01-31 10:58 ` John Garry
2020-01-28 11:14 ` [PATCH RFC 2/2] soc: Add a basic ACPI generic driver John Garry
2020-01-28 11:56 ` Greg KH
2020-01-28 13:33 ` John Garry
2020-01-28 12:50 ` Arnd Bergmann
2020-01-28 14:46 ` John Garry
2020-01-28 15:20 ` Sudeep Holla
2020-01-28 15:59 ` John Garry
2020-01-28 16:17 ` Sudeep Holla
2020-01-28 17:51 ` Olof Johansson
2020-01-28 18:22 ` John Garry
2020-01-28 19:11 ` Rafael J. Wysocki
2020-01-28 19:28 ` John Garry
2020-01-28 22:30 ` Rafael J. Wysocki
2020-01-29 10:27 ` John Garry [this message]
2020-01-28 20:06 ` Olof Johansson
2020-01-29 9:58 ` John Garry
2020-01-28 16:56 ` [PATCH RFC 0/2] Add basic generic ACPI soc driver Jeremy Linton
2020-01-28 17:28 ` John Garry
2020-01-28 19:04 ` Jeremy Linton
2020-01-28 20:07 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=651c836a-327c-f91d-fc5d-ab6f59c1b8db@huawei.com \
--to=john.garry@huawei.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=guohanjun@huawei.com \
--cc=jeremy.linton@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).