From: "Rafael J. Wysocki" <rafael@kernel.org>
To: John Garry <john.garry@huawei.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Olof Johansson <olof@lixom.net>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Hanjun Guo <guohanjun@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH RFC 2/2] soc: Add a basic ACPI generic driver
Date: Tue, 28 Jan 2020 23:30:48 +0100 [thread overview]
Message-ID: <CAJZ5v0jbh_zU8getDO2VdsQ7qzjnwkTXjsNd+j+j=K4PPDO05w@mail.gmail.com> (raw)
In-Reply-To: <b6cc7edd-fbb9-ed7a-412e-0d75e4c8ec2b@huawei.com>
On Tue, Jan 28, 2020 at 8:28 PM John Garry <john.garry@huawei.com> wrote:
>
>
> >>>>
> >>>> Signed-off-by: John Garry <john.garry@huawei.com>
> >>>> ---
> >>>> drivers/soc/Makefile | 1 +
> >>>> drivers/soc/acpi_generic.c | 102 +++++++++++++++++++++++++++++++++++++
> >>>> 2 files changed, 103 insertions(+)
> >>>> create mode 100644 drivers/soc/acpi_generic.c
> >>>>
> >>>> diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile
> >>>> index 8b49d782a1ab..2a59a30a22cd 100644
> >>>> --- a/drivers/soc/Makefile
> >>>> +++ b/drivers/soc/Makefile
> >>>> @@ -3,6 +3,7 @@
> >>>> # Makefile for the Linux Kernel SOC specific device drivers.
> >>>> #
> >>>>
> >>>> +obj-$(CONFIG_ACPI_PPTT) += acpi_generic.o
> >>>> obj-$(CONFIG_ARCH_ACTIONS) += actions/
> >>>> obj-$(CONFIG_SOC_ASPEED) += aspeed/
> >>>> obj-$(CONFIG_ARCH_AT91) += atmel/
> >>>
> >>> Based on everything I've seen so far, this should go under drivers/acpi instead.
> >>
> >> soc drivers seem to live in drivers/soc (non-arm32, anyway), so I
> >> decided on this location. But drivers/acpi would also seem reasonable now.
> >
>
> Hi Rafael,
>
> > Any reasons for not putting it into drivers/acpi/pptt.c specifically?
> > .
>
> I don't think so.
>
> One thing is that the code does a one-time scan of the PPTT to find all
> processor package nodes with ID structures to register the soc devices -
> so we would need some new call from from acpi_init() for that.
Or an extra initcall or similar. [Calls from acpi_init() are basically
for things that need to be strictly ordered in a specific way for some
reason.]
Why would that be a problem?
next prev parent reply other threads:[~2020-01-28 22:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 11:14 [PATCH RFC 0/2] Add basic generic ACPI soc driver John Garry
2020-01-28 11:14 ` [PATCH RFC 1/2] ACPI/PPTT: Add acpi_pptt_get_package_info() API John Garry
2020-01-28 12:34 ` Sudeep Holla
2020-01-28 14:04 ` John Garry
2020-01-28 14:54 ` Sudeep Holla
2020-01-29 11:03 ` John Garry
2020-01-30 11:23 ` Sudeep Holla
2020-01-30 16:12 ` John Garry
2020-01-30 17:41 ` Sudeep Holla
2020-01-31 10:58 ` John Garry
2020-01-28 11:14 ` [PATCH RFC 2/2] soc: Add a basic ACPI generic driver John Garry
2020-01-28 11:56 ` Greg KH
2020-01-28 13:33 ` John Garry
2020-01-28 12:50 ` Arnd Bergmann
2020-01-28 14:46 ` John Garry
2020-01-28 15:20 ` Sudeep Holla
2020-01-28 15:59 ` John Garry
2020-01-28 16:17 ` Sudeep Holla
2020-01-28 17:51 ` Olof Johansson
2020-01-28 18:22 ` John Garry
2020-01-28 19:11 ` Rafael J. Wysocki
2020-01-28 19:28 ` John Garry
2020-01-28 22:30 ` Rafael J. Wysocki [this message]
2020-01-29 10:27 ` John Garry
2020-01-28 20:06 ` Olof Johansson
2020-01-29 9:58 ` John Garry
2020-01-28 16:56 ` [PATCH RFC 0/2] Add basic generic ACPI soc driver Jeremy Linton
2020-01-28 17:28 ` John Garry
2020-01-28 19:04 ` Jeremy Linton
2020-01-28 20:07 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0jbh_zU8getDO2VdsQ7qzjnwkTXjsNd+j+j=K4PPDO05w@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=guohanjun@huawei.com \
--cc=jeremy.linton@arm.com \
--cc=john.garry@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).