From: Ard Biesheuvel <ardb@kernel.org>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: linux-iio@vger.kernel.org, drbd-dev@lists.linbit.com,
"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
"David Lechner" <david@lechnology.com>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
linux-wireless@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
kernel-janitors@vger.kernel.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-stm32@st-md-mailman.stormreply.com,
linux-block@vger.kernel.org, linux-ide@vger.kernel.org,
"Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>,
"Joe Perches" <joe@perches.com>,
linux-amlogic@lists.infradead.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"ACPI Devel Maling List" <linux-acpi@vger.kernel.org>,
openipmi-developer@lists.sourceforge.net,
linux-clk@vger.kernel.org,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Jerome Brunet" <jbrunet@baylibre.com>
Subject: Re: [PATCH 00/18] use semicolons rather than commas to separate statements
Date: Tue, 29 Sep 2020 14:20:00 +0200 [thread overview]
Message-ID: <CAMj1kXGh+CzuXkAnqsoMO2A3T1p=D6uFOV347Ym5+VFn5U1gWg@mail.gmail.com> (raw)
In-Reply-To: <1601233948-11629-1-git-send-email-Julia.Lawall@inria.fr>
On Sun, 27 Sep 2020 at 21:56, Julia Lawall <Julia.Lawall@inria.fr> wrote:
>
> These patches replace commas by semicolons.
Why?
> This was done using the
> Coccinelle semantic patch (http://coccinelle.lip6.fr/) shown below.
>
> This semantic patch ensures that commas inside for loop headers will not be
> transformed. It also doesn't touch macro definitions.
>
> Coccinelle ensures that braces are added as needed when a single-statement
> branch turns into a multi-statement one.
>
> This semantic patch has a few false positives, for variable delcarations
> such as:
>
> LIST_HEAD(x), *y;
>
> The semantic patch could be improved to avoid these, but for the moment
> they have been removed manually (2 occurrences).
>
> // <smpl>
> @initialize:ocaml@
> @@
>
> let infunction p =
> (* avoid macros *)
> (List.hd p).current_element <> "something_else"
>
> let combined p1 p2 =
> (List.hd p1).line_end = (List.hd p2).line ||
> (((List.hd p1).line_end < (List.hd p2).line) &&
> ((List.hd p1).col < (List.hd p2).col))
>
> @bad@
> statement S;
> declaration d;
> position p;
> @@
>
> S@p
> d
>
> // special cases where newlines are needed (hope for no more than 5)
> @@
> expression e1,e2;
> statement S;
> position p != bad.p;
> position p1;
> position p2 :
> script:ocaml(p1) { infunction p1 && combined p1 p2 };
> @@
>
> - e1@p1,@S@p e2@p2;
> + e1; e2;
>
> @@
> expression e1,e2;
> statement S;
> position p != bad.p;
> position p1;
> position p2 :
> script:ocaml(p1) { infunction p1 && combined p1 p2 };
> @@
>
> - e1@p1,@S@p e2@p2;
> + e1; e2;
>
> @@
> expression e1,e2;
> statement S;
> position p != bad.p;
> position p1;
> position p2 :
> script:ocaml(p1) { infunction p1 && combined p1 p2 };
> @@
>
> - e1@p1,@S@p e2@p2;
> + e1; e2;
>
> @@
> expression e1,e2;
> statement S;
> position p != bad.p;
> position p1;
> position p2 :
> script:ocaml(p1) { infunction p1 && combined p1 p2 };
> @@
>
> - e1@p1,@S@p e2@p2;
> + e1; e2;
>
> @@
> expression e1,e2;
> statement S;
> position p != bad.p;
> position p1;
> position p2 :
> script:ocaml(p1) { infunction p1 && combined p1 p2 };
> @@
>
> - e1@p1,@S@p e2@p2;
> + e1; e2;
>
> @r@
> expression e1,e2;
> statement S;
> position p != bad.p;
> @@
>
> e1 ,@S@p e2;
>
> @@
> expression e1,e2;
> position p1;
> position p2 :
> script:ocaml(p1) { infunction p1 && not(combined p1 p2) };
> statement S;
> position r.p;
> @@
>
> e1@p1
> -,@S@p
> +;
> e2@p2
> ... when any
> // </smpl>
>
> ---
>
> drivers/acpi/processor_idle.c | 4 +++-
> drivers/ata/pata_icside.c | 21 +++++++++++++--------
> drivers/base/regmap/regmap-debugfs.c | 2 +-
> drivers/bcma/driver_pci_host.c | 4 ++--
> drivers/block/drbd/drbd_receiver.c | 6 ++++--
> drivers/char/agp/amd-k7-agp.c | 2 +-
> drivers/char/agp/nvidia-agp.c | 2 +-
> drivers/char/agp/sworks-agp.c | 2 +-
> drivers/char/hw_random/iproc-rng200.c | 8 ++++----
> drivers/char/hw_random/mxc-rnga.c | 6 +++---
> drivers/char/hw_random/stm32-rng.c | 8 ++++----
> drivers/char/ipmi/bt-bmc.c | 6 +++---
> drivers/clk/meson/meson-aoclk.c | 2 +-
> drivers/clk/mvebu/ap-cpu-clk.c | 2 +-
> drivers/clk/uniphier/clk-uniphier-cpugear.c | 2 +-
> drivers/clk/uniphier/clk-uniphier-mux.c | 2 +-
> drivers/clocksource/mps2-timer.c | 6 +++---
> drivers/clocksource/timer-armada-370-xp.c | 8 ++++----
> drivers/counter/ti-eqep.c | 2 +-
> drivers/crypto/amcc/crypto4xx_alg.c | 2 +-
> drivers/crypto/atmel-tdes.c | 2 +-
> drivers/crypto/hifn_795x.c | 4 ++--
> drivers/crypto/talitos.c | 8 ++++----
> 23 files changed, 60 insertions(+), 51 deletions(-)
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-29 12:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 19:12 [PATCH 00/18] use semicolons rather than commas to separate statements Julia Lawall
2020-09-27 19:12 ` [PATCH 12/18] ACPI: " Julia Lawall
2020-09-27 20:27 ` Christophe JAILLET
2020-09-27 20:08 ` [PATCH 00/18] " Joe Perches
[not found] ` <160132172369.55460.9237357219623604216.b4-ty@kernel.org>
2020-09-29 0:45 ` Joe Perches
2020-09-29 11:37 ` Mark Brown
2020-09-29 11:46 ` Julia Lawall
2020-09-29 12:37 ` Mark Brown
2020-09-29 12:44 ` Julia Lawall
2020-09-30 19:33 ` Joe Perches
2020-10-01 11:01 ` Mark Brown
2020-10-03 18:40 ` Joe Perches
2020-10-03 19:15 ` Konstantin Ryabitsev
2020-10-03 19:18 ` Julia Lawall
2020-10-03 19:31 ` Konstantin Ryabitsev
2020-10-03 19:43 ` Joe Perches
2020-10-05 16:52 ` Mark Brown
2020-10-03 19:27 ` Joe Perches
2020-10-03 19:36 ` Joe Perches
2020-09-29 12:20 ` Ard Biesheuvel [this message]
2020-09-29 12:36 ` Julia Lawall
2020-09-29 12:41 ` Dan Carpenter
2020-09-29 12:47 ` Julia Lawall
2020-09-29 13:34 ` Joe Perches
2020-09-29 13:42 ` Julia Lawall
2020-09-29 13:42 ` Shuah Khan
2020-10-02 16:47 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXGh+CzuXkAnqsoMO2A3T1p=D6uFOV347Ym5+VFn5U1gWg@mail.gmail.com' \
--to=ardb@kernel.org \
--cc=Julia.Lawall@inria.fr \
--cc=david@lechnology.com \
--cc=drbd-dev@lists.linbit.com \
--cc=jbrunet@baylibre.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-wireless@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).