linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@inria.fr>
To: Joe Perches <joe@perches.com>
Cc: "Julia Lawall" <julia.lawall@inria.fr>,
	"Dan Carpenter" <dan.carpenter@oracle.com>,
	"Shuah Khan" <shuah@kernel.org>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	linux-iio@vger.kernel.org, drbd-dev@tron.linbit.com,
	"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
	"David Lechner" <david@lechnology.com>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	linux-wireless@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	kernel-janitors@vger.kernel.org,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-block@vger.kernel.org, linux-ide@vger.kernel.org,
	"Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>,
	linux-amlogic@lists.infradead.org,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"ACPI Devel Maling List" <linux-acpi@vger.kernel.org>,
	openipmi-developer@lists.sourceforge.net,
	linux-clk@vger.kernel.org,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	"Jerome Brunet" <jbrunet@baylibre.com>
Subject: Re: [PATCH 00/18] use semicolons rather than commas to separate statements
Date: Tue, 29 Sep 2020 15:42:32 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2009291542090.2808@hadrien> (raw)
In-Reply-To: <5f0d2b20f5088281363bb4a35c5652a2c087f159.camel@perches.com>



On Tue, 29 Sep 2020, Joe Perches wrote:

> On Tue, 2020-09-29 at 14:47 +0200, Julia Lawall wrote:
> > On Tue, 29 Sep 2020, Dan Carpenter wrote:
> > > The times where commas are used deliberately to replace curly braces are
> > > just evil.  Either way the code is cleaner with semi-colons.
> >
> > I also found exaamples like the following to be particularly unforunate:
> >
> >                                 fprintf(stderr,
> >                                         "page_nr %lu wrong count %Lu %Lu\n",
> >                                        page_nr, count,
> >                                        count_verify[page_nr]), exit(1);
> >
> > The exit is very hard to see, unless you know to look for it.
>
> I sent that patch last month.
> https://patchwork.kernel.org/patch/11734877/
>
> It's still not applied.

OK, thanks.  I'll not send those then :)

julia

  reply	other threads:[~2020-09-29 13:42 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-27 19:12 [PATCH 00/18] use semicolons rather than commas to separate statements Julia Lawall
2020-09-27 19:12 ` [PATCH 12/18] ACPI: " Julia Lawall
2020-09-27 20:27   ` Christophe JAILLET
2020-09-27 20:08 ` [PATCH 00/18] " Joe Perches
     [not found] ` <160132172369.55460.9237357219623604216.b4-ty@kernel.org>
2020-09-29  0:45   ` Joe Perches
2020-09-29 11:37     ` Mark Brown
2020-09-29 11:46       ` Julia Lawall
2020-09-29 12:37         ` Mark Brown
2020-09-29 12:44           ` Julia Lawall
2020-09-30 19:33       ` Joe Perches
2020-10-01 11:01         ` Mark Brown
2020-10-03 18:40           ` Joe Perches
2020-10-03 19:15             ` Konstantin Ryabitsev
2020-10-03 19:18               ` Julia Lawall
2020-10-03 19:31                 ` Konstantin Ryabitsev
2020-10-03 19:43                   ` Joe Perches
2020-10-05 16:52                     ` Mark Brown
2020-10-03 19:27               ` Joe Perches
2020-10-03 19:36                 ` Joe Perches
2020-09-29 12:20 ` Ard Biesheuvel
2020-09-29 12:36   ` Julia Lawall
2020-09-29 12:41   ` Dan Carpenter
2020-09-29 12:47     ` Julia Lawall
2020-09-29 13:34       ` Joe Perches
2020-09-29 13:42         ` Julia Lawall [this message]
2020-09-29 13:42         ` Shuah Khan
2020-10-02 16:47           ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2009291542090.2808@hadrien \
    --to=julia.lawall@inria.fr \
    --cc=ardb@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=david@lechnology.com \
    --cc=drbd-dev@tron.linbit.com \
    --cc=jbrunet@baylibre.com \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=rafael@kernel.org \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).