* [PATCH] clk: meson: s4: fix module autoloading
@ 2024-04-10 15:54 Krzysztof Kozlowski
2024-04-10 15:56 ` Neil Armstrong
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-10 15:54 UTC (permalink / raw)
To: Neil Armstrong, Jerome Brunet, Michael Turquette, Stephen Boyd,
Kevin Hilman, Martin Blumenstingl, linux-amlogic, linux-clk,
linux-arm-kernel, linux-kernel
Cc: Krzysztof Kozlowski
Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
based on the alias from of_device_id table. Clocks are considered core
components, so usually they are built-in, however these can be built and
used as modules on some generic kernel.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/clk/meson/s4-peripherals.c | 1 +
drivers/clk/meson/s4-pll.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/clk/meson/s4-peripherals.c b/drivers/clk/meson/s4-peripherals.c
index 6c35de3d536f..22ff030bd6a8 100644
--- a/drivers/clk/meson/s4-peripherals.c
+++ b/drivers/clk/meson/s4-peripherals.c
@@ -3799,6 +3799,7 @@ static const struct of_device_id clkc_match_table[] = {
},
{}
};
+MODULE_DEVICE_TABLE(of, clkc_match_table);
static struct platform_driver s4_driver = {
.probe = meson_s4_periphs_probe,
diff --git a/drivers/clk/meson/s4-pll.c b/drivers/clk/meson/s4-pll.c
index 8dfaeccaadc2..8a917b9703bf 100644
--- a/drivers/clk/meson/s4-pll.c
+++ b/drivers/clk/meson/s4-pll.c
@@ -853,6 +853,7 @@ static const struct of_device_id clkc_match_table[] = {
},
{}
};
+MODULE_DEVICE_TABLE(of, clkc_match_table);
static struct platform_driver s4_driver = {
.probe = meson_s4_pll_probe,
--
2.34.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: meson: s4: fix module autoloading
2024-04-10 15:54 [PATCH] clk: meson: s4: fix module autoloading Krzysztof Kozlowski
@ 2024-04-10 15:56 ` Neil Armstrong
2024-04-10 19:01 ` Martin Blumenstingl
2024-05-03 13:22 ` Jerome Brunet
2 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2024-04-10 15:56 UTC (permalink / raw)
To: Krzysztof Kozlowski, Jerome Brunet, Michael Turquette,
Stephen Boyd, Kevin Hilman, Martin Blumenstingl, linux-amlogic,
linux-clk, linux-arm-kernel, linux-kernel
On 10/04/2024 17:54, Krzysztof Kozlowski wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from of_device_id table. Clocks are considered core
> components, so usually they are built-in, however these can be built and
> used as modules on some generic kernel.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/clk/meson/s4-peripherals.c | 1 +
> drivers/clk/meson/s4-pll.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/clk/meson/s4-peripherals.c b/drivers/clk/meson/s4-peripherals.c
> index 6c35de3d536f..22ff030bd6a8 100644
> --- a/drivers/clk/meson/s4-peripherals.c
> +++ b/drivers/clk/meson/s4-peripherals.c
> @@ -3799,6 +3799,7 @@ static const struct of_device_id clkc_match_table[] = {
> },
> {}
> };
> +MODULE_DEVICE_TABLE(of, clkc_match_table);
>
> static struct platform_driver s4_driver = {
> .probe = meson_s4_periphs_probe,
> diff --git a/drivers/clk/meson/s4-pll.c b/drivers/clk/meson/s4-pll.c
> index 8dfaeccaadc2..8a917b9703bf 100644
> --- a/drivers/clk/meson/s4-pll.c
> +++ b/drivers/clk/meson/s4-pll.c
> @@ -853,6 +853,7 @@ static const struct of_device_id clkc_match_table[] = {
> },
> {}
> };
> +MODULE_DEVICE_TABLE(of, clkc_match_table);
>
> static struct platform_driver s4_driver = {
> .probe = meson_s4_pll_probe,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: meson: s4: fix module autoloading
2024-04-10 15:54 [PATCH] clk: meson: s4: fix module autoloading Krzysztof Kozlowski
2024-04-10 15:56 ` Neil Armstrong
@ 2024-04-10 19:01 ` Martin Blumenstingl
2024-05-03 13:22 ` Jerome Brunet
2 siblings, 0 replies; 4+ messages in thread
From: Martin Blumenstingl @ 2024-04-10 19:01 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Neil Armstrong, Jerome Brunet, Michael Turquette, Stephen Boyd,
Kevin Hilman, linux-amlogic, linux-clk, linux-arm-kernel,
linux-kernel
On Wed, Apr 10, 2024 at 5:54 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from of_device_id table. Clocks are considered core
> components, so usually they are built-in, however these can be built and
> used as modules on some generic kernel.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: meson: s4: fix module autoloading
2024-04-10 15:54 [PATCH] clk: meson: s4: fix module autoloading Krzysztof Kozlowski
2024-04-10 15:56 ` Neil Armstrong
2024-04-10 19:01 ` Martin Blumenstingl
@ 2024-05-03 13:22 ` Jerome Brunet
2 siblings, 0 replies; 4+ messages in thread
From: Jerome Brunet @ 2024-05-03 13:22 UTC (permalink / raw)
To: Neil Armstrong, Michael Turquette, Stephen Boyd, Kevin Hilman,
Martin Blumenstingl, linux-amlogic, linux-clk, linux-arm-kernel,
linux-kernel, Krzysztof Kozlowski
Applied to clk-meson (v6.10/drivers), thanks!
[1/1] clk: meson: s4: fix module autoloading
https://github.com/BayLibre/clk-meson/commit/11981485e27c
Best regards,
--
Jerome
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-03 13:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-10 15:54 [PATCH] clk: meson: s4: fix module autoloading Krzysztof Kozlowski
2024-04-10 15:56 ` Neil Armstrong
2024-04-10 19:01 ` Martin Blumenstingl
2024-05-03 13:22 ` Jerome Brunet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).