Re: [PATCH 0/2] i2c: meson: add support for Meson G12A SoC i2c controller

From: Wolfram Sang <wsa@the-dreams.de>
To: Kevin Hilman <khilman@baylibre.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh@kernel.org>,
	Hanjie Lin <hanjie.lin@amlogic.com>,
	Jianxin Pan <jianxin.pan@amlogic.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
	devicetree@vger.kernel.org, Jian Hu <jian.hu@amlogic.com>,
	linux-i2c@vger.kernel.org, Carlo Caione <carlo@caione.org>,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH 0/2] i2c: meson: add support for Meson G12A SoC i2c controller
Date: Tue, 11 Dec 2018 22:45:27 +0100	[thread overview]
Message-ID: <20181211214527.GA5660@kunai> (raw)
In-Reply-To: <7hsgz3u4fu.fsf@baylibre.com>

[-- Attachment #1.1: Type: text/plain, Size: 913 bytes --]

> >> I am okay if it is reasonable below in file
> >> arch/arm64/boot/dts/amlogic/meson-g12a.dtsi. I2c controller node just uses
> >> axg's compatible.
> >> 
> >> 			i2c0: i2c@1f000 {
> >> 				compatible = "amlogic,meson-axg-i2c";
> >
> > Actually, you should have
> >
> > 	compatible = "amlogic,meson-g12a-i2c", "amlogic,meson-axg-i2c";
> >
> > in the DT to have support for future SoC specific additions. And then,
> > patch 1 is needed.
> >
> > Or do you handle this differently? I'd think this is DT standard.
> 
> It's a DT standard *if* there are actual hardware differences.  In this
> case, the IP block is identical, so there are no driver changes.
> 
> We prefer to add a new compatible if and when there are actual
> driver/hardware changes.

OK, fine with me. I just hope for you guys that there really is no
change in the IP block, otherwise you need to update DTs later.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic