linux-amlogic.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 2/2] i2c: meson: add support for Meson G12A SoC I2C controller
Date: Thu, 29 Nov 2018 12:26:45 +0100	[thread overview]
Message-ID: <865b607c-8419-9c9e-0a00-018e87adf8de@baylibre.com> (raw)
In-Reply-To: <1543489197-183181-3-git-send-email-jian.hu@amlogic.com>

On 29/11/2018 11:59, Jian Hu wrote:
> Add compatible and data for G12A I2C controller.
> 
> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
> ---
>  drivers/i2c/busses/i2c-meson.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
> index 90f5d04..b86eed7 100644
> --- a/drivers/i2c/busses/i2c-meson.c
> +++ b/drivers/i2c/busses/i2c-meson.c
> @@ -462,10 +462,15 @@ static int meson_i2c_remove(struct platform_device *pdev)
>  	.div_factor = 3,
>  };
>  
> +static const struct meson_i2c_data i2c_g12a_data = {
> +	.div_factor = 3,

Especially if the div_factor is the same as AXG.

If you have some other fixes for G12a in the pipe, you will add the new compatible and meson_i2c_data later,
for the div_factor, simply use the axg struct and compatible.

Neil

> +};
> +
>  static const struct of_device_id meson_i2c_match[] = {
>  	{ .compatible = "amlogic,meson6-i2c", .data = &i2c_meson6_data },
>  	{ .compatible = "amlogic,meson-gxbb-i2c", .data = &i2c_gxbb_data },
>  	{ .compatible = "amlogic,meson-axg-i2c", .data = &i2c_axg_data },
> +	{ .compatible = "amlogic,meson-g12a-i2c", .data = &i2c_g12a_data },
>  	{},
>  };
>  
> 

  reply	other threads:[~2018-11-29 11:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29 10:59 [PATCH 0/2] i2c: meson: add support for Meson G12A SoC i2c controller Jian Hu
2018-11-29 10:59 ` [PATCH 1/2] dt-bindings: i2c: meson: add Meson G12A SoC i2c compatible string Jian Hu
2018-11-29 10:59 ` [PATCH 2/2] i2c: meson: add support for Meson G12A SoC I2C controller Jian Hu
2018-11-29 11:26   ` Neil Armstrong [this message]
2018-11-29 12:18     ` Jian Hu
2018-11-29 11:02 ` [PATCH 0/2] i2c: meson: add support for Meson G12A SoC i2c controller Jerome Brunet
2018-11-29 11:55   ` Jian Hu
2018-12-11 20:36     ` Wolfram Sang
2018-12-11 21:41       ` Kevin Hilman
2018-12-11 21:45         ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865b607c-8419-9c9e-0a00-018e87adf8de@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).