From: Firoz Khan <firoz.khan@linaro.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>
Cc: y2038@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, arnd@arndb.de,
deepa.kernel@gmail.com, marcin.juszkiewicz@linaro.org,
firoz.khan@linaro.org
Subject: [PATCH v2 2/5] m68k: Replace NR_syscalls macro from asm/unistd.h
Date: Thu, 20 Sep 2018 20:36:10 +0530 [thread overview]
Message-ID: <1537455973-12468-3-git-send-email-firoz.khan@linaro.org> (raw)
In-Reply-To: <1537455973-12468-1-git-send-email-firoz.khan@linaro.org>
NR_syscalls macro holds the number of system call exist in m68k
architecture. This macro is currently the part of asm/unistd.h file.
We have to change the value of NR_syscalls, if we add or delete a
system call.
One of patch in this patch series has a script which will generate
a uapi header based on syscall.tbl file. The syscall.tbl file
contains the number of system call information. So we have two
option to update NR_syscalls value.
1. Update NR_syscalls in asm/unistd.h manually by counting the
no.of system calls. No need to update NR_syscalls untill
we either add a new system call or delete an existing system
call.
2. We can keep this feature it above mentioned script, that'll
count the number of syscalls and keep it in a generated file.
In this case we don't need to explicitly update NR_syscalls
in asm/unistd.h file.
The 2nd option will be the recommended one. For that, I come up
with another macro - __NR_syscalls which will be updated by the
script and it will be present in api/asm/unistd.h. While __NR_syscalls
isn't strictly part of the uapi, having it as part of the generated
header to simplifies the implementation. So we need to enclose this
macro with #ifdef __KERNEL__ to avoid side effects.
Signed-off-by: Firoz Khan <firoz.khan@linaro.org>
---
arch/m68k/include/asm/unistd.h | 3 +--
arch/m68k/include/uapi/asm/unistd.h | 4 ++++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/m68k/include/asm/unistd.h b/arch/m68k/include/asm/unistd.h
index 30d0d3f..5072e94 100644
--- a/arch/m68k/include/asm/unistd.h
+++ b/arch/m68k/include/asm/unistd.h
@@ -4,8 +4,7 @@
#include <uapi/asm/unistd.h>
-
-#define NR_syscalls 380
+#define NR_syscalls __NR_syscalls
#define __ARCH_WANT_OLD_READDIR
#define __ARCH_WANT_OLD_STAT
diff --git a/arch/m68k/include/uapi/asm/unistd.h b/arch/m68k/include/uapi/asm/unistd.h
index de3054f..ba4176aa 100644
--- a/arch/m68k/include/uapi/asm/unistd.h
+++ b/arch/m68k/include/uapi/asm/unistd.h
@@ -387,4 +387,8 @@
#define __NR_pwritev2 378
#define __NR_statx 379
+#ifdef __KERNEL__
+#define __NR_syscalls 380
+#endif
+
#endif /* _UAPI_ASM_M68K_UNISTD_H_ */
--
1.9.1
next prev parent reply other threads:[~2018-09-20 15:06 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 15:06 [PATCH v2 0/5] System call table generation support Firoz Khan
2018-09-20 15:06 ` Firoz Khan
2018-09-20 15:06 ` [PATCH v2 1/5] m68k: Rename system call table file name Firoz Khan
2018-09-20 15:06 ` Firoz Khan
2018-09-21 5:48 ` Philippe De Muyter
2018-09-21 5:48 ` Philippe De Muyter
2018-09-22 11:36 ` Firoz Khan
2018-09-22 11:36 ` Firoz Khan
2018-09-24 7:00 ` Geert Uytterhoeven
2018-09-24 7:00 ` Geert Uytterhoeven
2018-09-20 15:06 ` Firoz Khan [this message]
2018-09-20 15:06 ` [PATCH v2 2/5] m68k: Replace NR_syscalls macro from asm/unistd.h Firoz Khan
2018-09-24 7:01 ` Geert Uytterhoeven
2018-09-24 7:01 ` Geert Uytterhoeven
2018-09-24 7:02 ` Geert Uytterhoeven
2018-09-24 7:02 ` Geert Uytterhoeven
2018-09-20 15:06 ` [PATCH v2 3/5] m68k: Added system call table generation support Firoz Khan
2018-09-20 15:06 ` Firoz Khan
2018-09-24 7:03 ` Geert Uytterhoeven
2018-09-24 7:03 ` Geert Uytterhoeven
2018-09-24 7:53 ` Firoz Khan
2018-09-24 7:53 ` Firoz Khan
2018-09-20 15:06 ` [PATCH v2 4/5] m68k: uapi header and system call table file generation Firoz Khan
2018-09-20 15:06 ` Firoz Khan
2018-09-24 7:05 ` Geert Uytterhoeven
2018-09-24 7:05 ` Geert Uytterhoeven
2018-09-24 7:55 ` Firoz Khan
2018-09-24 7:55 ` Firoz Khan
2018-09-20 15:06 ` [PATCH v2 5/5] m68k: added __IGNORE* entries in asm/unistd.h Firoz Khan
2018-09-20 15:06 ` Firoz Khan
2018-09-24 7:05 ` Geert Uytterhoeven
2018-09-24 7:05 ` Geert Uytterhoeven
2018-09-24 1:08 ` [PATCH v2 0/5] System call table generation support Greg Ungerer
2018-09-24 1:08 ` Greg Ungerer
2018-09-24 4:08 ` Firoz Khan
2018-09-24 4:08 ` Firoz Khan
2018-09-24 7:06 ` Geert Uytterhoeven
2018-09-24 7:06 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537455973-12468-3-git-send-email-firoz.khan@linaro.org \
--to=firoz.khan@linaro.org \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).