From: Firoz Khan <firoz.khan@linaro.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k <linux-m68k@lists.linux-m68k.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Subject: Re: [PATCH v2 3/5] m68k: Added system call table generation support
Date: Mon, 24 Sep 2018 13:23:31 +0530 [thread overview]
Message-ID: <CALxhOnipc=-fxG6o1_2ygpprjunfe3d6XPdraeRJNKnUwwzk5w@mail.gmail.com> (raw)
Message-ID: <20180924075331.Cx8FYGtp4z7tEHJOp1nD8XNE8QwirFKYNDoNduZgB1w@z> (raw)
In-Reply-To: <CAMuHMdUPKh+6ocdH38=46veyOFUE2o_Hj=xodyLDCQ3s8J9ADQ@mail.gmail.com>
Hi Geert,
On Mon, 24 Sep 2018 at 12:33, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Firoz,
>
> On Thu, Sep 20, 2018 at 5:07 PM Firoz Khan <firoz.khan@linaro.org> wrote:
> > The system call tables are in different format in all
> > architecture and it will be difficult to manually add or
> > modify the system calls in the respective files. To make
> > it easy by keeping a script and which'll generate the
> > header file and syscall table file so this change will
> > unify them across all architectures.
> >
> > The system call table generation script is added in
> > syscalls directory which contain the script to generate
> > both uapi header file system call table generation file
> > and syscall.tbl file which'll be the input for the scripts.
> >
> > syscall.tbl contains the list of available system calls
> > along with system call number and corresponding entry point.
> > Add a new system call in this architecture will be possible
> > by adding new entry in the syscall.tbl file.
> >
> > Adding a new table entry consisting of:
> > - System call number.
> > - ABI.
> > - System call name.
> > - Entry point name.
> >
> > syscallhdr.sh and syscalltbl.sh will generate uapi header-
> > unistd.h and syscall_table.h files respectively. File
> > syscall_table.h is included by syscall_table.S - the real
> > system call table. Both .sh files will parse the content
> > syscall.tbl to generate the header and table files.
> >
> > ARM, s390 and x86 architecuture does have the similar support.
> > I leverage their implementation to come up with a generic
> > solution. And this is the ground work for y2038 issue. We need
> > to change two dozons of system call implementation and this
> > work will reduce the effort by simply modify two dozon entries
> > in syscall.tbl.
> >
> > Signed-off-by: Firoz Khan <firoz.khan@linaro.org>
>
> Thanks for your patch!
>
> > --- /dev/null
> > +++ b/arch/m68k/kernel/syscalls/syscall.tbl
> > @@ -0,0 +1,369 @@
> > +#
> > +# Linux system call numbers and entry vectors
> > +#
> > +# The format is:
> > +# <number> <abi> <name> <entry point>
> > +#
> > +# The abi is always common for this file.
> > +#
> > +0 common restart_syscall sys_restart_syscall
>
> Why the indentation by an "odd" number of spaces, instead of TABs?
I'll check and fix ASAP. Hopefully I can post a clean (almost) patch series
within couple of days!
- Firoz
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2018-09-24 13:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 15:06 [PATCH v2 0/5] System call table generation support Firoz Khan
2018-09-20 15:06 ` Firoz Khan
2018-09-20 15:06 ` [PATCH v2 1/5] m68k: Rename system call table file name Firoz Khan
2018-09-20 15:06 ` Firoz Khan
2018-09-21 5:48 ` Philippe De Muyter
2018-09-21 5:48 ` Philippe De Muyter
2018-09-22 11:36 ` Firoz Khan
2018-09-22 11:36 ` Firoz Khan
2018-09-24 7:00 ` Geert Uytterhoeven
2018-09-24 7:00 ` Geert Uytterhoeven
2018-09-20 15:06 ` [PATCH v2 2/5] m68k: Replace NR_syscalls macro from asm/unistd.h Firoz Khan
2018-09-20 15:06 ` Firoz Khan
2018-09-24 7:01 ` Geert Uytterhoeven
2018-09-24 7:01 ` Geert Uytterhoeven
2018-09-24 7:02 ` Geert Uytterhoeven
2018-09-24 7:02 ` Geert Uytterhoeven
2018-09-20 15:06 ` [PATCH v2 3/5] m68k: Added system call table generation support Firoz Khan
2018-09-20 15:06 ` Firoz Khan
2018-09-24 7:03 ` Geert Uytterhoeven
2018-09-24 7:03 ` Geert Uytterhoeven
2018-09-24 7:53 ` Firoz Khan [this message]
2018-09-24 7:53 ` Firoz Khan
2018-09-20 15:06 ` [PATCH v2 4/5] m68k: uapi header and system call table file generation Firoz Khan
2018-09-20 15:06 ` Firoz Khan
2018-09-24 7:05 ` Geert Uytterhoeven
2018-09-24 7:05 ` Geert Uytterhoeven
2018-09-24 7:55 ` Firoz Khan
2018-09-24 7:55 ` Firoz Khan
2018-09-20 15:06 ` [PATCH v2 5/5] m68k: added __IGNORE* entries in asm/unistd.h Firoz Khan
2018-09-20 15:06 ` Firoz Khan
2018-09-24 7:05 ` Geert Uytterhoeven
2018-09-24 7:05 ` Geert Uytterhoeven
2018-09-24 1:08 ` [PATCH v2 0/5] System call table generation support Greg Ungerer
2018-09-24 1:08 ` Greg Ungerer
2018-09-24 4:08 ` Firoz Khan
2018-09-24 4:08 ` Firoz Khan
2018-09-24 7:06 ` Geert Uytterhoeven
2018-09-24 7:06 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALxhOnipc=-fxG6o1_2ygpprjunfe3d6XPdraeRJNKnUwwzk5w@mail.gmail.com' \
--to=firoz.khan@linaro.org \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).