linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
	Michal Hocko <mhocko@suse.com>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	linux-arch@vger.kernel.org
Subject: [PATCH 14/17] sh: get rid of superfluous __GFP_REPEAT
Date: Mon, 30 May 2016 11:14:56 +0200	[thread overview]
Message-ID: <1464599699-30131-15-git-send-email-mhocko@kernel.org> (raw)
Message-ID: <20160530091456.R-LSp6WbshmqF3zt657nnfduqxSv_YOmrvtvlMVSKY0@z> (raw)
In-Reply-To: <1464599699-30131-1-git-send-email-mhocko@kernel.org>

From: Michal Hocko <mhocko@suse.com>

__GFP_REPEAT has a rather weak semantic but since it has been introduced
around 2.6.12 it has been ignored for low order allocations.

PGALLOC_GFP uses __GFP_REPEAT but {pgd,pmd}_alloc allocate from
{pgd,pmd}_cache but both caches are allocating up to PAGE_SIZE
objects. This means that this flag has never been actually useful here
because it has always been used only for PAGE_ALLOC_COSTLY requests.

Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: linux-arch@vger.kernel.org
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 arch/sh/mm/pgtable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/sh/mm/pgtable.c b/arch/sh/mm/pgtable.c
index 26e03a1f7ca4..a62bd8696779 100644
--- a/arch/sh/mm/pgtable.c
+++ b/arch/sh/mm/pgtable.c
@@ -1,7 +1,7 @@
 #include <linux/mm.h>
 #include <linux/slab.h>
 
-#define PGALLOC_GFP GFP_KERNEL | __GFP_REPEAT | __GFP_ZERO
+#define PGALLOC_GFP GFP_KERNEL | __GFP_ZERO
 
 static struct kmem_cache *pgd_cachep;
 #if PAGETABLE_LEVELS > 2
-- 
2.8.1


  parent reply	other threads:[~2016-05-30  9:15 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1464599699-30131-1-git-send-email-mhocko@kernel.org>
2016-05-30  9:14 ` [PATCH 01/17] tree wide: get rid of __GFP_REPEAT for order-0 allocations part I Michal Hocko
2016-05-30  9:14   ` Michal Hocko
2016-05-30  9:14 ` [PATCH 02/17] x86: get rid of superfluous __GFP_REPEAT Michal Hocko
2016-05-30  9:14   ` Michal Hocko
2016-05-30  9:14 ` [PATCH 03/17] x86/efi: " Michal Hocko
2016-05-30  9:14   ` Michal Hocko
2016-05-30  9:14 ` [PATCH 04/17] arm: " Michal Hocko
2016-05-30  9:14   ` Michal Hocko
2016-06-01 16:24   ` Russell King - ARM Linux
2016-06-01 16:24     ` Russell King - ARM Linux
2016-06-02  6:32     ` Michal Hocko
2016-06-02  6:32       ` Michal Hocko
2016-07-20 20:59     ` Andrew Morton
2016-05-30  9:14 ` [PATCH 05/17] arm64: " Michal Hocko
2016-05-30  9:14   ` Michal Hocko
2016-05-30  9:14 ` [PATCH 06/17] arc: " Michal Hocko
2016-05-30  9:14   ` Michal Hocko
2016-05-30  9:14 ` [PATCH 07/17] mips: " Michal Hocko
2016-05-30  9:14   ` Michal Hocko
2016-05-30  9:14 ` [PATCH 08/17] nios2: " Michal Hocko
2016-05-30  9:14   ` Michal Hocko
2016-05-30  9:14 ` [PATCH 09/17] parisc: " Michal Hocko
2016-05-30  9:14   ` Michal Hocko
2016-05-30  9:14 ` [PATCH 10/17] score: " Michal Hocko
2016-05-30  9:14   ` Michal Hocko
2016-05-30  9:14 ` [PATCH 11/17] powerpc: " Michal Hocko
2016-05-30  9:14   ` Michal Hocko
2016-05-30  9:14 ` [PATCH 12/17] sparc: " Michal Hocko
2016-05-30  9:14   ` Michal Hocko
2016-05-30 18:23   ` David Miller
2016-05-30 18:23     ` David Miller
2016-05-30  9:14 ` [PATCH 13/17] s390: " Michal Hocko
2016-05-30  9:14   ` Michal Hocko
2016-05-30  9:14 ` Michal Hocko [this message]
2016-05-30  9:14   ` [PATCH 14/17] sh: " Michal Hocko
2016-05-30  9:14 ` [PATCH 15/17] tile: " Michal Hocko
2016-05-30  9:14   ` Michal Hocko
2016-05-30  9:14 ` [PATCH 16/17] unicore32: " Michal Hocko
2016-05-30  9:14   ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464599699-30131-15-git-send-email-mhocko@kernel.org \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=dalias@libc.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).