From: mcgrof@kernel.org
To: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
jpoimboe@redhat.com, bp@alien8.de, linux@arm.linux.org.uk,
mhiramat@kernel.org, masami.hiramatsu.pt@hitachi.com,
jbaron@akamai.com, heiko.carstens@de.ibm.com,
ananth@linux.vnet.ibm.com, anil.s.keshavamurthy@intel.com,
davem@davemloft.net, realmz6@gmail.com
Cc: x86@kernel.org, luto@amacapital.net, keescook@chromium.org,
torvalds@linux-foundation.org, gregkh@linuxfoundation.org,
rusty@rustcorp.com.au, gnomes@lxorguk.ukuu.org.uk,
alan@linux.intel.com, dwmw2@infradead.org, arnd@arndb.de,
ming.lei@canonical.com, linux-arch@vger.kernel.org,
benh@kernel.crashing.org, ananth@in.ibm.com, pebolle@tiscali.nl,
fontana@sharpeleven.org, david.vrabel@citrix.com,
konrad.wilk@oracle.com, mcb30@ipxe.org, jgross@suse.com,
andrew.cooper3@citrix.com, andriy.shevchenko@linux.intel.com,
paul.gortmaker@windriver.com, xen-devel@lists.xensource.com,
ak@linux.intel.com, pali.rohar@gmail.com, dvhart@infradead.org,
platform-driver-x86@vger.kernel.org, mmarek@suse.com,
linux@rasmusvillemoes.dk, jkosina@suse.cz, korea.drzix@gmail.com,
linux-kbuild@vger.kernel.org, tony.luck@intel.com,
akpm@linux-foundation.org, linux-ia64@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, catalin.marinas@arm.com,
will.deacon@arm.com, rostedt@goodmis.org, jani.nikula@intel.com,
mchehab@osg.samsung.com, markus.heiser@darmarit.de,
acme@redhat.com, jolsa@kernel.org, msalter@redhat.com,
chris@zankel.net, jcmvbkbc@gmail.com,
linux-xtensa@linux-xtensa.org, paulus@samba.org,
mpe@ellerman.id.au, James.Bottomley@HansenPartnership.com,
"Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [PATCH v4 01/16] x86: remove LTO_REFERENCE_INITCALL()
Date: Fri, 19 Aug 2016 14:32:50 -0700 [thread overview]
Message-ID: <1471642385-5629-2-git-send-email-mcgrof@kernel.org> (raw)
Message-ID: <20160819213250.koBLUZDi87sCxefNdXmHEHuYp72sDrCZH3tanyBZ0DY@z> (raw)
In-Reply-To: <1471642385-5629-1-git-send-email-mcgrof@kernel.org>
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
The setup for LTO never made it upstream, and although this has
some users, this is now really old stuff for a gcc 4.7 LTO problem.
We know that at least LTO_REFERENCE_INITCALL() work around can
be removed if LTO is not supported on v4.7 anymore.
As per Andi the DISABLE_LTO and LTO_CFLAGS are still neeeded though.
v3: added to this series, removing LTO_REFERENCE_INITCALL()
justifies that other future similar macros do not need
a respective LTO_REFERENCE_INITCALL() on them therefore
simplifying new code.
Acked-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
include/linux/init.h | 20 +-------------------
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/include/linux/init.h b/include/linux/init.h
index 1e5c131d5c9a..aa662ad80d9c 100644
--- a/include/linux/init.h
+++ b/include/linux/init.h
@@ -151,23 +151,6 @@ extern bool initcall_debug;
#ifndef __ASSEMBLY__
-#ifdef CONFIG_LTO
-/* Work around a LTO gcc problem: when there is no reference to a variable
- * in a module it will be moved to the end of the program. This causes
- * reordering of initcalls which the kernel does not like.
- * Add a dummy reference function to avoid this. The function is
- * deleted by the linker.
- */
-#define LTO_REFERENCE_INITCALL(x) \
- ; /* yes this is needed */ \
- static __used __exit void *reference_##x(void) \
- { \
- return &x; \
- }
-#else
-#define LTO_REFERENCE_INITCALL(x)
-#endif
-
/* initcalls are now grouped by functionality into separate
* subsections. Ordering inside the subsections is determined
* by link order.
@@ -180,8 +163,7 @@ extern bool initcall_debug;
#define __define_initcall(fn, id) \
static initcall_t __initcall_##fn##id __used \
- __attribute__((__section__(".initcall" #id ".init"))) = fn; \
- LTO_REFERENCE_INITCALL(__initcall_##fn##id)
+ __attribute__((__section__(".initcall" #id ".init"))) = fn;
/*
* Early initcalls run before initializing SMP.
--
2.9.2
next prev parent reply other threads:[~2016-08-19 21:41 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 21:32 [PATCH v4 00/16] linux: generalize sections, ranges and linker tables mcgrof
2016-08-19 21:32 ` mcgrof
2016-08-19 21:32 ` mcgrof [this message]
2016-08-19 21:32 ` [PATCH v4 01/16] x86: remove LTO_REFERENCE_INITCALL() mcgrof
2016-08-19 21:32 ` [PATCH v4 02/16] dell-smo8800: include uaccess.h mcgrof
2016-08-19 21:32 ` mcgrof
2016-08-19 21:32 ` [PATCH v4 03/16] scripts/module-common.lds: enable generation mcgrof
2016-08-19 21:32 ` mcgrof
2016-08-19 21:32 ` [PATCH v4 04/16] generic-sections: add section core helpers mcgrof
2016-08-19 21:32 ` mcgrof
2016-08-19 21:47 ` Kees Cook
2016-08-22 23:13 ` Luis R. Rodriguez
2016-08-19 21:32 ` [PATCH v4 05/16] xtensa: skip adding literal when SORT() is used mcgrof
2016-08-19 21:32 ` mcgrof
2016-08-19 21:32 ` [PATCH v4 06/16] ranges.h: add helpers to build and identify Linux section ranges mcgrof
2016-08-19 21:32 ` mcgrof
2016-08-19 21:55 ` Kees Cook
2016-08-22 23:48 ` Luis R. Rodriguez
2016-08-19 21:32 ` [PATCH v4 07/16] tables.h: add linker table support mcgrof
2016-08-19 21:32 ` mcgrof
2016-08-19 22:02 ` Kees Cook
2016-08-22 23:53 ` Luis R. Rodriguez
2016-08-19 21:32 ` [PATCH v4 08/16] kbuild: enable option to force compile force-obj-y and force-lib-y mcgrof
2016-08-19 21:32 ` mcgrof
2016-08-19 22:10 ` Kees Cook
2016-08-22 23:59 ` Luis R. Rodriguez
2016-08-30 20:15 ` Luis R. Rodriguez
2016-08-19 21:32 ` [PATCH v4 09/16] firmware/Makefile: force recompilation if makefile changes mcgrof
2016-08-19 21:32 ` mcgrof
2016-08-19 21:32 ` [PATCH v4 10/16] firmware: port built-in section to linker table mcgrof
2016-08-19 21:32 ` mcgrof
2016-08-19 22:29 ` [PATCH v4 00/16] linux: generalize sections, ranges and linker tables Kees Cook
2016-08-22 23:06 ` Luis R. Rodriguez
2016-08-19 21:33 mcgrof
2016-08-19 21:33 ` [PATCH v4 01/16] x86: remove LTO_REFERENCE_INITCALL() mcgrof
2016-08-19 21:33 ` mcgrof
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471642385-5629-2-git-send-email-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=ananth@in.ibm.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=andrew.cooper3@citrix.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chris@zankel.net \
--cc=davem@davemloft.net \
--cc=david.vrabel@citrix.com \
--cc=dvhart@infradead.org \
--cc=dwmw2@infradead.org \
--cc=fontana@sharpeleven.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jani.nikula@intel.com \
--cc=jbaron@akamai.com \
--cc=jcmvbkbc@gmail.com \
--cc=jgross@suse.com \
--cc=jkosina@suse.cz \
--cc=jolsa@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=konrad.wilk@oracle.com \
--cc=korea.drzix@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@rasmusvillemoes.dk \
--cc=luto@amacapital.net \
--cc=markus.heiser@darmarit.de \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mcb30@ipxe.org \
--cc=mchehab@osg.samsung.com \
--cc=mhiramat@kernel.org \
--cc=ming.lei@canonical.com \
--cc=mingo@redhat.com \
--cc=mmarek@suse.com \
--cc=mpe@ellerman.id.au \
--cc=msalter@redhat.com \
--cc=pali.rohar@gmail.com \
--cc=paul.gortmaker@windriver.com \
--cc=paulus@samba.org \
--cc=pebolle@tiscali.nl \
--cc=platform-driver-x86@vger.kernel.org \
--cc=realmz6@gmail.com \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).