From: Huacai Chen <chenhuacai@loongson.cn>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Cc: Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>, Guo Ren <guoren@kernel.org>,
linux-arch@vger.kernel.org, Rui Wang <wangrui@loongson.cn>,
Xuefeng Li <lixuefeng@loongson.cn>,
Huacai Chen <chenhuacai@gmail.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Huacai Chen <chenhuacai@loongson.cn>
Subject: [PATCH RFC 2/2] qspinlock: Use ARCH_HAS_HW_XCHG_SMALL to select _Q_PENDING_BITS definition
Date: Sat, 24 Jul 2021 20:36:17 +0800 [thread overview]
Message-ID: <20210724123617.3525377-2-chenhuacai@loongson.cn> (raw)
In-Reply-To: <20210724123617.3525377-1-chenhuacai@loongson.cn>
There are two types of bitfield definition in qspinlock data structues:
* When NR_CPUS < 16K
* 0- 7: locked byte
* 8: pending
* 9-15: not used
* 16-17: tail index
* 18-31: tail cpu (+1)
*
* When NR_CPUS >= 16K
* 0- 7: locked byte
* 8: pending
* 9-10: tail index
* 11-31: tail cpu (+1)
_Q_PENDING_BITS is 8 or 1 for the two types respectively. The second
type is a universal definition while the first type is an optimization
for NR_CPUS < 16K, but it relies on hardware 16bit xchg/cmpxchg support.
Unfortunately, some architectures don't have hardware sub-word xchg/
cmpxchg support. Though these archs can use software emulation (e.g.,
MIPS), but the cost is too expensive, and they have no benefits from
_Q_PENDING_BITS=8. So we only allow archs with ARCH_HAS_HW_XCHG_SMALL
to select _Q_PENDING_BITS=8.
This patch can let CSKY, RISC-V and other similar archs use qspinlock to
replace existing ticket spinlock.
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
---
include/asm-generic/qspinlock_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/asm-generic/qspinlock_types.h b/include/asm-generic/qspinlock_types.h
index 2fd1fb89ec36..458e5d941c92 100644
--- a/include/asm-generic/qspinlock_types.h
+++ b/include/asm-generic/qspinlock_types.h
@@ -71,7 +71,7 @@ typedef struct qspinlock {
#define _Q_LOCKED_MASK _Q_SET_MASK(LOCKED)
#define _Q_PENDING_OFFSET (_Q_LOCKED_OFFSET + _Q_LOCKED_BITS)
-#if CONFIG_NR_CPUS < (1U << 14)
+#if (CONFIG_NR_CPUS < (1U << 14)) && defined(CONFIG_ARCH_HAS_HW_XCHG_SMALL)
#define _Q_PENDING_BITS 8
#else
#define _Q_PENDING_BITS 1
--
2.27.0
next prev parent reply other threads:[~2021-07-24 12:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 12:36 [PATCH RFC 1/2] arch: Introduce ARCH_HAS_HW_XCHG_SMALL Huacai Chen
2021-07-24 12:36 ` Huacai Chen [this message]
2021-07-24 19:24 ` Arnd Bergmann
2021-07-25 3:06 ` Jiaxun Yang
2021-07-25 10:08 ` Arnd Bergmann
2021-07-26 8:36 ` Geert Uytterhoeven
2021-07-26 8:56 ` Huacai Chen
2021-07-26 10:39 ` Boqun Feng
2021-07-26 16:41 ` Guo Ren
2021-07-26 17:03 ` Boqun Feng
2021-07-26 21:20 ` Waiman Long
2021-07-27 1:27 ` Guo Ren
2021-07-27 2:29 ` Boqun Feng
2021-07-27 2:46 ` Waiman Long
2021-07-27 11:05 ` Peter Zijlstra
2021-07-28 10:40 ` Huacai Chen
2021-07-28 11:01 ` Peter Zijlstra
2021-07-29 16:38 ` Huacai Chen
2021-07-27 10:17 ` Peter Zijlstra
2021-07-27 1:07 ` Guo Ren
2021-07-27 1:52 ` Wang Rui
2021-07-27 11:03 ` Peter Zijlstra
2021-07-27 2:00 ` Boqun Feng
2021-07-27 10:50 ` Peter Zijlstra
2021-07-27 10:12 ` Peter Zijlstra
2021-07-26 9:00 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210724123617.3525377-2-chenhuacai@loongson.cn \
--to=chenhuacai@loongson.cn \
--cc=arnd@arndb.de \
--cc=boqun.feng@gmail.com \
--cc=chenhuacai@gmail.com \
--cc=guoren@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-arch@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=wangrui@loongson.cn \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).