* [PATCH v2 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow
[not found] <1360887677-20758-1-git-send-email-dianders@chromium.org>
@ 2013-02-15 0:21 ` Doug Anderson
2013-02-15 0:21 ` [PATCH v2 3/3] ARM: dts: Add sbs-battery " Doug Anderson
[not found] ` <1360957573-864-1-git-send-email-dianders@chromium.org>
2 siblings, 0 replies; 21+ messages in thread
From: Doug Anderson @ 2013-02-15 0:21 UTC (permalink / raw)
To: linux-arm-kernel
We need to use the i2c-arbitrator to talk to any of the devices on i2c
bus 4 on exynos5250-snow so that we don't confuse the embedded
controller (EC). Add the i2c-arbitrator to the device tree. As we
add future devices (keyboard, sbs, tps65090) we'll add them on top of
this.
The arbitrated bus is numbered 104 simply as a convenience to make it
easier for people poking around to guess that it might have something
to do with the physical bus 4.
The addition is split between the cros5250-common and the snow device
tree file since not all cros5250-class devices use arbitration.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
Changes in v2:
- Use new device tree property names / compatible string.
- Include that the GPIOs for arbitration are active low.
arch/arm/boot/dts/cros5250-common.dtsi | 5 ++++-
arch/arm/boot/dts/exynos5250-snow.dts | 25 +++++++++++++++++++++++++
2 files changed, 29 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi
index 46c0980..f451375 100644
--- a/arch/arm/boot/dts/cros5250-common.dtsi
+++ b/arch/arm/boot/dts/cros5250-common.dtsi
@@ -58,7 +58,10 @@
};
i2c at 12CA0000 {
- status = "disabled";
+ samsung,i2c-sda-delay = <100>;
+ samsung,i2c-max-bus-freq = <66000>;
+ gpios = <&gpa2 0 3 3 0>,
+ <&gpa2 1 3 3 0>;
};
i2c at 12CB0000 {
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 17dd951..d2d4b48 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -16,6 +16,10 @@
model = "Google Snow";
compatible = "google,snow", "samsung,exynos5250";
+ aliases {
+ i2c104 = &i2c_104;
+ };
+
gpio-keys {
compatible = "gpio-keys";
@@ -29,6 +33,27 @@
};
};
+ i2c-arbitrator {
+ compatible = "i2c-arbitrator-cros-ec";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ i2c-parent = <&{/i2c@12CA0000}>;
+
+ ap-claim-gpio = <&gpf0 3 1 0x10000 0>;
+ ec-claim-gpio = <&gpe0 4 0 0x10003 0>;
+ slew-delay-us = <10>;
+ wait-retry-us = <3000>;
+ wait-free-us = <50000>;
+
+ /* Use ID 104 as a hint that we're on physical bus 4 */
+ i2c_104: i2c at 0 {
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
+
/*
* On Snow we've got SIP WiFi and so can keep drive strengths low to
* reduce EMI.
--
1.8.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 3/3] ARM: dts: Add sbs-battery for exynos5250-snow
[not found] <1360887677-20758-1-git-send-email-dianders@chromium.org>
2013-02-15 0:21 ` [PATCH v2 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson
@ 2013-02-15 0:21 ` Doug Anderson
[not found] ` <1360957573-864-1-git-send-email-dianders@chromium.org>
2 siblings, 0 replies; 21+ messages in thread
From: Doug Anderson @ 2013-02-15 0:21 UTC (permalink / raw)
To: linux-arm-kernel
Now that we have i2c-arbitrator in place on bus 4 we can add the
sbs-battery driver. Future devices will be added onto bus 4 once
drivers are in good shape.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
Changes in v2: None
arch/arm/boot/dts/exynos5250-snow.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index d2d4b48..2127386 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -51,6 +51,12 @@
reg = <0>;
#address-cells = <1>;
#size-cells = <0>;
+
+ battery: sbs-battery at b {
+ compatible = "sbs,sbs-battery";
+ reg = <0xb>;
+ sbs,poll-retry-count = <1>;
+ };
};
};
--
1.8.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v3 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow
[not found] ` <1360957573-864-1-git-send-email-dianders@chromium.org>
@ 2013-02-15 19:46 ` Doug Anderson
2013-03-05 23:48 ` Naveen Krishna Ch
2013-02-15 19:46 ` [PATCH v3 3/3] ARM: dts: Add sbs-battery " Doug Anderson
[not found] ` <1363192583-26363-1-git-send-email-dianders@chromium.org>
2 siblings, 1 reply; 21+ messages in thread
From: Doug Anderson @ 2013-02-15 19:46 UTC (permalink / raw)
To: linux-arm-kernel
We need to use the i2c-arbitrator to talk to any of the devices on i2c
bus 4 on exynos5250-snow so that we don't confuse the embedded
controller (EC). Add the i2c-arbitrator to the device tree. As we
add future devices (keyboard, sbs, tps65090) we'll add them on top of
this.
The arbitrated bus is numbered 104 simply as a convenience to make it
easier for people poking around to guess that it might have something
to do with the physical bus 4.
The addition is split between the cros5250-common and the snow device
tree file since not all cros5250-class devices use arbitration.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
Changes in v3: None
Changes in v2:
- Use new device tree property names / compatible string.
- Include that the GPIOs for arbitration are active low.
arch/arm/boot/dts/cros5250-common.dtsi | 5 ++++-
arch/arm/boot/dts/exynos5250-snow.dts | 25 +++++++++++++++++++++++++
2 files changed, 29 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi
index 46c0980..f451375 100644
--- a/arch/arm/boot/dts/cros5250-common.dtsi
+++ b/arch/arm/boot/dts/cros5250-common.dtsi
@@ -58,7 +58,10 @@
};
i2c at 12CA0000 {
- status = "disabled";
+ samsung,i2c-sda-delay = <100>;
+ samsung,i2c-max-bus-freq = <66000>;
+ gpios = <&gpa2 0 3 3 0>,
+ <&gpa2 1 3 3 0>;
};
i2c at 12CB0000 {
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 17dd951..d2d4b48 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -16,6 +16,10 @@
model = "Google Snow";
compatible = "google,snow", "samsung,exynos5250";
+ aliases {
+ i2c104 = &i2c_104;
+ };
+
gpio-keys {
compatible = "gpio-keys";
@@ -29,6 +33,27 @@
};
};
+ i2c-arbitrator {
+ compatible = "i2c-arbitrator-cros-ec";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ i2c-parent = <&{/i2c@12CA0000}>;
+
+ ap-claim-gpio = <&gpf0 3 1 0x10000 0>;
+ ec-claim-gpio = <&gpe0 4 0 0x10003 0>;
+ slew-delay-us = <10>;
+ wait-retry-us = <3000>;
+ wait-free-us = <50000>;
+
+ /* Use ID 104 as a hint that we're on physical bus 4 */
+ i2c_104: i2c at 0 {
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
+
/*
* On Snow we've got SIP WiFi and so can keep drive strengths low to
* reduce EMI.
--
1.8.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v3 3/3] ARM: dts: Add sbs-battery for exynos5250-snow
[not found] ` <1360957573-864-1-git-send-email-dianders@chromium.org>
2013-02-15 19:46 ` [PATCH v3 2/3] ARM: dts: Add i2c-arbitrator bus " Doug Anderson
@ 2013-02-15 19:46 ` Doug Anderson
2013-03-05 23:49 ` Naveen Krishna Ch
[not found] ` <1363192583-26363-1-git-send-email-dianders@chromium.org>
2 siblings, 1 reply; 21+ messages in thread
From: Doug Anderson @ 2013-02-15 19:46 UTC (permalink / raw)
To: linux-arm-kernel
Now that we have i2c-arbitrator in place on bus 4 we can add the
sbs-battery driver. Future devices will be added onto bus 4 once
drivers are in good shape.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
Changes in v3: None
Changes in v2: None
arch/arm/boot/dts/exynos5250-snow.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index d2d4b48..2127386 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -51,6 +51,12 @@
reg = <0>;
#address-cells = <1>;
#size-cells = <0>;
+
+ battery: sbs-battery at b {
+ compatible = "sbs,sbs-battery";
+ reg = <0xb>;
+ sbs,poll-retry-count = <1>;
+ };
};
};
--
1.8.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v3 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow
2013-02-15 19:46 ` [PATCH v3 2/3] ARM: dts: Add i2c-arbitrator bus " Doug Anderson
@ 2013-03-05 23:48 ` Naveen Krishna Ch
2013-03-13 7:30 ` Kukjin Kim
0 siblings, 1 reply; 21+ messages in thread
From: Naveen Krishna Ch @ 2013-03-05 23:48 UTC (permalink / raw)
To: linux-arm-kernel
On 16 February 2013 04:46, Doug Anderson <dianders@chromium.org> wrote:
> We need to use the i2c-arbitrator to talk to any of the devices on i2c
> bus 4 on exynos5250-snow so that we don't confuse the embedded
> controller (EC). Add the i2c-arbitrator to the device tree. As we
> add future devices (keyboard, sbs, tps65090) we'll add them on top of
> this.
>
> The arbitrated bus is numbered 104 simply as a convenience to make it
> easier for people poking around to guess that it might have something
> to do with the physical bus 4.
>
> The addition is split between the cros5250-common and the snow device
> tree file since not all cros5250-class devices use arbitration.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
Tested-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
The patch set [v3] is tested on snow with test case which uses i2c-4 from both
EC and AP side continuously for a more than a couple of minutes.
> ---
> Changes in v3: None
> Changes in v2:
> - Use new device tree property names / compatible string.
> - Include that the GPIOs for arbitration are active low.
>
> arch/arm/boot/dts/cros5250-common.dtsi | 5 ++++-
> arch/arm/boot/dts/exynos5250-snow.dts | 25 +++++++++++++++++++++++++
> 2 files changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi
> index 46c0980..f451375 100644
> --- a/arch/arm/boot/dts/cros5250-common.dtsi
> +++ b/arch/arm/boot/dts/cros5250-common.dtsi
> @@ -58,7 +58,10 @@
> };
>
> i2c at 12CA0000 {
> - status = "disabled";
> + samsung,i2c-sda-delay = <100>;
> + samsung,i2c-max-bus-freq = <66000>;
> + gpios = <&gpa2 0 3 3 0>,
> + <&gpa2 1 3 3 0>;
> };
>
> i2c at 12CB0000 {
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index 17dd951..d2d4b48 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -16,6 +16,10 @@
> model = "Google Snow";
> compatible = "google,snow", "samsung,exynos5250";
>
> + aliases {
> + i2c104 = &i2c_104;
> + };
> +
> gpio-keys {
> compatible = "gpio-keys";
>
> @@ -29,6 +33,27 @@
> };
> };
>
> + i2c-arbitrator {
> + compatible = "i2c-arbitrator-cros-ec";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + i2c-parent = <&{/i2c@12CA0000}>;
> +
> + ap-claim-gpio = <&gpf0 3 1 0x10000 0>;
> + ec-claim-gpio = <&gpe0 4 0 0x10003 0>;
> + slew-delay-us = <10>;
> + wait-retry-us = <3000>;
> + wait-free-us = <50000>;
> +
> + /* Use ID 104 as a hint that we're on physical bus 4 */
> + i2c_104: i2c at 0 {
> + reg = <0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> + };
> +
> /*
> * On Snow we've got SIP WiFi and so can keep drive strengths low to
> * reduce EMI.
> --
> 1.8.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Shine bright,
(: Nav :)
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v3 3/3] ARM: dts: Add sbs-battery for exynos5250-snow
2013-02-15 19:46 ` [PATCH v3 3/3] ARM: dts: Add sbs-battery " Doug Anderson
@ 2013-03-05 23:49 ` Naveen Krishna Ch
0 siblings, 0 replies; 21+ messages in thread
From: Naveen Krishna Ch @ 2013-03-05 23:49 UTC (permalink / raw)
To: linux-arm-kernel
On 16 February 2013 04:46, Doug Anderson <dianders@chromium.org> wrote:
> Now that we have i2c-arbitrator in place on bus 4 we can add the
> sbs-battery driver. Future devices will be added onto bus 4 once
> drivers are in good shape.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
Tested-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
The patchset v3 is tested on snow with test case which uses i2c-4 from both
EC and AP side continuously for a more than a couple of minutes
> ---
> Changes in v3: None
> Changes in v2: None
>
> arch/arm/boot/dts/exynos5250-snow.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index d2d4b48..2127386 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -51,6 +51,12 @@
> reg = <0>;
> #address-cells = <1>;
> #size-cells = <0>;
> +
> + battery: sbs-battery at b {
> + compatible = "sbs,sbs-battery";
> + reg = <0xb>;
> + sbs,poll-retry-count = <1>;
> + };
> };
> };
>
> --
> 1.8.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Shine bright,
(: Nav :)
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v3 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow
2013-03-05 23:48 ` Naveen Krishna Ch
@ 2013-03-13 7:30 ` Kukjin Kim
2013-03-13 15:14 ` Doug Anderson
0 siblings, 1 reply; 21+ messages in thread
From: Kukjin Kim @ 2013-03-13 7:30 UTC (permalink / raw)
To: linux-arm-kernel
Naveen Krishna Ch wrote:
> On 16 February 2013 04:46, Doug Anderson <dianders@chromium.org> wrote:
> > We need to use the i2c-arbitrator to talk to any of the devices on i2c
> > bus 4 on exynos5250-snow so that we don't confuse the embedded
> > controller (EC). Add the i2c-arbitrator to the device tree. As we
> > add future devices (keyboard, sbs, tps65090) we'll add them on top of
> > this.
> >
> > The arbitrated bus is numbered 104 simply as a convenience to make it
> > easier for people poking around to guess that it might have something
> > to do with the physical bus 4.
> >
> > The addition is split between the cros5250-common and the snow device
> > tree file since not all cros5250-class devices use arbitration.
> >
> > Signed-off-by: Doug Anderson <dianders@chromium.org>
> Tested-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> The patch set [v3] is tested on snow with test case which uses i2c-4 from both
> EC and AP side continuously for a more than a couple of minutes.
>
Thanks for your test and looks good to me.
BTW, Doug, I think, this should be re-worked to use pinctrl. Can you?
Thanks.
- Kukjin
> > ---
> > Changes in v3: None
> > Changes in v2:
> > - Use new device tree property names / compatible string.
> > - Include that the GPIOs for arbitration are active low.
> >
> > arch/arm/boot/dts/cros5250-common.dtsi | 5 ++++-
> > arch/arm/boot/dts/exynos5250-snow.dts | 25 +++++++++++++++++++++++++
> > 2 files changed, 29 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/cros5250-common.dtsi
> b/arch/arm/boot/dts/cros5250-common.dtsi
> > index 46c0980..f451375 100644
> > --- a/arch/arm/boot/dts/cros5250-common.dtsi
> > +++ b/arch/arm/boot/dts/cros5250-common.dtsi
> > @@ -58,7 +58,10 @@
> > };
> >
> > i2c at 12CA0000 {
> > - status = "disabled";
> > + samsung,i2c-sda-delay = <100>;
> > + samsung,i2c-max-bus-freq = <66000>;
> > + gpios = <&gpa2 0 3 3 0>,
> > + <&gpa2 1 3 3 0>;
> > };
> >
> > i2c at 12CB0000 {
> > diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
> b/arch/arm/boot/dts/exynos5250-snow.dts
> > index 17dd951..d2d4b48 100644
> > --- a/arch/arm/boot/dts/exynos5250-snow.dts
> > +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> > @@ -16,6 +16,10 @@
> > model = "Google Snow";
> > compatible = "google,snow", "samsung,exynos5250";
> >
> > + aliases {
> > + i2c104 = &i2c_104;
> > + };
> > +
> > gpio-keys {
> > compatible = "gpio-keys";
> >
> > @@ -29,6 +33,27 @@
> > };
> > };
> >
> > + i2c-arbitrator {
> > + compatible = "i2c-arbitrator-cros-ec";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + i2c-parent = <&{/i2c@12CA0000}>;
> > +
> > + ap-claim-gpio = <&gpf0 3 1 0x10000 0>;
> > + ec-claim-gpio = <&gpe0 4 0 0x10003 0>;
> > + slew-delay-us = <10>;
> > + wait-retry-us = <3000>;
> > + wait-free-us = <50000>;
> > +
> > + /* Use ID 104 as a hint that we're on physical bus 4 */
> > + i2c_104: i2c at 0 {
> > + reg = <0>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + };
> > + };
> > +
> > /*
> > * On Snow we've got SIP WiFi and so can keep drive strengths low to
> > * reduce EMI.
> > --
> > 1.8.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo at vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
>
>
>
> --
> Shine bright,
> (: Nav :)
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v3 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow
2013-03-13 7:30 ` Kukjin Kim
@ 2013-03-13 15:14 ` Doug Anderson
0 siblings, 0 replies; 21+ messages in thread
From: Doug Anderson @ 2013-03-13 15:14 UTC (permalink / raw)
To: linux-arm-kernel
Kukjin,
On Wed, Mar 13, 2013 at 12:30 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> BTW, Doug, I think, this should be re-worked to use pinctrl. Can you?
Yes, I've already got this locally. I hadn't sent it up yet since I
wasn't sure whether pinctrl would land before or after this. I'll
send it up today against my local cherry-pick of Thomas's pinctrl
stuff (since it doesn't seem to be in linux-next nor in
arm-soc/for-next).
Naveen: I'm going to keep your Tested-by on all 3 patches if that's
OK. The only difference will be the gpio specifier in the device tree
and the change is trivial.
-Doug
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v4 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow
[not found] ` <1363192583-26363-1-git-send-email-dianders@chromium.org>
@ 2013-03-13 16:36 ` Doug Anderson
2013-03-13 16:36 ` [PATCH v4 3/3] ARM: dts: Add sbs-battery " Doug Anderson
` (2 subsequent siblings)
3 siblings, 0 replies; 21+ messages in thread
From: Doug Anderson @ 2013-03-13 16:36 UTC (permalink / raw)
To: linux-arm-kernel
We need to use the i2c-arbitrator to talk to any of the devices on i2c
bus 4 on exynos5250-snow so that we don't confuse the embedded
controller (EC). Add the i2c-arbitrator to the device tree. As we
add future devices (keyboard, sbs, tps65090) we'll add them on top of
this.
The arbitrated bus is numbered 104 simply as a convenience to make it
easier for people poking around to guess that it might have something
to do with the physical bus 4.
The addition is split between the cros5250-common and the snow device
tree file since not all cros5250-class devices use arbitration.
Signed-off-by: Doug Anderson <dianders@chromium.org>
Tested-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
---
Changes in v4:
- Changed mux gpio syntax to work atop Thomas's "ARM: dts: add pin
state information in client nodes for Exynos5 platforms"; avoid
adding gpios property to i2c at 12CA0000 for the same reason.
Changes in v3: None
Changes in v2:
- Use new device tree property names / compatible string.
- Include that the GPIOs for arbitration are active low.
arch/arm/boot/dts/cros5250-common.dtsi | 3 ++-
arch/arm/boot/dts/exynos5250-snow.dts | 25 +++++++++++++++++++++++++
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi
index 8a5b3a6..0a61bbb 100644
--- a/arch/arm/boot/dts/cros5250-common.dtsi
+++ b/arch/arm/boot/dts/cros5250-common.dtsi
@@ -193,7 +193,8 @@
};
i2c at 12CA0000 {
- status = "disabled";
+ samsung,i2c-sda-delay = <100>;
+ samsung,i2c-max-bus-freq = <66000>;
};
i2c at 12CB0000 {
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 581ffae..bf16353 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -16,6 +16,10 @@
model = "Google Snow";
compatible = "google,snow", "samsung,exynos5250";
+ aliases {
+ i2c104 = &i2c_104;
+ };
+
pinctrl at 11400000 {
sd3_clk: sd3-clk {
samsung,pin-drv = <0>;
@@ -44,6 +48,27 @@
};
};
+ i2c-arbitrator {
+ compatible = "i2c-arbitrator-cros-ec";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ i2c-parent = <&{/i2c@12CA0000}>;
+
+ ap-claim-gpio = <&gpf0 3 1>;
+ ec-claim-gpio = <&gpe0 4 1>;
+ slew-delay-us = <10>;
+ wait-retry-us = <3000>;
+ wait-free-us = <50000>;
+
+ /* Use ID 104 as a hint that we're on physical bus 4 */
+ i2c_104: i2c at 0 {
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
+
/*
* On Snow we've got SIP WiFi and so can keep drive strengths low to
* reduce EMI.
--
1.8.1.3
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v4 3/3] ARM: dts: Add sbs-battery for exynos5250-snow
[not found] ` <1363192583-26363-1-git-send-email-dianders@chromium.org>
2013-03-13 16:36 ` [PATCH v4 2/3] ARM: dts: Add i2c-arbitrator bus " Doug Anderson
@ 2013-03-13 16:36 ` Doug Anderson
[not found] ` <1365538361-2763-1-git-send-email-dianders@chromium.org>
[not found] ` <1365543270-10736-1-git-send-email-dianders@chromium.org>
3 siblings, 0 replies; 21+ messages in thread
From: Doug Anderson @ 2013-03-13 16:36 UTC (permalink / raw)
To: linux-arm-kernel
Now that we have i2c-arbitrator in place on bus 4 we can add the
sbs-battery driver. Future devices will be added onto bus 4 once
drivers are in good shape.
Signed-off-by: Doug Anderson <dianders@chromium.org>
Tested-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/arm/boot/dts/exynos5250-snow.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index bf16353..7aa66c8 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -66,6 +66,12 @@
reg = <0>;
#address-cells = <1>;
#size-cells = <0>;
+
+ battery: sbs-battery at b {
+ compatible = "sbs,sbs-battery";
+ reg = <0xb>;
+ sbs,poll-retry-count = <1>;
+ };
};
};
--
1.8.1.3
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow
[not found] ` <1365538361-2763-1-git-send-email-dianders@chromium.org>
@ 2013-04-09 20:12 ` Doug Anderson
2013-04-09 20:12 ` [PATCH v5 3/3] ARM: dts: Add sbs-battery " Doug Anderson
1 sibling, 0 replies; 21+ messages in thread
From: Doug Anderson @ 2013-04-09 20:12 UTC (permalink / raw)
To: linux-arm-kernel
We need to use the i2c-arbitrator to talk to any of the devices on i2c
bus 4 on exynos5250-snow so that we don't confuse the embedded
controller (EC). Add the i2c-arbitrator to the device tree. As we
add future devices (keyboard, sbs, tps65090) we'll add them on top of
this.
The arbitrated bus is numbered 104 simply as a convenience to make it
easier for people poking around to guess that it might have something
to do with the physical bus 4.
The addition is split between the cros5250-common and the snow device
tree file since not all cros5250-class devices use arbitration.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
Changes in v5:
- Adjust bindings as per Wolfram Sang.
Changes in v4:
- Changed mux gpio syntax to work atop Thomas's "ARM: dts: add pin
state information in client nodes for Exynos5 platforms"; avoid
adding gpios property to i2c at 12CA0000 for the same reason.
Changes in v3: None
Changes in v2:
- Use new device tree property names / compatible string.
- Include that the GPIOs for arbitration are active low.
arch/arm/boot/dts/cros5250-common.dtsi | 3 ++-
arch/arm/boot/dts/exynos5250-snow.dts | 25 +++++++++++++++++++++++++
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi
index 8a5b3a6..0a61bbb 100644
--- a/arch/arm/boot/dts/cros5250-common.dtsi
+++ b/arch/arm/boot/dts/cros5250-common.dtsi
@@ -193,7 +193,8 @@
};
i2c at 12CA0000 {
- status = "disabled";
+ samsung,i2c-sda-delay = <100>;
+ samsung,i2c-max-bus-freq = <66000>;
};
i2c at 12CB0000 {
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 581ffae..fa85f58 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -16,6 +16,10 @@
model = "Google Snow";
compatible = "google,snow", "samsung,exynos5250";
+ aliases {
+ i2c104 = &i2c_104;
+ };
+
pinctrl at 11400000 {
sd3_clk: sd3-clk {
samsung,pin-drv = <0>;
@@ -44,6 +48,27 @@
};
};
+ i2c-arbitrator {
+ compatible = "i2c-arb-gpio-challenge";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ i2c-parent = <&{/i2c@12CA0000}>;
+
+ our-claim-gpio = <&gpf0 3 1>;
+ their-claim-gpios = <&gpe0 4 1>;
+ slew-delay-us = <10>;
+ wait-retry-us = <3000>;
+ wait-free-us = <50000>;
+
+ /* Use ID 104 as a hint that we're on physical bus 4 */
+ i2c_104: i2c at 0 {
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
+
/*
* On Snow we've got SIP WiFi and so can keep drive strengths low to
* reduce EMI.
--
1.8.1.3
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v5 3/3] ARM: dts: Add sbs-battery for exynos5250-snow
[not found] ` <1365538361-2763-1-git-send-email-dianders@chromium.org>
2013-04-09 20:12 ` [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus " Doug Anderson
@ 2013-04-09 20:12 ` Doug Anderson
1 sibling, 0 replies; 21+ messages in thread
From: Doug Anderson @ 2013-04-09 20:12 UTC (permalink / raw)
To: linux-arm-kernel
Now that we have i2c-arbitrator in place on bus 4 we can add the
sbs-battery driver. Future devices will be added onto bus 4 once
drivers are in good shape.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/arm/boot/dts/exynos5250-snow.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index fa85f58..c115143 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -66,6 +66,12 @@
reg = <0>;
#address-cells = <1>;
#size-cells = <0>;
+
+ battery: sbs-battery at b {
+ compatible = "sbs,sbs-battery";
+ reg = <0xb>;
+ sbs,poll-retry-count = <1>;
+ };
};
};
--
1.8.1.3
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow
[not found] ` <1365543270-10736-1-git-send-email-dianders@chromium.org>
@ 2013-04-09 21:34 ` Doug Anderson
2013-04-10 10:59 ` Kukjin Kim
2013-04-09 21:34 ` [PATCH v5 3/3] ARM: dts: Add sbs-battery " Doug Anderson
[not found] ` <1366129742-16048-1-git-send-email-dianders@chromium.org>
2 siblings, 1 reply; 21+ messages in thread
From: Doug Anderson @ 2013-04-09 21:34 UTC (permalink / raw)
To: linux-arm-kernel
We need to use the i2c-arbitrator to talk to any of the devices on i2c
bus 4 on exynos5250-snow so that we don't confuse the embedded
controller (EC). Add the i2c-arbitrator to the device tree. As we
add future devices (keyboard, sbs, tps65090) we'll add them on top of
this.
The arbitrated bus is numbered 104 simply as a convenience to make it
easier for people poking around to guess that it might have something
to do with the physical bus 4.
The addition is split between the cros5250-common and the snow device
tree file since not all cros5250-class devices use arbitration.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
Changes in v5:
- Adjust bindings as per Wolfram Sang.
Changes in v4:
- Changed mux gpio syntax to work atop Thomas's "ARM: dts: add pin
state information in client nodes for Exynos5 platforms"; avoid
adding gpios property to i2c at 12CA0000 for the same reason.
Changes in v3: None
Changes in v2:
- Use new device tree property names / compatible string.
- Include that the GPIOs for arbitration are active low.
arch/arm/boot/dts/cros5250-common.dtsi | 3 ++-
arch/arm/boot/dts/exynos5250-snow.dts | 25 +++++++++++++++++++++++++
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi
index 8a5b3a6..0a61bbb 100644
--- a/arch/arm/boot/dts/cros5250-common.dtsi
+++ b/arch/arm/boot/dts/cros5250-common.dtsi
@@ -193,7 +193,8 @@
};
i2c at 12CA0000 {
- status = "disabled";
+ samsung,i2c-sda-delay = <100>;
+ samsung,i2c-max-bus-freq = <66000>;
};
i2c at 12CB0000 {
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 581ffae..fa85f58 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -16,6 +16,10 @@
model = "Google Snow";
compatible = "google,snow", "samsung,exynos5250";
+ aliases {
+ i2c104 = &i2c_104;
+ };
+
pinctrl at 11400000 {
sd3_clk: sd3-clk {
samsung,pin-drv = <0>;
@@ -44,6 +48,27 @@
};
};
+ i2c-arbitrator {
+ compatible = "i2c-arb-gpio-challenge";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ i2c-parent = <&{/i2c@12CA0000}>;
+
+ our-claim-gpio = <&gpf0 3 1>;
+ their-claim-gpios = <&gpe0 4 1>;
+ slew-delay-us = <10>;
+ wait-retry-us = <3000>;
+ wait-free-us = <50000>;
+
+ /* Use ID 104 as a hint that we're on physical bus 4 */
+ i2c_104: i2c at 0 {
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
+
/*
* On Snow we've got SIP WiFi and so can keep drive strengths low to
* reduce EMI.
--
1.8.1.3
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v5 3/3] ARM: dts: Add sbs-battery for exynos5250-snow
[not found] ` <1365543270-10736-1-git-send-email-dianders@chromium.org>
2013-04-09 21:34 ` [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus " Doug Anderson
@ 2013-04-09 21:34 ` Doug Anderson
[not found] ` <1366129742-16048-1-git-send-email-dianders@chromium.org>
2 siblings, 0 replies; 21+ messages in thread
From: Doug Anderson @ 2013-04-09 21:34 UTC (permalink / raw)
To: linux-arm-kernel
Now that we have i2c-arbitrator in place on bus 4 we can add the
sbs-battery driver. Future devices will be added onto bus 4 once
drivers are in good shape.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/arm/boot/dts/exynos5250-snow.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index fa85f58..c115143 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -66,6 +66,12 @@
reg = <0>;
#address-cells = <1>;
#size-cells = <0>;
+
+ battery: sbs-battery at b {
+ compatible = "sbs,sbs-battery";
+ reg = <0xb>;
+ sbs,poll-retry-count = <1>;
+ };
};
};
--
1.8.1.3
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow
2013-04-09 21:34 ` [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus " Doug Anderson
@ 2013-04-10 10:59 ` Kukjin Kim
2013-04-10 11:02 ` Wolfram Sang
0 siblings, 1 reply; 21+ messages in thread
From: Kukjin Kim @ 2013-04-10 10:59 UTC (permalink / raw)
To: linux-arm-kernel
Doug Anderson wrote:
>
> We need to use the i2c-arbitrator to talk to any of the devices on i2c
> bus 4 on exynos5250-snow so that we don't confuse the embedded
> controller (EC). Add the i2c-arbitrator to the device tree. As we
> add future devices (keyboard, sbs, tps65090) we'll add them on top of
> this.
>
> The arbitrated bus is numbered 104 simply as a convenience to make it
> easier for people poking around to guess that it might have something
> to do with the physical bus 4.
>
> The addition is split between the cros5250-common and the snow device
> tree file since not all cros5250-class devices use arbitration.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
I'm fine on 2nd and 3rd patches. Shall I take only two patches without 1st
one in samsung tree?
- Kukjin
> ---
> Changes in v5:
> - Adjust bindings as per Wolfram Sang.
>
> Changes in v4:
> - Changed mux gpio syntax to work atop Thomas's "ARM: dts: add pin
> state information in client nodes for Exynos5 platforms"; avoid
> adding gpios property to i2c at 12CA0000 for the same reason.
>
> Changes in v3: None
> Changes in v2:
> - Use new device tree property names / compatible string.
> - Include that the GPIOs for arbitration are active low.
>
> arch/arm/boot/dts/cros5250-common.dtsi | 3 ++-
> arch/arm/boot/dts/exynos5250-snow.dts | 25 +++++++++++++++++++++++++
> 2 files changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/cros5250-common.dtsi
> b/arch/arm/boot/dts/cros5250-common.dtsi
> index 8a5b3a6..0a61bbb 100644
> --- a/arch/arm/boot/dts/cros5250-common.dtsi
> +++ b/arch/arm/boot/dts/cros5250-common.dtsi
> @@ -193,7 +193,8 @@
> };
>
> i2c at 12CA0000 {
> - status = "disabled";
> + samsung,i2c-sda-delay = <100>;
> + samsung,i2c-max-bus-freq = <66000>;
> };
>
> i2c at 12CB0000 {
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
> b/arch/arm/boot/dts/exynos5250-snow.dts
> index 581ffae..fa85f58 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -16,6 +16,10 @@
> model = "Google Snow";
> compatible = "google,snow", "samsung,exynos5250";
>
> + aliases {
> + i2c104 = &i2c_104;
> + };
> +
> pinctrl at 11400000 {
> sd3_clk: sd3-clk {
> samsung,pin-drv = <0>;
> @@ -44,6 +48,27 @@
> };
> };
>
> + i2c-arbitrator {
> + compatible = "i2c-arb-gpio-challenge";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + i2c-parent = <&{/i2c@12CA0000}>;
> +
> + our-claim-gpio = <&gpf0 3 1>;
> + their-claim-gpios = <&gpe0 4 1>;
> + slew-delay-us = <10>;
> + wait-retry-us = <3000>;
> + wait-free-us = <50000>;
> +
> + /* Use ID 104 as a hint that we're on physical bus 4 */
> + i2c_104: i2c at 0 {
> + reg = <0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> + };
> +
> /*
> * On Snow we've got SIP WiFi and so can keep drive strengths low
> to
> * reduce EMI.
> --
> 1.8.1.3
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow
2013-04-10 10:59 ` Kukjin Kim
@ 2013-04-10 11:02 ` Wolfram Sang
2013-04-10 14:12 ` Kukjin Kim
0 siblings, 1 reply; 21+ messages in thread
From: Wolfram Sang @ 2013-04-10 11:02 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Apr 10, 2013 at 07:59:17PM +0900, Kukjin Kim wrote:
> Doug Anderson wrote:
> >
> > We need to use the i2c-arbitrator to talk to any of the devices on i2c
> > bus 4 on exynos5250-snow so that we don't confuse the embedded
> > controller (EC). Add the i2c-arbitrator to the device tree. As we
> > add future devices (keyboard, sbs, tps65090) we'll add them on top of
> > this.
> >
> > The arbitrated bus is numbered 104 simply as a convenience to make it
> > easier for people poking around to guess that it might have something
> > to do with the physical bus 4.
> >
> > The addition is split between the cros5250-common and the snow device
> > tree file since not all cros5250-class devices use arbitration.
> >
> > Signed-off-by: Doug Anderson <dianders@chromium.org>
>
> I'm fine on 2nd and 3rd patches. Shall I take only two patches without 1st
> one in samsung tree?
Please wait for my OK on patch 1. Or ack patches 2 and 3 and I will pick
them up. I am fine with both.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow
2013-04-10 11:02 ` Wolfram Sang
@ 2013-04-10 14:12 ` Kukjin Kim
0 siblings, 0 replies; 21+ messages in thread
From: Kukjin Kim @ 2013-04-10 14:12 UTC (permalink / raw)
To: linux-arm-kernel
On 04/10/13 20:02, Wolfram Sang wrote:
> On Wed, Apr 10, 2013 at 07:59:17PM +0900, Kukjin Kim wrote:
>> Doug Anderson wrote:
>>>
>>> We need to use the i2c-arbitrator to talk to any of the devices on i2c
>>> bus 4 on exynos5250-snow so that we don't confuse the embedded
>>> controller (EC). Add the i2c-arbitrator to the device tree. As we
>>> add future devices (keyboard, sbs, tps65090) we'll add them on top of
>>> this.
>>>
>>> The arbitrated bus is numbered 104 simply as a convenience to make it
>>> easier for people poking around to guess that it might have something
>>> to do with the physical bus 4.
>>>
>>> The addition is split between the cros5250-common and the snow device
>>> tree file since not all cros5250-class devices use arbitration.
>>>
>>> Signed-off-by: Doug Anderson<dianders@chromium.org>
>>
>> I'm fine on 2nd and 3rd patches. Shall I take only two patches without 1st
>> one in samsung tree?
>
> Please wait for my OK on patch 1. Or ack patches 2 and 3 and I will pick
> them up. I am fine with both.
>
OK, I will wait for your reply on this. Because I suppose if the dt
patches in your tree could make useless conflicts. Anyway let me know
your opinion on that.
Thanks.
- Kukjin
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v6 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow
[not found] ` <1366129742-16048-1-git-send-email-dianders@chromium.org>
@ 2013-04-16 16:29 ` Doug Anderson
2013-04-16 16:35 ` Olof Johansson
2013-04-16 16:29 ` [PATCH v6 3/3] ARM: dts: Add sbs-battery " Doug Anderson
1 sibling, 1 reply; 21+ messages in thread
From: Doug Anderson @ 2013-04-16 16:29 UTC (permalink / raw)
To: linux-arm-kernel
We need to use the i2c-arbitrator to talk to any of the devices on i2c
bus 4 on exynos5250-snow so that we don't confuse the embedded
controller (EC). Add the i2c-arbitrator to the device tree. As we
add future devices (keyboard, sbs, tps65090) we'll add them on top of
this.
The arbitrated bus is numbered 104 simply as a convenience to make it
easier for people poking around to guess that it might have something
to do with the physical bus 4.
The addition is split between the cros5250-common and the snow device
tree file since not all cros5250-class devices use arbitration.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
Changes in v6: None
Changes in v5:
- Adjust bindings as per Wolfram Sang.
Changes in v4:
- Changed mux gpio syntax to work atop Thomas's "ARM: dts: add pin
state information in client nodes for Exynos5 platforms"; avoid
adding gpios property to i2c at 12CA0000 for the same reason.
Changes in v3: None
Changes in v2:
- Use new device tree property names / compatible string.
- Include that the GPIOs for arbitration are active low.
arch/arm/boot/dts/cros5250-common.dtsi | 3 ++-
arch/arm/boot/dts/exynos5250-snow.dts | 25 +++++++++++++++++++++++++
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi
index 8a5b3a6..0a61bbb 100644
--- a/arch/arm/boot/dts/cros5250-common.dtsi
+++ b/arch/arm/boot/dts/cros5250-common.dtsi
@@ -193,7 +193,8 @@
};
i2c at 12CA0000 {
- status = "disabled";
+ samsung,i2c-sda-delay = <100>;
+ samsung,i2c-max-bus-freq = <66000>;
};
i2c at 12CB0000 {
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 581ffae..fa85f58 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -16,6 +16,10 @@
model = "Google Snow";
compatible = "google,snow", "samsung,exynos5250";
+ aliases {
+ i2c104 = &i2c_104;
+ };
+
pinctrl at 11400000 {
sd3_clk: sd3-clk {
samsung,pin-drv = <0>;
@@ -44,6 +48,27 @@
};
};
+ i2c-arbitrator {
+ compatible = "i2c-arb-gpio-challenge";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ i2c-parent = <&{/i2c@12CA0000}>;
+
+ our-claim-gpio = <&gpf0 3 1>;
+ their-claim-gpios = <&gpe0 4 1>;
+ slew-delay-us = <10>;
+ wait-retry-us = <3000>;
+ wait-free-us = <50000>;
+
+ /* Use ID 104 as a hint that we're on physical bus 4 */
+ i2c_104: i2c at 0 {
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
+
/*
* On Snow we've got SIP WiFi and so can keep drive strengths low to
* reduce EMI.
--
1.8.1.3
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v6 3/3] ARM: dts: Add sbs-battery for exynos5250-snow
[not found] ` <1366129742-16048-1-git-send-email-dianders@chromium.org>
2013-04-16 16:29 ` [PATCH v6 2/3] ARM: dts: Add i2c-arbitrator bus " Doug Anderson
@ 2013-04-16 16:29 ` Doug Anderson
2013-04-16 16:36 ` Olof Johansson
1 sibling, 1 reply; 21+ messages in thread
From: Doug Anderson @ 2013-04-16 16:29 UTC (permalink / raw)
To: linux-arm-kernel
Now that we have i2c-arbitrator in place on bus 4 we can add the
sbs-battery driver. Future devices will be added onto bus 4 once
drivers are in good shape.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/arm/boot/dts/exynos5250-snow.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index fa85f58..c115143 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -66,6 +66,12 @@
reg = <0>;
#address-cells = <1>;
#size-cells = <0>;
+
+ battery: sbs-battery at b {
+ compatible = "sbs,sbs-battery";
+ reg = <0xb>;
+ sbs,poll-retry-count = <1>;
+ };
};
};
--
1.8.1.3
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v6 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow
2013-04-16 16:29 ` [PATCH v6 2/3] ARM: dts: Add i2c-arbitrator bus " Doug Anderson
@ 2013-04-16 16:35 ` Olof Johansson
0 siblings, 0 replies; 21+ messages in thread
From: Olof Johansson @ 2013-04-16 16:35 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Apr 16, 2013 at 09:29:01AM -0700, Doug Anderson wrote:
> We need to use the i2c-arbitrator to talk to any of the devices on i2c
> bus 4 on exynos5250-snow so that we don't confuse the embedded
> controller (EC). Add the i2c-arbitrator to the device tree. As we
> add future devices (keyboard, sbs, tps65090) we'll add them on top of
> this.
>
> The arbitrated bus is numbered 104 simply as a convenience to make it
> easier for people poking around to guess that it might have something
> to do with the physical bus 4.
>
> The addition is split between the cros5250-common and the snow device
> tree file since not all cros5250-class devices use arbitration.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
Acked-by: Olof Johansson <olof@lixom.net>
-Olof
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v6 3/3] ARM: dts: Add sbs-battery for exynos5250-snow
2013-04-16 16:29 ` [PATCH v6 3/3] ARM: dts: Add sbs-battery " Doug Anderson
@ 2013-04-16 16:36 ` Olof Johansson
0 siblings, 0 replies; 21+ messages in thread
From: Olof Johansson @ 2013-04-16 16:36 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Apr 16, 2013 at 09:29:02AM -0700, Doug Anderson wrote:
> Now that we have i2c-arbitrator in place on bus 4 we can add the
> sbs-battery driver. Future devices will be added onto bus 4 once
> drivers are in good shape.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
Acked-by: Olof Johansson <olof@lixom.net>
-Olof
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2013-04-16 16:36 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1360887677-20758-1-git-send-email-dianders@chromium.org>
2013-02-15 0:21 ` [PATCH v2 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson
2013-02-15 0:21 ` [PATCH v2 3/3] ARM: dts: Add sbs-battery " Doug Anderson
[not found] ` <1360957573-864-1-git-send-email-dianders@chromium.org>
2013-02-15 19:46 ` [PATCH v3 2/3] ARM: dts: Add i2c-arbitrator bus " Doug Anderson
2013-03-05 23:48 ` Naveen Krishna Ch
2013-03-13 7:30 ` Kukjin Kim
2013-03-13 15:14 ` Doug Anderson
2013-02-15 19:46 ` [PATCH v3 3/3] ARM: dts: Add sbs-battery " Doug Anderson
2013-03-05 23:49 ` Naveen Krishna Ch
[not found] ` <1363192583-26363-1-git-send-email-dianders@chromium.org>
2013-03-13 16:36 ` [PATCH v4 2/3] ARM: dts: Add i2c-arbitrator bus " Doug Anderson
2013-03-13 16:36 ` [PATCH v4 3/3] ARM: dts: Add sbs-battery " Doug Anderson
[not found] ` <1365538361-2763-1-git-send-email-dianders@chromium.org>
2013-04-09 20:12 ` [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus " Doug Anderson
2013-04-09 20:12 ` [PATCH v5 3/3] ARM: dts: Add sbs-battery " Doug Anderson
[not found] ` <1365543270-10736-1-git-send-email-dianders@chromium.org>
2013-04-09 21:34 ` [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus " Doug Anderson
2013-04-10 10:59 ` Kukjin Kim
2013-04-10 11:02 ` Wolfram Sang
2013-04-10 14:12 ` Kukjin Kim
2013-04-09 21:34 ` [PATCH v5 3/3] ARM: dts: Add sbs-battery " Doug Anderson
[not found] ` <1366129742-16048-1-git-send-email-dianders@chromium.org>
2013-04-16 16:29 ` [PATCH v6 2/3] ARM: dts: Add i2c-arbitrator bus " Doug Anderson
2013-04-16 16:35 ` Olof Johansson
2013-04-16 16:29 ` [PATCH v6 3/3] ARM: dts: Add sbs-battery " Doug Anderson
2013-04-16 16:36 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).