linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: aspeed: Rename flash-controller nodes
@ 2019-04-05  3:32 Joel Stanley
  2019-04-05  5:51 ` Cédric Le Goater
  2019-04-08  0:38 ` Andrew Jeffery
  0 siblings, 2 replies; 3+ messages in thread
From: Joel Stanley @ 2019-04-05  3:32 UTC (permalink / raw)
  To: Rob Herring
  Cc: Andrew Jeffery, linux-aspeed, Cédric Le Goater, linux-arm-kernel

The device tree compiler has started spitting out warnings about these
names, insisting they be called 'spi':

 ../arch/arm/boot/dts/aspeed-g5.dtsi:108.35-128.5: Warning
 (spi_bus_bridge): /ahb/flash-controller@1e631000: node name for SPI
 buses should be 'spi'

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 arch/arm/boot/dts/aspeed-g4.dtsi | 4 ++--
 arch/arm/boot/dts/aspeed-g5.dtsi | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
index 9549f867aa1e..5156afccc8ed 100644
--- a/arch/arm/boot/dts/aspeed-g4.dtsi
+++ b/arch/arm/boot/dts/aspeed-g4.dtsi
@@ -53,7 +53,7 @@
 		#size-cells = <1>;
 		ranges;
 
-		fmc: flash-controller@1e620000 {
+		fmc: spi@1e620000 {
 			reg = < 0x1e620000 0x94
 				0x20000000 0x10000000 >;
 			#address-cells = <1>;
@@ -69,7 +69,7 @@
 			};
 		};
 
-		spi: flash-controller@1e630000 {
+		spi: spi@1e630000 {
 			reg = < 0x1e630000 0x18
 				0x30000000 0x10000000 >;
 			#address-cells = <1>;
diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index 85ed9dbec196..551528ccb7b8 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -60,7 +60,7 @@
 		#size-cells = <1>;
 		ranges;
 
-		fmc: flash-controller@1e620000 {
+		fmc: spi@1e620000 {
 			reg = < 0x1e620000 0xc4
 				0x20000000 0x10000000 >;
 			#address-cells = <1>;
@@ -86,7 +86,7 @@
 			};
 		};
 
-		spi1: flash-controller@1e630000 {
+		spi1: spi@1e630000 {
 			reg = < 0x1e630000 0xc4
 				0x30000000 0x08000000 >;
 			#address-cells = <1>;
@@ -106,7 +106,7 @@
 			};
 		};
 
-		spi2: flash-controller@1e631000 {
+		spi2: spi@1e631000 {
 			reg = < 0x1e631000 0xc4
 				0x38000000 0x08000000 >;
 			#address-cells = <1>;
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: aspeed: Rename flash-controller nodes
  2019-04-05  3:32 [PATCH] ARM: dts: aspeed: Rename flash-controller nodes Joel Stanley
@ 2019-04-05  5:51 ` Cédric Le Goater
  2019-04-08  0:38 ` Andrew Jeffery
  1 sibling, 0 replies; 3+ messages in thread
From: Cédric Le Goater @ 2019-04-05  5:51 UTC (permalink / raw)
  To: Joel Stanley, Rob Herring; +Cc: Andrew Jeffery, linux-aspeed, linux-arm-kernel

On 4/5/19 5:32 AM, Joel Stanley wrote:
> The device tree compiler has started spitting out warnings about these
> names, insisting they be called 'spi':
> 
>  ../arch/arm/boot/dts/aspeed-g5.dtsi:108.35-128.5: Warning
>  (spi_bus_bridge): /ahb/flash-controller@1e631000: node name for SPI
>  buses should be 'spi'
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>



Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.

> ---
>  arch/arm/boot/dts/aspeed-g4.dtsi | 4 ++--
>  arch/arm/boot/dts/aspeed-g5.dtsi | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> index 9549f867aa1e..5156afccc8ed 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -53,7 +53,7 @@
>  		#size-cells = <1>;
>  		ranges;
>  
> -		fmc: flash-controller@1e620000 {
> +		fmc: spi@1e620000 {
>  			reg = < 0x1e620000 0x94
>  				0x20000000 0x10000000 >;
>  			#address-cells = <1>;
> @@ -69,7 +69,7 @@
>  			};
>  		};
>  
> -		spi: flash-controller@1e630000 {
> +		spi: spi@1e630000 {
>  			reg = < 0x1e630000 0x18
>  				0x30000000 0x10000000 >;
>  			#address-cells = <1>;
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 85ed9dbec196..551528ccb7b8 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -60,7 +60,7 @@
>  		#size-cells = <1>;
>  		ranges;
>  
> -		fmc: flash-controller@1e620000 {
> +		fmc: spi@1e620000 {
>  			reg = < 0x1e620000 0xc4
>  				0x20000000 0x10000000 >;
>  			#address-cells = <1>;
> @@ -86,7 +86,7 @@
>  			};
>  		};
>  
> -		spi1: flash-controller@1e630000 {
> +		spi1: spi@1e630000 {
>  			reg = < 0x1e630000 0xc4
>  				0x30000000 0x08000000 >;
>  			#address-cells = <1>;
> @@ -106,7 +106,7 @@
>  			};
>  		};
>  
> -		spi2: flash-controller@1e631000 {
> +		spi2: spi@1e631000 {
>  			reg = < 0x1e631000 0xc4
>  				0x38000000 0x08000000 >;
>  			#address-cells = <1>;
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: aspeed: Rename flash-controller nodes
  2019-04-05  3:32 [PATCH] ARM: dts: aspeed: Rename flash-controller nodes Joel Stanley
  2019-04-05  5:51 ` Cédric Le Goater
@ 2019-04-08  0:38 ` Andrew Jeffery
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Jeffery @ 2019-04-08  0:38 UTC (permalink / raw)
  To: Joel Stanley, Rob Herring
  Cc: linux-aspeed, Cédric Le Goater, linux-arm-kernel



On Fri, 5 Apr 2019, at 14:02, Joel Stanley wrote:
> The device tree compiler has started spitting out warnings about these
> names, insisting they be called 'spi':
> 
>  ../arch/arm/boot/dts/aspeed-g5.dtsi:108.35-128.5: Warning
>  (spi_bus_bridge): /ahb/flash-controller@1e631000: node name for SPI
>  buses should be 'spi'
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>

> ---
>  arch/arm/boot/dts/aspeed-g4.dtsi | 4 ++--
>  arch/arm/boot/dts/aspeed-g5.dtsi | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> index 9549f867aa1e..5156afccc8ed 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -53,7 +53,7 @@
>  		#size-cells = <1>;
>  		ranges;
>  
> -		fmc: flash-controller@1e620000 {
> +		fmc: spi@1e620000 {
>  			reg = < 0x1e620000 0x94
>  				0x20000000 0x10000000 >;
>  			#address-cells = <1>;
> @@ -69,7 +69,7 @@
>  			};
>  		};
>  
> -		spi: flash-controller@1e630000 {
> +		spi: spi@1e630000 {
>  			reg = < 0x1e630000 0x18
>  				0x30000000 0x10000000 >;
>  			#address-cells = <1>;
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 85ed9dbec196..551528ccb7b8 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -60,7 +60,7 @@
>  		#size-cells = <1>;
>  		ranges;
>  
> -		fmc: flash-controller@1e620000 {
> +		fmc: spi@1e620000 {
>  			reg = < 0x1e620000 0xc4
>  				0x20000000 0x10000000 >;
>  			#address-cells = <1>;
> @@ -86,7 +86,7 @@
>  			};
>  		};
>  
> -		spi1: flash-controller@1e630000 {
> +		spi1: spi@1e630000 {
>  			reg = < 0x1e630000 0xc4
>  				0x30000000 0x08000000 >;
>  			#address-cells = <1>;
> @@ -106,7 +106,7 @@
>  			};
>  		};
>  
> -		spi2: flash-controller@1e631000 {
> +		spi2: spi@1e631000 {
>  			reg = < 0x1e631000 0xc4
>  				0x38000000 0x08000000 >;
>  			#address-cells = <1>;
> -- 
> 2.20.1
> 
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-08  0:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-05  3:32 [PATCH] ARM: dts: aspeed: Rename flash-controller nodes Joel Stanley
2019-04-05  5:51 ` Cédric Le Goater
2019-04-08  0:38 ` Andrew Jeffery

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).