* [PATCH] irqchip/gic-v3-its: Avoid parsing _indirect_ twice for Device table
@ 2019-02-10 5:24 Zenghui Yu
2019-02-12 13:17 ` Zenghui Yu
2019-02-14 10:46 ` Marc Zyngier
0 siblings, 2 replies; 4+ messages in thread
From: Zenghui Yu @ 2019-02-10 5:24 UTC (permalink / raw)
To: tglx, jason, marc.zyngier
Cc: Zenghui Yu, wanghaibin.wang, linux-arm-kernel, shankerd, linux-kernel
In current logic, its_parse_indirect_baser() will be invoked twice
when allocating Device tables. Add a *break* to omit the unnecessary
and annoying (might be ...) invoking.
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
drivers/irqchip/irq-gic-v3-its.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index db20e99..9f529a6 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -1946,6 +1946,8 @@ static int its_alloc_tables(struct its_node *its)
indirect = its_parse_indirect_baser(its, baser,
psz, &order,
its->device_ids);
+ break;
+
case GITS_BASER_TYPE_VCPU:
indirect = its_parse_indirect_baser(its, baser,
psz, &order,
--
1.8.3.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] irqchip/gic-v3-its: Avoid parsing _indirect_ twice for Device table
2019-02-10 5:24 [PATCH] irqchip/gic-v3-its: Avoid parsing _indirect_ twice for Device table Zenghui Yu
@ 2019-02-12 13:17 ` Zenghui Yu
2019-02-14 10:46 ` Marc Zyngier
1 sibling, 0 replies; 4+ messages in thread
From: Zenghui Yu @ 2019-02-12 13:17 UTC (permalink / raw)
To: marc.zyngier
Cc: jason, linux-kernel, shankerd, wanghaibin.wang, tglx, linux-arm-kernel
Hi Marc,
On 2019/2/10 13:24, Zenghui Yu wrote:
> In current logic, its_parse_indirect_baser() will be invoked twice
> when allocating Device tables. Add a *break* to omit the unnecessary
> and annoying (might be ...) invoking.
>
Forgot to add:
Fixes: 32bd44dc19de ("irqchip/gic-v3-its: Fix the incorrect parsing of
VCPU table size")
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> drivers/irqchip/irq-gic-v3-its.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> index db20e99..9f529a6 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -1946,6 +1946,8 @@ static int its_alloc_tables(struct its_node *its)
> indirect = its_parse_indirect_baser(its, baser,
> psz, &order,
> its->device_ids);
> + break;
> +
> case GITS_BASER_TYPE_VCPU:
> indirect = its_parse_indirect_baser(its, baser,
> psz, &order,
>
Thanks,
Zenghui
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] irqchip/gic-v3-its: Avoid parsing _indirect_ twice for Device table
2019-02-10 5:24 [PATCH] irqchip/gic-v3-its: Avoid parsing _indirect_ twice for Device table Zenghui Yu
2019-02-12 13:17 ` Zenghui Yu
@ 2019-02-14 10:46 ` Marc Zyngier
2019-02-14 11:35 ` Zenghui Yu
1 sibling, 1 reply; 4+ messages in thread
From: Marc Zyngier @ 2019-02-14 10:46 UTC (permalink / raw)
To: Zenghui Yu
Cc: jason, linux-kernel, shankerd, wanghaibin.wang, tglx, linux-arm-kernel
On Sun, 10 Feb 2019 05:24:10 +0000,
Zenghui Yu <yuzenghui@huawei.com> wrote:
>
> In current logic, its_parse_indirect_baser() will be invoked twice
> when allocating Device tables. Add a *break* to omit the unnecessary
> and annoying (might be ...) invoking.
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> drivers/irqchip/irq-gic-v3-its.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> index db20e99..9f529a6 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -1946,6 +1946,8 @@ static int its_alloc_tables(struct its_node *its)
> indirect = its_parse_indirect_baser(its, baser,
> psz, &order,
> its->device_ids);
> + break;
> +
> case GITS_BASER_TYPE_VCPU:
> indirect = its_parse_indirect_baser(its, baser,
> psz, &order,
Nice catch. I've applied this to irqchip-next with the Fixes tag and a
Cc stable.
Thanks,
M.
--
Jazz is not dead, it just smell funny.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] irqchip/gic-v3-its: Avoid parsing _indirect_ twice for Device table
2019-02-14 10:46 ` Marc Zyngier
@ 2019-02-14 11:35 ` Zenghui Yu
0 siblings, 0 replies; 4+ messages in thread
From: Zenghui Yu @ 2019-02-14 11:35 UTC (permalink / raw)
To: Marc Zyngier
Cc: jason, linux-kernel, shankerd, wanghaibin.wang, tglx, linux-arm-kernel
Hi Marc,
On 2019/2/14 18:46, Marc Zyngier wrote:
> On Sun, 10 Feb 2019 05:24:10 +0000,
> Zenghui Yu <yuzenghui@huawei.com> wrote:
>>
>> In current logic, its_parse_indirect_baser() will be invoked twice
>> when allocating Device tables. Add a *break* to omit the unnecessary
>> and annoying (might be ...) invoking.
>>
>> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
>> ---
>> drivers/irqchip/irq-gic-v3-its.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
>> index db20e99..9f529a6 100644
>> --- a/drivers/irqchip/irq-gic-v3-its.c
>> +++ b/drivers/irqchip/irq-gic-v3-its.c
>> @@ -1946,6 +1946,8 @@ static int its_alloc_tables(struct its_node *its)
>> indirect = its_parse_indirect_baser(its, baser,
>> psz, &order,
>> its->device_ids);
>> + break;
>> +
>> case GITS_BASER_TYPE_VCPU:
>> indirect = its_parse_indirect_baser(its, baser,
>> psz, &order,
>
> Nice catch. I've applied this to irqchip-next with the Fixes tag and a
> Cc stable.
>
Thanks for picking it up!
Zenghui
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-14 11:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-10 5:24 [PATCH] irqchip/gic-v3-its: Avoid parsing _indirect_ twice for Device table Zenghui Yu
2019-02-12 13:17 ` Zenghui Yu
2019-02-14 10:46 ` Marc Zyngier
2019-02-14 11:35 ` Zenghui Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).