* [PATCH v2 0/3] Necessary i.MX8MQ clock updates in order to support cpufreq
@ 2019-02-15 17:48 Abel Vesa
2019-02-15 17:48 ` [PATCH v2 1/3] clk: imx: imx8mq: Fix the rate propagation for arm pll Abel Vesa
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Abel Vesa @ 2019-02-15 17:48 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd, Shawn Guo, Sascha Hauer,
Lucas Stach, Angus Ainslie, Rob Herring
Cc: Abel Vesa, Anson Huang, Linux Kernel Mailing List, dl-linux-imx,
linux-clk, linux-arm-kernel
This is basically the v2 for the proposed clock changes in the
following RFC:
https://lkml.org/lkml/2019/2/13/1111
No changes here (other than adding the Reviewed-by tags).
Just a resent as a separate patchset.
Abel Vesa (3):
clk: imx: imx8mq: Fix the rate propagation for arm pll
dt-bindings: imx8mq-clock: Add the missing ARM clock
clk: imx8mq: Add the missing ARM clock
drivers/clk/imx/clk-imx8mq.c | 8 +++++++-
include/dt-bindings/clock/imx8mq-clock.h | 4 +++-
2 files changed, 10 insertions(+), 2 deletions(-)
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/3] clk: imx: imx8mq: Fix the rate propagation for arm pll
2019-02-15 17:48 [PATCH v2 0/3] Necessary i.MX8MQ clock updates in order to support cpufreq Abel Vesa
@ 2019-02-15 17:48 ` Abel Vesa
2019-02-21 20:44 ` Stephen Boyd
2019-02-15 17:48 ` [PATCH v2 2/3] dt-bindings: imx8mq-clock: Add the missing ARM clock Abel Vesa
2019-02-15 17:48 ` [PATCH v2 3/3] clk: imx8mq: " Abel Vesa
2 siblings, 1 reply; 7+ messages in thread
From: Abel Vesa @ 2019-02-15 17:48 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd, Shawn Guo, Sascha Hauer,
Lucas Stach, Angus Ainslie, Rob Herring
Cc: Abel Vesa, Anson Huang, Linux Kernel Mailing List, dl-linux-imx,
linux-clk, linux-arm-kernel
The arm pll bypass needs to propagate the rate upwards
in order for the cpufreq to work.
Fixes: b80522040cd3f ("clk: imx: Add clock driver for i.MX8MQ CCM")
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
---
drivers/clk/imx/clk-imx8mq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c
index 398ab0b..57499ed 100644
--- a/drivers/clk/imx/clk-imx8mq.c
+++ b/drivers/clk/imx/clk-imx8mq.c
@@ -340,7 +340,7 @@ static int imx8mq_clocks_probe(struct platform_device *pdev)
clks[IMX8MQ_DRAM_PLL2_DIV] = imx_clk_divider("dram_pll2_div", "dram_pll2", base + 0x68, 1, 6);
/* PLL bypass out */
- clks[IMX8MQ_ARM_PLL_BYPASS] = imx_clk_mux("arm_pll_bypass", base + 0x28, 14, 1, arm_pll_bypass_sels, ARRAY_SIZE(arm_pll_bypass_sels));
+ clks[IMX8MQ_ARM_PLL_BYPASS] = imx_clk_mux_flags("arm_pll_bypass", base + 0x28, 14, 1, arm_pll_bypass_sels, ARRAY_SIZE(arm_pll_bypass_sels), CLK_SET_RATE_PARENT);
clks[IMX8MQ_GPU_PLL_BYPASS] = imx_clk_mux("gpu_pll_bypass", base + 0x18, 14, 1, gpu_pll_bypass_sels, ARRAY_SIZE(gpu_pll_bypass_sels));
clks[IMX8MQ_VPU_PLL_BYPASS] = imx_clk_mux("vpu_pll_bypass", base + 0x20, 14, 1, vpu_pll_bypass_sels, ARRAY_SIZE(vpu_pll_bypass_sels));
clks[IMX8MQ_AUDIO_PLL1_BYPASS] = imx_clk_mux("audio_pll1_bypass", base + 0x0, 14, 1, audio_pll1_bypass_sels, ARRAY_SIZE(audio_pll1_bypass_sels));
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/3] dt-bindings: imx8mq-clock: Add the missing ARM clock
2019-02-15 17:48 [PATCH v2 0/3] Necessary i.MX8MQ clock updates in order to support cpufreq Abel Vesa
2019-02-15 17:48 ` [PATCH v2 1/3] clk: imx: imx8mq: Fix the rate propagation for arm pll Abel Vesa
@ 2019-02-15 17:48 ` Abel Vesa
2019-02-21 20:40 ` Stephen Boyd
2019-02-15 17:48 ` [PATCH v2 3/3] clk: imx8mq: " Abel Vesa
2 siblings, 1 reply; 7+ messages in thread
From: Abel Vesa @ 2019-02-15 17:48 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd, Shawn Guo, Sascha Hauer,
Lucas Stach, Angus Ainslie, Rob Herring
Cc: Abel Vesa, Anson Huang, Linux Kernel Mailing List, dl-linux-imx,
linux-clk, linux-arm-kernel
Add the missing ARM clock which will be used by cpufreq
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
---
include/dt-bindings/clock/imx8mq-clock.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/dt-bindings/clock/imx8mq-clock.h b/include/dt-bindings/clock/imx8mq-clock.h
index 04f7ac3..47c790c 100644
--- a/include/dt-bindings/clock/imx8mq-clock.h
+++ b/include/dt-bindings/clock/imx8mq-clock.h
@@ -391,5 +391,7 @@
#define IMX8MQ_CLK_NAND_USDHC_BUS_RAWNAND_CLK 267
-#define IMX8MQ_CLK_END 268
+#define IMX8MQ_CLK_ARM 268
+
+#define IMX8MQ_CLK_END 269
#endif /* __DT_BINDINGS_CLOCK_IMX8MQ_H */
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 3/3] clk: imx8mq: Add the missing ARM clock
2019-02-15 17:48 [PATCH v2 0/3] Necessary i.MX8MQ clock updates in order to support cpufreq Abel Vesa
2019-02-15 17:48 ` [PATCH v2 1/3] clk: imx: imx8mq: Fix the rate propagation for arm pll Abel Vesa
2019-02-15 17:48 ` [PATCH v2 2/3] dt-bindings: imx8mq-clock: Add the missing ARM clock Abel Vesa
@ 2019-02-15 17:48 ` Abel Vesa
2019-02-21 20:44 ` Stephen Boyd
2 siblings, 1 reply; 7+ messages in thread
From: Abel Vesa @ 2019-02-15 17:48 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd, Shawn Guo, Sascha Hauer,
Lucas Stach, Angus Ainslie, Rob Herring
Cc: Abel Vesa, Anson Huang, Linux Kernel Mailing List, dl-linux-imx,
linux-clk, linux-arm-kernel
Add the ARM clock as imx_clk_cpu type.
Will be used by cpufreq.
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
---
drivers/clk/imx/clk-imx8mq.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c
index 57499ed..8a283cb 100644
--- a/drivers/clk/imx/clk-imx8mq.c
+++ b/drivers/clk/imx/clk-imx8mq.c
@@ -558,6 +558,12 @@ static int imx8mq_clocks_probe(struct platform_device *pdev)
clks[IMX8MQ_GPT_3M_CLK] = imx_clk_fixed_factor("gpt_3m", "osc_25m", 1, 8);
clks[IMX8MQ_CLK_DRAM_ALT_ROOT] = imx_clk_fixed_factor("dram_alt_root", "dram_alt", 1, 4);
+ clks[IMX8MQ_CLK_ARM] = imx_clk_cpu("arm", "arm_a53_div",
+ clks[IMX8MQ_CLK_A53_DIV],
+ clks[IMX8MQ_CLK_A53_SRC],
+ clks[IMX8MQ_ARM_PLL_OUT],
+ clks[IMX8MQ_SYS1_PLL_800M]);
+
for (i = 0; i < IMX8MQ_CLK_END; i++)
if (IS_ERR(clks[i]))
pr_err("i.MX8mq clk %u register failed with %ld\n",
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: imx8mq-clock: Add the missing ARM clock
2019-02-15 17:48 ` [PATCH v2 2/3] dt-bindings: imx8mq-clock: Add the missing ARM clock Abel Vesa
@ 2019-02-21 20:40 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2019-02-21 20:40 UTC (permalink / raw)
To: Abel Vesa, Angus Ainslie, Lucas Stach, Mike Turquette,
Rob Herring, Sascha Hauer, Shawn Guo
Cc: Abel Vesa, Anson Huang, Linux Kernel Mailing List, dl-linux-imx,
linux-clk, linux-arm-kernel
Quoting Abel Vesa (2019-02-15 09:48:45)
> Add the missing ARM clock which will be used by cpufreq
>
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> include/dt-bindings/clock/imx8mq-clock.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/imx8mq-clock.h b/include/dt-bindings/clock/imx8mq-clock.h
> index 04f7ac3..47c790c 100644
> --- a/include/dt-bindings/clock/imx8mq-clock.h
> +++ b/include/dt-bindings/clock/imx8mq-clock.h
> @@ -391,5 +391,7 @@
>
> #define IMX8MQ_CLK_NAND_USDHC_BUS_RAWNAND_CLK 267
>
> -#define IMX8MQ_CLK_END 268
> +#define IMX8MQ_CLK_ARM 268
> +
This conflicts with Fabio's patch. And also depends on rc6 material that
seems to have gone through a different tree than clk tree. I'm just
going to fix the numbering.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/3] clk: imx: imx8mq: Fix the rate propagation for arm pll
2019-02-15 17:48 ` [PATCH v2 1/3] clk: imx: imx8mq: Fix the rate propagation for arm pll Abel Vesa
@ 2019-02-21 20:44 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2019-02-21 20:44 UTC (permalink / raw)
To: Abel Vesa, Angus Ainslie, Lucas Stach, Mike Turquette,
Rob Herring, Sascha Hauer, Shawn Guo
Cc: Abel Vesa, Anson Huang, Linux Kernel Mailing List, dl-linux-imx,
linux-clk, linux-arm-kernel
Quoting Abel Vesa (2019-02-15 09:48:43)
> The arm pll bypass needs to propagate the rate upwards
> in order for the cpufreq to work.
>
> Fixes: b80522040cd3f ("clk: imx: Add clock driver for i.MX8MQ CCM")
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
Applied to clk-next
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 3/3] clk: imx8mq: Add the missing ARM clock
2019-02-15 17:48 ` [PATCH v2 3/3] clk: imx8mq: " Abel Vesa
@ 2019-02-21 20:44 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2019-02-21 20:44 UTC (permalink / raw)
To: Abel Vesa, Angus Ainslie, Lucas Stach, Mike Turquette,
Rob Herring, Sascha Hauer, Shawn Guo
Cc: Abel Vesa, Anson Huang, Linux Kernel Mailing List, dl-linux-imx,
linux-clk, linux-arm-kernel
Quoting Abel Vesa (2019-02-15 09:48:46)
> Add the ARM clock as imx_clk_cpu type.
> Will be used by cpufreq.
>
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
Applied to clk-next
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-02-21 20:44 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-15 17:48 [PATCH v2 0/3] Necessary i.MX8MQ clock updates in order to support cpufreq Abel Vesa
2019-02-15 17:48 ` [PATCH v2 1/3] clk: imx: imx8mq: Fix the rate propagation for arm pll Abel Vesa
2019-02-21 20:44 ` Stephen Boyd
2019-02-15 17:48 ` [PATCH v2 2/3] dt-bindings: imx8mq-clock: Add the missing ARM clock Abel Vesa
2019-02-21 20:40 ` Stephen Boyd
2019-02-15 17:48 ` [PATCH v2 3/3] clk: imx8mq: " Abel Vesa
2019-02-21 20:44 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).