From: John Garry <john.garry@huawei.com>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
Will Deacon <will@kernel.org>
Cc: "liuqi (BA)" <liuqi115@huawei.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
Zhangshaokun <zhangshaokun@hisilicon.com>,
Linuxarm <linuxarm@huawei.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU
Date: Thu, 8 Apr 2021 13:55:02 +0100 [thread overview]
Message-ID: <16a7a3f8-82b5-a113-57c0-a9d575c649bd@huawei.com> (raw)
In-Reply-To: <20210408100157.000062f0@Huawei.com>
On 08/04/2021 10:01, Jonathan Cameron wrote:
> On Wed, 7 Apr 2021 21:40:05 +0100
> Will Deacon <will@kernel.org> wrote:
>
>> On Wed, Apr 07, 2021 at 05:49:02PM +0800, Qi Liu wrote:
>>> PCIe PMU Root Complex Integrated End Point(RCiEP) device is supported
>>> to sample bandwidth, latency, buffer occupation etc.
>>>
>>> Each PMU RCiEP device monitors multiple root ports, and each RCiEP is
>>> registered as a pmu in /sys/bus/event_source/devices, so users can
>>> select target PMU, and use filter to do further sets.
>>>
>>> Filtering options contains:
>>> event - select the event.
>>> subevent - select the subevent.
>>> port - select target root ports. Information of root ports
>>> are shown under sysfs.
>>> bdf - select requester_id of target EP device.
>>> trig_len - set trigger condition for starting event statistics.
>>> trigger_mode - set trigger mode. 0 means starting to statistic when
>>> bigger than trigger condition, and 1 means smaller.
>>> thr_len - set threshold for statistics.
>>> thr_mode - set threshold mode. 0 means count when bigger than
>>> threshold, and 1 means smaller.
>>>
>>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>>
>> Do you have a link to this review, please?
>
> Internal review, so drop the tag.
>
> Jonathan
Hi Will,
Are you implying that you would rather that any review for these drivers
is done in public on the lists?
Cheers,
John
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-08 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 9:49 [PATCH 0/2] drivers/perf: hisi: Add support for PCIe PMU Qi Liu
2021-04-07 9:49 ` [PATCH 1/2] drivers/perf: hisi: Add driver for HiSilicon " Qi Liu
2021-04-07 20:40 ` Will Deacon
2021-04-08 9:01 ` Jonathan Cameron
2021-04-08 12:55 ` John Garry [this message]
2021-04-08 13:28 ` Will Deacon
2021-04-07 9:49 ` [PATCH 2/2] docs: perf: Add description for HiSilicon PCIe PMU driver Qi Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16a7a3f8-82b5-a113-57c0-a9d575c649bd@huawei.com \
--to=john.garry@huawei.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuqi115@huawei.com \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).