* [PATCH] ARM: DT: imx53: fix lvds channel 1 port
@ 2014-09-04 16:43 Markus Niebel
2014-09-10 1:28 ` Shawn Guo
2014-09-11 7:44 ` Shawn Guo
0 siblings, 2 replies; 7+ messages in thread
From: Markus Niebel @ 2014-09-04 16:43 UTC (permalink / raw)
To: linux-arm-kernel
From: Markus Niebel <Markus.Niebel@tq-group.com>
using LVDS channel 1 on an i.MX53 leads to following error:
imx-ldb 53fa8008.ldb: unable to set di0 parent clock to ldb_di1
This comes from imx_ldb_set_clock with mux = 0. Mux parameter must be "1" for
reparenting di1 clock to ldb_di1. The value of the mux param comes from device
tree port settings.
On i.MX5, the internal two-input-multiplexer is used. Due to hardware limitations,
only one port (port@[0,1]) can be used for each channel (lvds-channel@[0,1],
respectively)
Documentation update suggested by Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
---
Documentation/devicetree/bindings/staging/imx-drm/ldb.txt | 15 +++++++++++++--
arch/arm/boot/dts/imx53.dtsi | 12 ++++++++++--
2 files changed, 23 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt b/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt
index 578a1fc..443bcb6 100644
--- a/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt
+++ b/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt
@@ -56,6 +56,9 @@ Required properties:
- fsl,data-width : should be <18> or <24>
- port: A port node with endpoint definitions as defined in
Documentation/devicetree/bindings/media/video-interfaces.txt.
+ On i.MX5, the internal two-input-multiplexer is used.
+ Due to hardware limitations, only one port (port@[0,1])
+ can be used for each channel (lvds-channel@[0,1], respectively)
On i.MX6, there should be four ports (port@[0-3]) that correspond
to the four LVDS multiplexer inputs.
@@ -78,6 +81,8 @@ ldb: ldb at 53fa8008 {
"di0", "di1";
lvds-channel at 0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
fsl,data-mapping = "spwg";
fsl,data-width = <24>;
@@ -86,7 +91,9 @@ ldb: ldb at 53fa8008 {
/* ... */
};
- port {
+ port at 0 {
+ reg = <0>;
+
lvds0_in: endpoint {
remote-endpoint = <&ipu_di0_lvds0>;
};
@@ -94,6 +101,8 @@ ldb: ldb at 53fa8008 {
};
lvds-channel at 1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
fsl,data-mapping = "spwg";
fsl,data-width = <24>;
@@ -102,7 +111,9 @@ ldb: ldb at 53fa8008 {
/* ... */
};
- port {
+ port at 1 {
+ reg = <1>;
+
lvds1_in: endpoint {
remote-endpoint = <&ipu_di1_lvds1>;
};
diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
index 6456a00..1a2202d 100644
--- a/arch/arm/boot/dts/imx53.dtsi
+++ b/arch/arm/boot/dts/imx53.dtsi
@@ -419,10 +419,14 @@
status = "disabled";
lvds-channel at 0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
status = "disabled";
- port {
+ port at 0 {
+ reg = <0>;
+
lvds0_in: endpoint {
remote-endpoint = <&ipu_di0_lvds0>;
};
@@ -430,10 +434,14 @@
};
lvds-channel at 1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
status = "disabled";
- port {
+ port at 1 {
+ reg = <1>;
+
lvds1_in: endpoint {
remote-endpoint = <&ipu_di1_lvds1>;
};
--
2.1.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] ARM: DT: imx53: fix lvds channel 1 port
2014-09-04 16:43 [PATCH] ARM: DT: imx53: fix lvds channel 1 port Markus Niebel
@ 2014-09-10 1:28 ` Shawn Guo
2014-09-10 13:15 ` Philipp Zabel
2014-09-11 7:44 ` Shawn Guo
1 sibling, 1 reply; 7+ messages in thread
From: Shawn Guo @ 2014-09-10 1:28 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 04, 2014 at 06:43:05PM +0200, Markus Niebel wrote:
> From: Markus Niebel <Markus.Niebel@tq-group.com>
>
> using LVDS channel 1 on an i.MX53 leads to following error:
>
> imx-ldb 53fa8008.ldb: unable to set di0 parent clock to ldb_di1
>
> This comes from imx_ldb_set_clock with mux = 0. Mux parameter must be "1" for
> reparenting di1 clock to ldb_di1. The value of the mux param comes from device
> tree port settings.
>
> On i.MX5, the internal two-input-multiplexer is used. Due to hardware limitations,
> only one port (port@[0,1]) can be used for each channel (lvds-channel@[0,1],
> respectively)
>
> Documentation update suggested by Philipp Zabel <p.zabel@pengutronix.de>
>
> Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
Philipp,
Does the patch look good to you? I feel more comfortable to send it as
a fix and stable material only with your ACK at this stage.
Shawn
> ---
> Documentation/devicetree/bindings/staging/imx-drm/ldb.txt | 15 +++++++++++++--
> arch/arm/boot/dts/imx53.dtsi | 12 ++++++++++--
> 2 files changed, 23 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt b/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt
> index 578a1fc..443bcb6 100644
> --- a/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt
> +++ b/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt
> @@ -56,6 +56,9 @@ Required properties:
> - fsl,data-width : should be <18> or <24>
> - port: A port node with endpoint definitions as defined in
> Documentation/devicetree/bindings/media/video-interfaces.txt.
> + On i.MX5, the internal two-input-multiplexer is used.
> + Due to hardware limitations, only one port (port@[0,1])
> + can be used for each channel (lvds-channel@[0,1], respectively)
> On i.MX6, there should be four ports (port@[0-3]) that correspond
> to the four LVDS multiplexer inputs.
>
> @@ -78,6 +81,8 @@ ldb: ldb at 53fa8008 {
> "di0", "di1";
>
> lvds-channel at 0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> reg = <0>;
> fsl,data-mapping = "spwg";
> fsl,data-width = <24>;
> @@ -86,7 +91,9 @@ ldb: ldb at 53fa8008 {
> /* ... */
> };
>
> - port {
> + port at 0 {
> + reg = <0>;
> +
> lvds0_in: endpoint {
> remote-endpoint = <&ipu_di0_lvds0>;
> };
> @@ -94,6 +101,8 @@ ldb: ldb at 53fa8008 {
> };
>
> lvds-channel at 1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> reg = <1>;
> fsl,data-mapping = "spwg";
> fsl,data-width = <24>;
> @@ -102,7 +111,9 @@ ldb: ldb at 53fa8008 {
> /* ... */
> };
>
> - port {
> + port at 1 {
> + reg = <1>;
> +
> lvds1_in: endpoint {
> remote-endpoint = <&ipu_di1_lvds1>;
> };
> diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> index 6456a00..1a2202d 100644
> --- a/arch/arm/boot/dts/imx53.dtsi
> +++ b/arch/arm/boot/dts/imx53.dtsi
> @@ -419,10 +419,14 @@
> status = "disabled";
>
> lvds-channel at 0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> reg = <0>;
> status = "disabled";
>
> - port {
> + port at 0 {
> + reg = <0>;
> +
> lvds0_in: endpoint {
> remote-endpoint = <&ipu_di0_lvds0>;
> };
> @@ -430,10 +434,14 @@
> };
>
> lvds-channel at 1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> reg = <1>;
> status = "disabled";
>
> - port {
> + port at 1 {
> + reg = <1>;
> +
> lvds1_in: endpoint {
> remote-endpoint = <&ipu_di1_lvds1>;
> };
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: DT: imx53: fix lvds channel 1 port
2014-09-10 1:28 ` Shawn Guo
@ 2014-09-10 13:15 ` Philipp Zabel
0 siblings, 0 replies; 7+ messages in thread
From: Philipp Zabel @ 2014-09-10 13:15 UTC (permalink / raw)
To: linux-arm-kernel
Hi Shawn,
Am Mittwoch, den 10.09.2014, 09:28 +0800 schrieb Shawn Guo:
> On Thu, Sep 04, 2014 at 06:43:05PM +0200, Markus Niebel wrote:
> > From: Markus Niebel <Markus.Niebel@tq-group.com>
> >
> > using LVDS channel 1 on an i.MX53 leads to following error:
> >
> > imx-ldb 53fa8008.ldb: unable to set di0 parent clock to ldb_di1
> >
> > This comes from imx_ldb_set_clock with mux = 0. Mux parameter must be "1" for
> > reparenting di1 clock to ldb_di1. The value of the mux param comes from device
> > tree port settings.
> >
> > On i.MX5, the internal two-input-multiplexer is used. Due to hardware limitations,
> > only one port (port@[0,1]) can be used for each channel (lvds-channel@[0,1],
> > respectively)
> >
> > Documentation update suggested by Philipp Zabel <p.zabel@pengutronix.de>
> >
> > Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
>
> Philipp,
>
> Does the patch look good to you? I feel more comfortable to send it as
> a fix and stable material only with your ACK at this stage.
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: DT: imx53: fix lvds channel 1 port
2014-09-04 16:43 [PATCH] ARM: DT: imx53: fix lvds channel 1 port Markus Niebel
2014-09-10 1:28 ` Shawn Guo
@ 2014-09-11 7:44 ` Shawn Guo
1 sibling, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2014-09-11 7:44 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 04, 2014 at 06:43:05PM +0200, Markus Niebel wrote:
> From: Markus Niebel <Markus.Niebel@tq-group.com>
>
> using LVDS channel 1 on an i.MX53 leads to following error:
>
> imx-ldb 53fa8008.ldb: unable to set di0 parent clock to ldb_di1
>
> This comes from imx_ldb_set_clock with mux = 0. Mux parameter must be "1" for
> reparenting di1 clock to ldb_di1. The value of the mux param comes from device
> tree port settings.
>
> On i.MX5, the internal two-input-multiplexer is used. Due to hardware limitations,
> only one port (port@[0,1]) can be used for each channel (lvds-channel@[0,1],
> respectively)
>
> Documentation update suggested by Philipp Zabel <p.zabel@pengutronix.de>
>
> Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: DT: imx53: fix lvds channel 1 port
2014-09-11 7:56 Shawn Guo
@ 2014-09-11 9:36 ` Arnd Bergmann
0 siblings, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2014-09-11 9:36 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 11 September 2014 15:56:56 Shawn Guo wrote:
> From: Markus Niebel <Markus.Niebel@tq-group.com>
>
> using LVDS channel 1 on an i.MX53 leads to following error:
>
> imx-ldb 53fa8008.ldb: unable to set di0 parent clock to ldb_di1
>
> This comes from imx_ldb_set_clock with mux = 0. Mux parameter must be "1" for
> reparenting di1 clock to ldb_di1. The value of the mux param comes from device
> tree port settings.
>
> On i.MX5, the internal two-input-multiplexer is used. Due to hardware limitations,
> only one port (port@[0,1]) can be used for each channel (lvds-channel@[0,1],
> respectively)
>
> Documentation update suggested by Philipp Zabel <p.zabel@pengutronix.de>
>
> Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
> Fixes: e05c8c9a790a ("ARM: dts: imx53: Add IPU DI ports and endpoints, move imx-drm node to dtsi")
> Cc: <stable@vger.kernel.org>
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
> ---
> Hi arm-soc folks,
>
> Please apply the fix for 3.17, thanks.
Applied to fixes branch, thanks!
Arnd
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: DT: imx53: fix lvds channel 1 port
@ 2014-09-11 7:56 Shawn Guo
2014-09-11 9:36 ` Arnd Bergmann
0 siblings, 1 reply; 7+ messages in thread
From: Shawn Guo @ 2014-09-11 7:56 UTC (permalink / raw)
To: linux-arm-kernel
From: Markus Niebel <Markus.Niebel@tq-group.com>
using LVDS channel 1 on an i.MX53 leads to following error:
imx-ldb 53fa8008.ldb: unable to set di0 parent clock to ldb_di1
This comes from imx_ldb_set_clock with mux = 0. Mux parameter must be "1" for
reparenting di1 clock to ldb_di1. The value of the mux param comes from device
tree port settings.
On i.MX5, the internal two-input-multiplexer is used. Due to hardware limitations,
only one port (port@[0,1]) can be used for each channel (lvds-channel@[0,1],
respectively)
Documentation update suggested by Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
Fixes: e05c8c9a790a ("ARM: dts: imx53: Add IPU DI ports and endpoints, move imx-drm node to dtsi")
Cc: <stable@vger.kernel.org>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
---
Hi arm-soc folks,
Please apply the fix for 3.17, thanks.
Shawn
Documentation/devicetree/bindings/staging/imx-drm/ldb.txt | 15 +++++++++++++--
arch/arm/boot/dts/imx53.dtsi | 12 ++++++++++--
2 files changed, 23 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt b/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt
index 578a1fca366e..443bcb6134d5 100644
--- a/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt
+++ b/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt
@@ -56,6 +56,9 @@ Required properties:
- fsl,data-width : should be <18> or <24>
- port: A port node with endpoint definitions as defined in
Documentation/devicetree/bindings/media/video-interfaces.txt.
+ On i.MX5, the internal two-input-multiplexer is used.
+ Due to hardware limitations, only one port (port@[0,1])
+ can be used for each channel (lvds-channel@[0,1], respectively)
On i.MX6, there should be four ports (port@[0-3]) that correspond
to the four LVDS multiplexer inputs.
@@ -78,6 +81,8 @@ ldb: ldb at 53fa8008 {
"di0", "di1";
lvds-channel at 0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
fsl,data-mapping = "spwg";
fsl,data-width = <24>;
@@ -86,7 +91,9 @@ ldb: ldb at 53fa8008 {
/* ... */
};
- port {
+ port at 0 {
+ reg = <0>;
+
lvds0_in: endpoint {
remote-endpoint = <&ipu_di0_lvds0>;
};
@@ -94,6 +101,8 @@ ldb: ldb at 53fa8008 {
};
lvds-channel at 1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
fsl,data-mapping = "spwg";
fsl,data-width = <24>;
@@ -102,7 +111,9 @@ ldb: ldb at 53fa8008 {
/* ... */
};
- port {
+ port at 1 {
+ reg = <1>;
+
lvds1_in: endpoint {
remote-endpoint = <&ipu_di1_lvds1>;
};
diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
index c6c58c1c00e3..6b675a02066f 100644
--- a/arch/arm/boot/dts/imx53.dtsi
+++ b/arch/arm/boot/dts/imx53.dtsi
@@ -423,10 +423,14 @@
status = "disabled";
lvds-channel at 0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
status = "disabled";
- port {
+ port at 0 {
+ reg = <0>;
+
lvds0_in: endpoint {
remote-endpoint = <&ipu_di0_lvds0>;
};
@@ -434,10 +438,14 @@
};
lvds-channel at 1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
status = "disabled";
- port {
+ port at 1 {
+ reg = <1>;
+
lvds1_in: endpoint {
remote-endpoint = <&ipu_di1_lvds1>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] ARM: DT: imx53: fix lvds channel 1 port
@ 2014-09-04 12:05 Markus Niebel
0 siblings, 0 replies; 7+ messages in thread
From: Markus Niebel @ 2014-09-04 12:05 UTC (permalink / raw)
To: linux-arm-kernel
using LVDS channel 1 on an i.MX53 leads to following error:
imx-ldb 53fa8008.ldb: unable to set di0 parent clock to ldb_di1
This comes from imx_ldb_set_clock with mux = 0. Mux parameter must be "1" for
reparenting di1 clock to ldb_di1. The value of the mux param comes from device
tree port settings.
On i.MX5, the internal two-input-multiplexer is used. Due to hardware limitations,
only one port (port@[0,1]) can be used for each channel (lvds-channel@[0,1],
respectively)
Documentation update suggested by Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
---
Documentation/devicetree/bindings/staging/imx-drm/ldb.txt | 15 +++++++++++++--
arch/arm/boot/dts/imx53.dtsi | 12 ++++++++++--
2 files changed, 23 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt b/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt
index 578a1fc..443bcb6 100644
--- a/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt
+++ b/Documentation/devicetree/bindings/staging/imx-drm/ldb.txt
@@ -56,6 +56,9 @@ Required properties:
- fsl,data-width : should be <18> or <24>
- port: A port node with endpoint definitions as defined in
Documentation/devicetree/bindings/media/video-interfaces.txt.
+ On i.MX5, the internal two-input-multiplexer is used.
+ Due to hardware limitations, only one port (port@[0,1])
+ can be used for each channel (lvds-channel@[0,1], respectively)
On i.MX6, there should be four ports (port@[0-3]) that correspond
to the four LVDS multiplexer inputs.
@@ -78,6 +81,8 @@ ldb: ldb at 53fa8008 {
"di0", "di1";
lvds-channel at 0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
fsl,data-mapping = "spwg";
fsl,data-width = <24>;
@@ -86,7 +91,9 @@ ldb: ldb at 53fa8008 {
/* ... */
};
- port {
+ port at 0 {
+ reg = <0>;
+
lvds0_in: endpoint {
remote-endpoint = <&ipu_di0_lvds0>;
};
@@ -94,6 +101,8 @@ ldb: ldb at 53fa8008 {
};
lvds-channel at 1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
fsl,data-mapping = "spwg";
fsl,data-width = <24>;
@@ -102,7 +111,9 @@ ldb: ldb at 53fa8008 {
/* ... */
};
- port {
+ port at 1 {
+ reg = <1>;
+
lvds1_in: endpoint {
remote-endpoint = <&ipu_di1_lvds1>;
};
diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
index 6456a00..1a2202d 100644
--- a/arch/arm/boot/dts/imx53.dtsi
+++ b/arch/arm/boot/dts/imx53.dtsi
@@ -419,10 +419,14 @@
status = "disabled";
lvds-channel at 0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
status = "disabled";
- port {
+ port at 0 {
+ reg = <0>;
+
lvds0_in: endpoint {
remote-endpoint = <&ipu_di0_lvds0>;
};
@@ -430,10 +434,14 @@
};
lvds-channel at 1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
status = "disabled";
- port {
+ port at 1 {
+ reg = <1>;
+
lvds1_in: endpoint {
remote-endpoint = <&ipu_di1_lvds1>;
};
--
2.1.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-09-11 9:36 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-04 16:43 [PATCH] ARM: DT: imx53: fix lvds channel 1 port Markus Niebel
2014-09-10 1:28 ` Shawn Guo
2014-09-10 13:15 ` Philipp Zabel
2014-09-11 7:44 ` Shawn Guo
-- strict thread matches above, loose matches on Subject: below --
2014-09-11 7:56 Shawn Guo
2014-09-11 9:36 ` Arnd Bergmann
2014-09-04 12:05 Markus Niebel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).