* [PATCH 1/2] i2c: cadence: Remove .owner field for driver
@ 2014-08-13 11:56 Michal Simek
2014-09-20 9:11 ` Wolfram Sang
0 siblings, 1 reply; 4+ messages in thread
From: Michal Simek @ 2014-08-13 11:56 UTC (permalink / raw)
To: linux-arm-kernel
There is no need to init .owner field.
Based on the patch from Peter Griffin <peter.griffin@linaro.org>
"mmc: remove .owner field for drivers using module_platform_driver"
This patch removes the superflous .owner field for drivers which
use the module_platform_driver API, as this is overriden in
platform_driver_register anyway."
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/i2c/busses/i2c-cadence.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
index 63f3f03ecc9b..04d0a7e449ef 100644
--- a/drivers/i2c/busses/i2c-cadence.c
+++ b/drivers/i2c/busses/i2c-cadence.c
@@ -890,7 +890,6 @@ MODULE_DEVICE_TABLE(of, cdns_i2c_of_match);
static struct platform_driver cdns_i2c_drv = {
.driver = {
.name = DRIVER_NAME,
- .owner = THIS_MODULE,
.of_match_table = cdns_i2c_of_match,
.pm = &cdns_i2c_dev_pm_ops,
},
--
1.8.2.3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140813/22b5fa4f/attachment.sig>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/2] i2c: cadence: Remove .owner field for driver
2014-08-13 11:56 [PATCH 1/2] i2c: cadence: Remove .owner field for driver Michal Simek
@ 2014-09-20 9:11 ` Wolfram Sang
2014-09-22 9:36 ` Michal Simek
0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2014-09-20 9:11 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Aug 13, 2014 at 01:56:51PM +0200, Michal Simek wrote:
> There is no need to init .owner field.
>
> Based on the patch from Peter Griffin <peter.griffin@linaro.org>
> "mmc: remove .owner field for drivers using module_platform_driver"
>
> This patch removes the superflous .owner field for drivers which
It says drivers, but does only one...
> use the module_platform_driver API, as this is overriden in
> platform_driver_register anyway."
... so: any interest in doing this for the whole subsystem? Basically
good catch, though.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/i2c/busses/i2c-cadence.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
> index 63f3f03ecc9b..04d0a7e449ef 100644
> --- a/drivers/i2c/busses/i2c-cadence.c
> +++ b/drivers/i2c/busses/i2c-cadence.c
> @@ -890,7 +890,6 @@ MODULE_DEVICE_TABLE(of, cdns_i2c_of_match);
> static struct platform_driver cdns_i2c_drv = {
> .driver = {
> .name = DRIVER_NAME,
> - .owner = THIS_MODULE,
> .of_match_table = cdns_i2c_of_match,
> .pm = &cdns_i2c_dev_pm_ops,
> },
> --
> 1.8.2.3
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140920/ec4cb1c1/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] i2c: cadence: Remove .owner field for driver
2014-09-20 9:11 ` Wolfram Sang
@ 2014-09-22 9:36 ` Michal Simek
2014-11-07 18:15 ` Wolfram Sang
0 siblings, 1 reply; 4+ messages in thread
From: Michal Simek @ 2014-09-22 9:36 UTC (permalink / raw)
To: linux-arm-kernel
On 09/20/2014 11:11 AM, Wolfram Sang wrote:
> On Wed, Aug 13, 2014 at 01:56:51PM +0200, Michal Simek wrote:
>> There is no need to init .owner field.
>>
>> Based on the patch from Peter Griffin <peter.griffin@linaro.org>
>> "mmc: remove .owner field for drivers using module_platform_driver"
^
this shouldn't be there.
>>
>> This patch removes the superflous .owner field for drivers which
>
> It says drivers, but does only one...
I have c&p this from Peter's description that's why there are just drivers.
>
>> use the module_platform_driver API, as this is overriden in
>> platform_driver_register anyway."
>
> ... so: any interest in doing this for the whole subsystem? Basically
> good catch, though.
Mark was also interested about doing this for spi. Doing this for the whole
kernel will be the best. coccinelle script
is good option I have never played with it.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140922/9088a705/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] i2c: cadence: Remove .owner field for driver
2014-09-22 9:36 ` Michal Simek
@ 2014-11-07 18:15 ` Wolfram Sang
0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2014-11-07 18:15 UTC (permalink / raw)
To: linux-arm-kernel
> oing this for the whole kernel will be the best. coccinelle script
> is good option I have never played with it.
Thanks, but superseded in favour of a generic solution
(https://lkml.org/lkml/2014/10/21/594).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141107/c163d349/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-07 18:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-13 11:56 [PATCH 1/2] i2c: cadence: Remove .owner field for driver Michal Simek
2014-09-20 9:11 ` Wolfram Sang
2014-09-22 9:36 ` Michal Simek
2014-11-07 18:15 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).