* [PATCH] dma: imx-sdma: fix another incorrect __init annotation
@ 2014-09-26 21:24 Arnd Bergmann
2014-09-28 16:00 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2014-09-26 21:24 UTC (permalink / raw)
To: linux-arm-kernel
In e34b731faa7d1 ("dma: imx-sdma: Remove spurious __init annotation on
sdma_probe()"), Mark found an extraneous __init label and fixed it.
However, he missed another one, because now we get this other warning:
WARNING: drivers/dma/imx-sdma.o(.text+0x3bb4): Section mismatch in reference from the function sdma_probe() to the function .init.text:sdma_get_firmware()
The function sdma_probe() references
the function __init sdma_get_firmware().
Same reasoning as the last time, the function may get called at
runtime, so it can't be __init.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 52ce1d21154c..88afc48c2ca7 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1334,7 +1334,7 @@ err_firmware:
release_firmware(fw);
}
-static int __init sdma_get_firmware(struct sdma_engine *sdma,
+static int sdma_get_firmware(struct sdma_engine *sdma,
const char *fw_name)
{
int ret;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] dma: imx-sdma: fix another incorrect __init annotation
2014-09-26 21:24 [PATCH] dma: imx-sdma: fix another incorrect __init annotation Arnd Bergmann
@ 2014-09-28 16:00 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2014-09-28 16:00 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 26, 2014 at 11:24:00PM +0200, Arnd Bergmann wrote:
> In e34b731faa7d1 ("dma: imx-sdma: Remove spurious __init annotation on
> sdma_probe()"), Mark found an extraneous __init label and fixed it.
>
> However, he missed another one, because now we get this other warning:
>
> WARNING: drivers/dma/imx-sdma.o(.text+0x3bb4): Section mismatch in reference from the function sdma_probe() to the function .init.text:sdma_get_firmware()
> The function sdma_probe() references
> the function __init sdma_get_firmware().
>
> Same reasoning as the last time, the function may get called at
> runtime, so it can't be __init.
>
Applied, thanks
--
~Vinod
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 52ce1d21154c..88afc48c2ca7 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1334,7 +1334,7 @@ err_firmware:
> release_firmware(fw);
> }
>
> -static int __init sdma_get_firmware(struct sdma_engine *sdma,
> +static int sdma_get_firmware(struct sdma_engine *sdma,
> const char *fw_name)
> {
> int ret;
>
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-28 16:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-26 21:24 [PATCH] dma: imx-sdma: fix another incorrect __init annotation Arnd Bergmann
2014-09-28 16:00 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).