* [PATCH 04/29] ncr5380: Remove unused macros
[not found] <20141002065628.256592712@telegraphics.com.au>
@ 2014-10-02 6:56 ` Finn Thain
2014-10-06 9:21 ` Hannes Reinecke
2014-10-02 6:56 ` [PATCH 08/29] ncr5380: Remove redundant AUTOSENSE macro Finn Thain
` (4 subsequent siblings)
5 siblings, 1 reply; 8+ messages in thread
From: Finn Thain @ 2014-10-02 6:56 UTC (permalink / raw)
To: linux-arm-kernel
An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-remove-unused-macros
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141002/52ba4ecb/attachment.ksh>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 08/29] ncr5380: Remove redundant AUTOSENSE macro
[not found] <20141002065628.256592712@telegraphics.com.au>
2014-10-02 6:56 ` [PATCH 04/29] ncr5380: Remove unused macros Finn Thain
@ 2014-10-02 6:56 ` Finn Thain
2014-10-02 6:56 ` [PATCH 12/29] ncr5380: Cleanup host info() methods Finn Thain
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Finn Thain @ 2014-10-02 6:56 UTC (permalink / raw)
To: linux-arm-kernel
An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-remove-AUTOSENSE-macro
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141002/6cff966e/attachment.ksh>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 12/29] ncr5380: Cleanup host info() methods
[not found] <20141002065628.256592712@telegraphics.com.au>
2014-10-02 6:56 ` [PATCH 04/29] ncr5380: Remove unused macros Finn Thain
2014-10-02 6:56 ` [PATCH 08/29] ncr5380: Remove redundant AUTOSENSE macro Finn Thain
@ 2014-10-02 6:56 ` Finn Thain
2014-10-03 8:32 ` Geert Uytterhoeven
2014-10-02 6:56 ` [PATCH 13/29] ncr5380: Move static PDMA spin counters to host data Finn Thain
` (2 subsequent siblings)
5 siblings, 1 reply; 8+ messages in thread
From: Finn Thain @ 2014-10-02 6:56 UTC (permalink / raw)
To: linux-arm-kernel
An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-info-methods
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141002/51209ff3/attachment.ksh>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 13/29] ncr5380: Move static PDMA spin counters to host data
[not found] <20141002065628.256592712@telegraphics.com.au>
` (2 preceding siblings ...)
2014-10-02 6:56 ` [PATCH 12/29] ncr5380: Cleanup host info() methods Finn Thain
@ 2014-10-02 6:56 ` Finn Thain
2014-10-02 6:56 ` [PATCH 15/29] ncr5380: Remove *_RELEASE macros Finn Thain
2014-10-02 6:56 ` [PATCH 16/29] ncr5380: Drop legacy scsi.h include Finn Thain
5 siblings, 0 replies; 8+ messages in thread
From: Finn Thain @ 2014-10-02 6:56 UTC (permalink / raw)
To: linux-arm-kernel
An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-move-pdma-spin-counters
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141002/b6a4c33e/attachment.ksh>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 15/29] ncr5380: Remove *_RELEASE macros
[not found] <20141002065628.256592712@telegraphics.com.au>
` (3 preceding siblings ...)
2014-10-02 6:56 ` [PATCH 13/29] ncr5380: Move static PDMA spin counters to host data Finn Thain
@ 2014-10-02 6:56 ` Finn Thain
2014-10-02 6:56 ` [PATCH 16/29] ncr5380: Drop legacy scsi.h include Finn Thain
5 siblings, 0 replies; 8+ messages in thread
From: Finn Thain @ 2014-10-02 6:56 UTC (permalink / raw)
To: linux-arm-kernel
An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-remove-RELEASE-macros
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141002/473c1b6a/attachment.ksh>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 16/29] ncr5380: Drop legacy scsi.h include
[not found] <20141002065628.256592712@telegraphics.com.au>
` (4 preceding siblings ...)
2014-10-02 6:56 ` [PATCH 15/29] ncr5380: Remove *_RELEASE macros Finn Thain
@ 2014-10-02 6:56 ` Finn Thain
5 siblings, 0 replies; 8+ messages in thread
From: Finn Thain @ 2014-10-02 6:56 UTC (permalink / raw)
To: linux-arm-kernel
An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-drop-legacy-scsi-h-include
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141002/af42c230/attachment.ksh>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 12/29] ncr5380: Cleanup host info() methods
2014-10-02 6:56 ` [PATCH 12/29] ncr5380: Cleanup host info() methods Finn Thain
@ 2014-10-03 8:32 ` Geert Uytterhoeven
0 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2014-10-03 8:32 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
> +static void prepare_info(struct Scsi_Host *instance)
> +{
> + struct NCR5380_hostdata *hostdata = shost_priv(instance);
> +
> + snprintf(hostdata->info, sizeof(hostdata->info),
[...]
> + "");
> + hostdata->info[sizeof(hostdata->info) - 1] = '\0';
snprintf() will make sure the string is zero-terminated, so doing this manually
is not needed.
This applies to all three occurrences.
> }
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 04/29] ncr5380: Remove unused macros
2014-10-02 6:56 ` [PATCH 04/29] ncr5380: Remove unused macros Finn Thain
@ 2014-10-06 9:21 ` Hannes Reinecke
0 siblings, 0 replies; 8+ messages in thread
From: Hannes Reinecke @ 2014-10-06 9:21 UTC (permalink / raw)
To: linux-arm-kernel
On 10/02/2014 08:56 AM, Finn Thain wrote:
> Some macros are never evaluated (i.e. FOO, USLEEP, SCSI2 and USE_WRAPPER; and
> in some drivers, NCR5380_intr and NCR5380_proc_info). DRIVER_SETUP serves no
> purpose anymore. Remove these macro definitions.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare at suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: J. Hawn, J. Guild, F. Imend?rffer, HRB 16746 (AG N?rnberg)
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-10-06 9:21 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20141002065628.256592712@telegraphics.com.au>
2014-10-02 6:56 ` [PATCH 04/29] ncr5380: Remove unused macros Finn Thain
2014-10-06 9:21 ` Hannes Reinecke
2014-10-02 6:56 ` [PATCH 08/29] ncr5380: Remove redundant AUTOSENSE macro Finn Thain
2014-10-02 6:56 ` [PATCH 12/29] ncr5380: Cleanup host info() methods Finn Thain
2014-10-03 8:32 ` Geert Uytterhoeven
2014-10-02 6:56 ` [PATCH 13/29] ncr5380: Move static PDMA spin counters to host data Finn Thain
2014-10-02 6:56 ` [PATCH 15/29] ncr5380: Remove *_RELEASE macros Finn Thain
2014-10-02 6:56 ` [PATCH 16/29] ncr5380: Drop legacy scsi.h include Finn Thain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).