* [PATCH] ARM: shmobile: Remove redundant cpu_disable implementation
@ 2015-02-14 0:41 Stephen Boyd
2015-02-14 9:58 ` Magnus Damm
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2015-02-14 0:41 UTC (permalink / raw)
To: linux-arm-kernel
By default only the non-boot CPUs can be hotplugged if the
smp_operations structure doesn't have the cpu_disable function
pointer set. r8a7779_cpu_disable() implements the same logic,
only non-boot CPUs can be hotplugged, so it's redundant to
override the default behavior.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
arch/arm/mach-shmobile/smp-r8a7779.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/arch/arm/mach-shmobile/smp-r8a7779.c b/arch/arm/mach-shmobile/smp-r8a7779.c
index 3f761f839043..b45206f93ddf 100644
--- a/arch/arm/mach-shmobile/smp-r8a7779.c
+++ b/arch/arm/mach-shmobile/smp-r8a7779.c
@@ -124,19 +124,12 @@ static int r8a7779_cpu_kill(unsigned int cpu)
return 0;
}
-
-static int r8a7779_cpu_disable(unsigned int cpu)
-{
- /* only CPU1->3 have power domains, do not allow hotplug of CPU0 */
- return cpu == 0 ? -EPERM : 0;
-}
#endif /* CONFIG_HOTPLUG_CPU */
struct smp_operations r8a7779_smp_ops __initdata = {
.smp_prepare_cpus = r8a7779_smp_prepare_cpus,
.smp_boot_secondary = r8a7779_boot_secondary,
#ifdef CONFIG_HOTPLUG_CPU
- .cpu_disable = r8a7779_cpu_disable,
.cpu_die = shmobile_smp_scu_cpu_die,
.cpu_kill = r8a7779_cpu_kill,
#endif
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: shmobile: Remove redundant cpu_disable implementation
2015-02-14 0:41 [PATCH] ARM: shmobile: Remove redundant cpu_disable implementation Stephen Boyd
@ 2015-02-14 9:58 ` Magnus Damm
2015-02-14 18:21 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Magnus Damm @ 2015-02-14 9:58 UTC (permalink / raw)
To: linux-arm-kernel
Hi Stephen,
On Sat, Feb 14, 2015 at 12:41 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> By default only the non-boot CPUs can be hotplugged if the
> smp_operations structure doesn't have the cpu_disable function
> pointer set. r8a7779_cpu_disable() implements the same logic,
> only non-boot CPUs can be hotplugged, so it's redundant to
> override the default behavior.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> arch/arm/mach-shmobile/smp-r8a7779.c | 7 -------
> 1 file changed, 7 deletions(-)
Thanks for breaking out this change. It looks good to me!
Acked-by: Magnus Damm <damm+renesas@opensource.se>
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: shmobile: Remove redundant cpu_disable implementation
2015-02-14 9:58 ` Magnus Damm
@ 2015-02-14 18:21 ` Simon Horman
0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2015-02-14 18:21 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Feb 14, 2015 at 09:58:42AM +0000, Magnus Damm wrote:
> Hi Stephen,
>
> On Sat, Feb 14, 2015 at 12:41 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > By default only the non-boot CPUs can be hotplugged if the
> > smp_operations structure doesn't have the cpu_disable function
> > pointer set. r8a7779_cpu_disable() implements the same logic,
> > only non-boot CPUs can be hotplugged, so it's redundant to
> > override the default behavior.
> >
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > ---
> > arch/arm/mach-shmobile/smp-r8a7779.c | 7 -------
> > 1 file changed, 7 deletions(-)
>
> Thanks for breaking out this change. It looks good to me!
>
> Acked-by: Magnus Damm <damm+renesas@opensource.se>
Thanks,
I have queued this up with the following slightly updated subject
'ARM: shmobile: r8a7779: Remove redundant cpu_disable implementation'
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-14 18:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-14 0:41 [PATCH] ARM: shmobile: Remove redundant cpu_disable implementation Stephen Boyd
2015-02-14 9:58 ` Magnus Damm
2015-02-14 18:21 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).