From: Mark Brown <broonie@kernel.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: linaro-kernel@lists.linaro.org,
kernel-build-reports@lists.linaro.org,
Russell King <linux@armlinux.org.uk>,
linux-next@vger.kernel.org,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Daniel Scheller <d.scheller@gmx.net>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: next-20181211 build: 1 failures 32 warnings (next-20181211)
Date: Wed, 12 Dec 2018 12:18:26 +0000 [thread overview]
Message-ID: <20181212121826.GC6920@sirena.org.uk> (raw)
In-Reply-To: <20181211221535.GA20165@flashbox>
[-- Attachment #1.1: Type: text/plain, Size: 958 bytes --]
On Tue, Dec 11, 2018 at 03:15:35PM -0700, Nathan Chancellor wrote:
> On Tue, Dec 11, 2018 at 10:06:20PM +0000, Mark Brown wrote:
> > in ddbridge-ci.c and some other media files. This is because
> > ddbridge.h includes asm/irq.h but that does not directly include headers
> > which define the above types and it appears some header changes have
> > removed an implicit inclusion of those. Moving the asm includes after
> > the linux ones in ddbridge.h fixes this though this appears to be
> > against the coding style for media.
> I sent a patch for this yesterday, I think moving the asm includes after
> the linux ones is the correct fix according to the rest of the kernel:
> https://lore.kernel.org/linux-media/20181210233514.3069-1-natechancellor@gmail.com/
> Hopefully it can be picked up quickly.
Ah, great - thanks. I agree this is probably the best fix, I just
wasn't sure if the media people had some other idea given the coding
style there.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2018-12-12 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1gWnrV-00086U-3m@optimist>
2018-12-11 22:06 ` next-20181211 build: 1 failures 32 warnings (next-20181211) Mark Brown
2018-12-11 22:15 ` Nathan Chancellor
2018-12-12 12:18 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212121826.GC6920@sirena.org.uk \
--to=broonie@kernel.org \
--cc=d.scheller@gmx.net \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mchehab+samsung@kernel.org \
--cc=natechancellor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).