* [PATCH] ARM: dts: kirkwood: Fix polarity of GPIO fan lines
@ 2019-01-07 23:08 Linus Walleij
2019-01-08 23:02 ` Jamie Lentin
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Linus Walleij @ 2019-01-07 23:08 UTC (permalink / raw)
To: Jason Cooper, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth
Cc: Julien D'Ascenzio, Linus Walleij, Guenter Roeck,
Jamie Lentin, linux-arm-kernel
These two lines are active high, not active low. The bug was
found when we changed the kernel to respect the polarity defined
in the device tree.
Fixes: 1b90e06b1429 ("ARM: kirkwood: Use devicetree to define DNS-32[05] fan")
Cc: Jamie Lentin <jm@lentin.co.uk>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@bootlin.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Julien D'Ascenzio <jdascenzio@posteo.net>
Reported-by: Julien D'Ascenzio <jdascenzio@posteo.net>
Tested-by: Julien D'Ascenzio <jdascenzio@posteo.net>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
arch/arm/boot/dts/kirkwood-dnskw.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/kirkwood-dnskw.dtsi b/arch/arm/boot/dts/kirkwood-dnskw.dtsi
index cbaf06f2f78e..eb917462b219 100644
--- a/arch/arm/boot/dts/kirkwood-dnskw.dtsi
+++ b/arch/arm/boot/dts/kirkwood-dnskw.dtsi
@@ -36,8 +36,8 @@
compatible = "gpio-fan";
pinctrl-0 = <&pmx_fan_high_speed &pmx_fan_low_speed>;
pinctrl-names = "default";
- gpios = <&gpio1 14 GPIO_ACTIVE_LOW
- &gpio1 13 GPIO_ACTIVE_LOW>;
+ gpios = <&gpio1 14 GPIO_ACTIVE_HIGH
+ &gpio1 13 GPIO_ACTIVE_HIGH>;
gpio-fan,speed-map = <0 0
3000 1
6000 2>;
--
2.19.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: kirkwood: Fix polarity of GPIO fan lines
2019-01-07 23:08 [PATCH] ARM: dts: kirkwood: Fix polarity of GPIO fan lines Linus Walleij
@ 2019-01-08 23:02 ` Jamie Lentin
2019-01-08 23:09 ` Andrew Lunn
2019-01-10 11:25 ` Gregory CLEMENT
2 siblings, 0 replies; 4+ messages in thread
From: Jamie Lentin @ 2019-01-08 23:02 UTC (permalink / raw)
To: Linus Walleij
Cc: Andrew Lunn, Jason Cooper, Gregory Clement, linux-arm-kernel,
Julien D'Ascenzio, Guenter Roeck, Sebastian Hesselbarth
On Tue, 8 Jan 2019, Linus Walleij wrote:
> These two lines are active high, not active low. The bug was
> found when we changed the kernel to respect the polarity defined
> in the device tree.
>
> Fixes: 1b90e06b1429 ("ARM: kirkwood: Use devicetree to define DNS-32[05] fan")
> Cc: Jamie Lentin <jm@lentin.co.uk>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Gregory Clement <gregory.clement@bootlin.com>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Cc: Julien D'Ascenzio <jdascenzio@posteo.net>
> Reported-by: Julien D'Ascenzio <jdascenzio@posteo.net>
> Tested-by: Julien D'Ascenzio <jdascenzio@posteo.net>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Tested-by: Jamie Lentin <jm@lentin.co.uk>
...on a DNS-325 applied atop arm-soc/for-next. Apologies for not noticing
this sooner!
Cheers,
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: kirkwood: Fix polarity of GPIO fan lines
2019-01-07 23:08 [PATCH] ARM: dts: kirkwood: Fix polarity of GPIO fan lines Linus Walleij
2019-01-08 23:02 ` Jamie Lentin
@ 2019-01-08 23:09 ` Andrew Lunn
2019-01-10 11:25 ` Gregory CLEMENT
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2019-01-08 23:09 UTC (permalink / raw)
To: Linus Walleij
Cc: Jason Cooper, Jamie Lentin, linux-arm-kernel,
Julien D'Ascenzio, Gregory Clement, Guenter Roeck,
Sebastian Hesselbarth
On Tue, Jan 08, 2019 at 12:08:18AM +0100, Linus Walleij wrote:
> These two lines are active high, not active low. The bug was
> found when we changed the kernel to respect the polarity defined
> in the device tree.
>
> Fixes: 1b90e06b1429 ("ARM: kirkwood: Use devicetree to define DNS-32[05] fan")
> Cc: Jamie Lentin <jm@lentin.co.uk>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Gregory Clement <gregory.clement@bootlin.com>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Cc: Julien D'Ascenzio <jdascenzio@posteo.net>
> Reported-by: Julien D'Ascenzio <jdascenzio@posteo.net>
> Tested-by: Julien D'Ascenzio <jdascenzio@posteo.net>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: kirkwood: Fix polarity of GPIO fan lines
2019-01-07 23:08 [PATCH] ARM: dts: kirkwood: Fix polarity of GPIO fan lines Linus Walleij
2019-01-08 23:02 ` Jamie Lentin
2019-01-08 23:09 ` Andrew Lunn
@ 2019-01-10 11:25 ` Gregory CLEMENT
2 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2019-01-10 11:25 UTC (permalink / raw)
To: Linus Walleij
Cc: Andrew Lunn, Jason Cooper, Jamie Lentin, linux-arm-kernel,
Julien D'Ascenzio, Guenter Roeck, Sebastian Hesselbarth
Hi Linus,
On mar., janv. 08 2019, Linus Walleij <linus.walleij@linaro.org> wrote:
> These two lines are active high, not active low. The bug was
> found when we changed the kernel to respect the polarity defined
> in the device tree.
>
> Fixes: 1b90e06b1429 ("ARM: kirkwood: Use devicetree to define DNS-32[05] fan")
> Cc: Jamie Lentin <jm@lentin.co.uk>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Gregory Clement <gregory.clement@bootlin.com>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Cc: Julien D'Ascenzio <jdascenzio@posteo.net>
> Reported-by: Julien D'Ascenzio <jdascenzio@posteo.net>
> Tested-by: Julien D'Ascenzio <jdascenzio@posteo.net>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied on mvebu/fixes with tags from Andrew and Jamie
Thanks,
Gregory
> ---
> arch/arm/boot/dts/kirkwood-dnskw.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood-dnskw.dtsi b/arch/arm/boot/dts/kirkwood-dnskw.dtsi
> index cbaf06f2f78e..eb917462b219 100644
> --- a/arch/arm/boot/dts/kirkwood-dnskw.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-dnskw.dtsi
> @@ -36,8 +36,8 @@
> compatible = "gpio-fan";
> pinctrl-0 = <&pmx_fan_high_speed &pmx_fan_low_speed>;
> pinctrl-names = "default";
> - gpios = <&gpio1 14 GPIO_ACTIVE_LOW
> - &gpio1 13 GPIO_ACTIVE_LOW>;
> + gpios = <&gpio1 14 GPIO_ACTIVE_HIGH
> + &gpio1 13 GPIO_ACTIVE_HIGH>;
> gpio-fan,speed-map = <0 0
> 3000 1
> 6000 2>;
> --
> 2.19.2
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-10 11:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-07 23:08 [PATCH] ARM: dts: kirkwood: Fix polarity of GPIO fan lines Linus Walleij
2019-01-08 23:02 ` Jamie Lentin
2019-01-08 23:09 ` Andrew Lunn
2019-01-10 11:25 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).