* [arm-soc:arm/qcom/drivers-2 19/19] drivers/soc/qcom/llcc-slice.c:153:17: sparse: error: Expected ; at end of statement
@ 2019-02-16 5:53 kbuild test robot
0 siblings, 0 replies; only message in thread
From: kbuild test robot @ 2019-02-16 5:53 UTC (permalink / raw)
To: Jordan Crouse
Cc: Andy Gross, arm, kbuild-all, linux-arm-kernel, Douglas Anderson
[-- Attachment #1: Type: text/plain, Size: 4098 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git arm/qcom/drivers-2
head: ed10a259faa1bbdf77b8c2153b274b70c90cbb35
commit: ed10a259faa1bbdf77b8c2153b274b70c90cbb35 [19/19] qcom: soc: llcc-slice: Consolidate some code
reproduce:
# apt-get install sparse
git checkout ed10a259faa1bbdf77b8c2153b274b70c90cbb35
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
All errors (new ones prefixed by >>):
>> drivers/soc/qcom/llcc-slice.c:153:17: sparse: error: Expected ; at end of statement
>> drivers/soc/qcom/llcc-slice.c:153:17: sparse: error: got return
drivers/soc/qcom/llcc-slice.c:193:17: sparse: error: Expected ; at end of statement
drivers/soc/qcom/llcc-slice.c:193:17: sparse: error: got return
>> drivers/soc/qcom/llcc-slice.c:152:9: sparse: error: undefined identifier 'If'
drivers/soc/qcom/llcc-slice.c:192:9: sparse: error: undefined identifier 'If'
vim +153 drivers/soc/qcom/llcc-slice.c
a3134fb0 Rishabh Bhatnagar 2018-05-23 139
a3134fb0 Rishabh Bhatnagar 2018-05-23 140 /**
a3134fb0 Rishabh Bhatnagar 2018-05-23 141 * llcc_slice_activate - Activate the llcc slice
a3134fb0 Rishabh Bhatnagar 2018-05-23 142 * @desc: Pointer to llcc slice descriptor
a3134fb0 Rishabh Bhatnagar 2018-05-23 143 *
a3134fb0 Rishabh Bhatnagar 2018-05-23 144 * A value of zero will be returned on success and a negative errno will
a3134fb0 Rishabh Bhatnagar 2018-05-23 145 * be returned in error cases
a3134fb0 Rishabh Bhatnagar 2018-05-23 146 */
a3134fb0 Rishabh Bhatnagar 2018-05-23 147 int llcc_slice_activate(struct llcc_slice_desc *desc)
a3134fb0 Rishabh Bhatnagar 2018-05-23 148 {
a3134fb0 Rishabh Bhatnagar 2018-05-23 149 int ret;
a3134fb0 Rishabh Bhatnagar 2018-05-23 150 u32 act_ctrl_val;
a3134fb0 Rishabh Bhatnagar 2018-05-23 151
72d1cd03 Jordan Crouse 2018-12-11 @152 If (IS_ERR(drv_data))
72d1cd03 Jordan Crouse 2018-12-11 @153 return PTR_ERR(drv_data);
72d1cd03 Jordan Crouse 2018-12-11 154
e0f2cfeb Jordan Crouse 2018-10-05 155 if (IS_ERR_OR_NULL(desc))
e0f2cfeb Jordan Crouse 2018-10-05 156 return -EINVAL;
e0f2cfeb Jordan Crouse 2018-10-05 157
a3134fb0 Rishabh Bhatnagar 2018-05-23 158 mutex_lock(&drv_data->lock);
a3134fb0 Rishabh Bhatnagar 2018-05-23 159 if (test_bit(desc->slice_id, drv_data->bitmap)) {
a3134fb0 Rishabh Bhatnagar 2018-05-23 160 mutex_unlock(&drv_data->lock);
a3134fb0 Rishabh Bhatnagar 2018-05-23 161 return 0;
a3134fb0 Rishabh Bhatnagar 2018-05-23 162 }
a3134fb0 Rishabh Bhatnagar 2018-05-23 163
a3134fb0 Rishabh Bhatnagar 2018-05-23 164 act_ctrl_val = ACT_CTRL_OPCODE_ACTIVATE << ACT_CTRL_OPCODE_SHIFT;
a3134fb0 Rishabh Bhatnagar 2018-05-23 165
a3134fb0 Rishabh Bhatnagar 2018-05-23 166 ret = llcc_update_act_ctrl(desc->slice_id, act_ctrl_val,
a3134fb0 Rishabh Bhatnagar 2018-05-23 167 DEACTIVATE);
a3134fb0 Rishabh Bhatnagar 2018-05-23 168 if (ret) {
a3134fb0 Rishabh Bhatnagar 2018-05-23 169 mutex_unlock(&drv_data->lock);
a3134fb0 Rishabh Bhatnagar 2018-05-23 170 return ret;
a3134fb0 Rishabh Bhatnagar 2018-05-23 171 }
a3134fb0 Rishabh Bhatnagar 2018-05-23 172
a3134fb0 Rishabh Bhatnagar 2018-05-23 173 __set_bit(desc->slice_id, drv_data->bitmap);
a3134fb0 Rishabh Bhatnagar 2018-05-23 174 mutex_unlock(&drv_data->lock);
a3134fb0 Rishabh Bhatnagar 2018-05-23 175
a3134fb0 Rishabh Bhatnagar 2018-05-23 176 return ret;
a3134fb0 Rishabh Bhatnagar 2018-05-23 177 }
a3134fb0 Rishabh Bhatnagar 2018-05-23 178 EXPORT_SYMBOL_GPL(llcc_slice_activate);
a3134fb0 Rishabh Bhatnagar 2018-05-23 179
:::::: The code at line 153 was first introduced by commit
:::::: 72d1cd033154f50e77cd4feb4e16c227b598632e qcom: soc: llcc-slice: Clear the global drv_data pointer on error
:::::: TO: Jordan Crouse <jcrouse@codeaurora.org>
:::::: CC: Andy Gross <andy.gross@linaro.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 67234 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-02-16 5:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-16 5:53 [arm-soc:arm/qcom/drivers-2 19/19] drivers/soc/qcom/llcc-slice.c:153:17: sparse: error: Expected ; at end of statement kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).