From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Chen-Yu Tsai <wens@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Arnd Bergmann <arnd@arndb.de>,
Robin Murphy <robin.murphy@arm.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Dave Martin <dave.martin@arm.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Yong Deng <yong.deng@magewell.com>,
Frank Rowand <frowand.list@gmail.com>,
Georgi Djakov <georgi.djakov@linaro.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/7] dt-bindings: interconnect: Add a dma interconnect name
Date: Mon, 11 Mar 2019 11:11:30 +0100 [thread overview]
Message-ID: <20190311101130.7t7rctxlqly3uqmt@flea> (raw)
In-Reply-To: <CAGb2v666u1c1OE3FnN=Y_kZe7TgNKvtA6=GYiHuWycJ2ooQhxw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 3626 bytes --]
On Fri, Mar 08, 2019 at 12:09:47AM +0800, Chen-Yu Tsai wrote:
> On Thu, Mar 7, 2019 at 11:48 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > On Thu, Mar 07, 2019 at 05:15:20PM +0200, Georgi Djakov wrote:
> > > Hi,
> > >
> > > On 3/5/19 18:14, Robin Murphy wrote:
> > > > On 05/03/2019 15:53, Maxime Ripard wrote:
> > > >> Hi,
> > > >>
> > > >> On Fri, Mar 01, 2019 at 07:48:15PM +0200, Georgi Djakov wrote:
> > > >>> On 2/11/19 17:02, Maxime Ripard wrote:
> > > >>>> The current DT bindings assume that the DMA will be performed by the
> > > >>>> devices through their parent DT node, and rely on that assumption
> > > >>>> for the
> > > >>>> address translation using dma-ranges.
> > > >>>>
> > > >>>> However, some SoCs have devices that will perform DMA through
> > > >>>> another bus,
> > > >>>> with separate address translation rules. We therefore need to
> > > >>>> express that
> > > >>>> relationship, through the special interconnect name "dma".
> > > >>>>
> > > >>>> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > > >>>> ---
> > > >>>> Documentation/devicetree/bindings/interconnect/interconnect.txt |
> > > >>>> 3 +++
> > > >>>> 1 file changed, 3 insertions(+)
> > > >>>>
> > > >>>> diff --git
> > > >>>> a/Documentation/devicetree/bindings/interconnect/interconnect.txt
> > > >>>> b/Documentation/devicetree/bindings/interconnect/interconnect.txt
> > > >>>> index 5a3c575b387a..e69fc2d992c3 100644
> > > >>>> --- a/Documentation/devicetree/bindings/interconnect/interconnect.txt
> > > >>>> +++ b/Documentation/devicetree/bindings/interconnect/interconnect.txt
> > > >>>> @@ -51,6 +51,9 @@ interconnect-names : List of interconnect path
> > > >>>> name strings sorted in the same
> > > >>>> interconnect-names to match interconnect paths with
> > > >>>> interconnect
> > > >>>> specifier pairs.
> > > >>>> + Reserved interconnect names:
> > > >>>> + * dma: Path from the device to the main
> > > >>>> memory of the system
> > > >>>
> > > >>> Bikeshed: As it's from the device to the main memory, maybe here we can
> > > >>> also denote this my calling the path dma-mem or dma-memory. For other
> > > >>> paths, we are trying to mention both the source and the destination and
> > > >>> maybe it would be good to be consistent although this is special one.
> > > >>
> > > >> I'm not sure I understand what you mean. You'd like two interconnect
> > > >> names, one called dma-memory, and one memory-dma?
> > > >
> > > > Hmm, yes, it's not like "dma" describes an actual source or destination
> > > > either :/
> > >
> > > IIUC, it's a path (bus) that a dma device use to access some memory
> > > (read or/and write). So i have used source-destination above more in the
> > > sense of initiator-target or master-slave. My suggestion was just to
> > > change the reserved interconnect name from "dma" to "dma-mem" or
> > > "dma-memory".
> >
> > If dma is an issue in itself, maybe we can call it "device-memory" ?
>
> Might I ask what happens if the device can both DMA to and from memory?
We can create another one called memory-device if that's needed?
> IIRC the display frontends, backends, and mixers all have writeback
> capability, using the same interconnect port.
I think in both cases it's the same path. The camera driver also need
to have that offset, even though it's a producer and not a consumer,
and the VPU does too.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-11 10:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 15:02 [PATCH v3 0/7] sunxi: Add DT representation for the MBUS controller Maxime Ripard
2019-02-11 15:02 ` [PATCH v3 1/7] dt-bindings: interconnect: Add a dma interconnect name Maxime Ripard
2019-03-01 17:48 ` Georgi Djakov
2019-03-05 15:53 ` Maxime Ripard
2019-03-05 16:14 ` Robin Murphy
2019-03-07 15:15 ` Georgi Djakov
2019-03-07 15:47 ` Maxime Ripard
2019-03-07 16:09 ` Chen-Yu Tsai
2019-03-11 10:11 ` Maxime Ripard [this message]
2019-03-11 14:11 ` Chen-Yu Tsai
2019-03-13 11:48 ` Georgi Djakov
2019-02-11 15:02 ` [PATCH v3 2/7] dt-bindings: bus: Add binding for the Allwinner MBUS controller Maxime Ripard
2019-02-12 18:53 ` Robin Murphy
2019-02-11 15:02 ` [PATCH v3 3/7] of: address: Add parent pointer to the __of_translate_address args Maxime Ripard
2019-02-12 18:02 ` Robin Murphy
2019-02-11 15:02 ` [PATCH v3 4/7] of: address: Add support for the parent DMA bus Maxime Ripard
2019-02-12 18:15 ` Robin Murphy
2019-02-11 15:02 ` [PATCH v3 5/7] drm/sun4i: Rely on dma interconnect for our RAM offset Maxime Ripard
2019-02-12 18:46 ` Robin Murphy
2019-02-13 15:41 ` Maxime Ripard
2019-02-13 16:40 ` Robin Murphy
2019-02-19 10:55 ` Maxime Ripard
2019-03-05 16:11 ` Robin Murphy
2019-02-11 15:02 ` [PATCH v3 6/7] clk: sunxi-ng: sun5i: Export the MBUS clock Maxime Ripard
2019-02-11 15:02 ` [PATCH v3 7/7] ARM: dts: sun5i: Add the MBUS controller Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311101130.7t7rctxlqly3uqmt@flea \
--to=maxime.ripard@bootlin.com \
--cc=arnd@arndb.de \
--cc=dave.martin@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
--cc=wens@kernel.org \
--cc=yong.deng@magewell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).