linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: sun8i: a23/a33: Add R_I2C Controller
@ 2019-03-18 12:56 Maxime Ripard
  2019-03-22  8:55 ` Chen-Yu Tsai
  0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2019-03-18 12:56 UTC (permalink / raw)
  To: Chen-Yu Tsai, Maxime Ripard; +Cc: linux-kernel, linux-arm-kernel

The A23 and A33 both have an I2C controller in the ARISC domain, that share
the same pins with the RSB bus.

Even if it's an unusual configuration, that device can be used to drive the
PMIC, so let's use it.

Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 arch/arm/boot/dts/sun8i-a23-a33.dtsi | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
index 43fe215e83ea..2eed7a2d7d7e 100644
--- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
+++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
@@ -799,6 +799,20 @@
 			status = "disabled";
 		};
 
+		r_i2c: i2c@1f02400 {
+			compatible = "allwinner,sun8i-a23-i2c",
+				     "allwinner,sun6i-a31-i2c";
+			reg = <0x01f02400 0x400>;
+			interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&r_i2c_pins>;
+			clocks = <&apb0_gates 6>;
+			resets = <&apb0_rst 6>;
+			status = "disabled";
+			#address-cells = <1>;
+			#size-cells = <0>;
+		};
+
 		r_pio: pinctrl@1f02c00 {
 			compatible = "allwinner,sun8i-a23-r-pinctrl";
 			reg = <0x01f02c00 0x400>;
@@ -811,6 +825,12 @@
 			#interrupt-cells = <3>;
 			#gpio-cells = <3>;
 
+			r_i2c_pins: r-i2c-pins {
+				pins = "PL0", "PL1";
+				function = "s_i2c";
+				bias-pull-up;
+			};
+
 			r_rsb_pins: r-rsb-pins {
 				pins = "PL0", "PL1";
 				function = "s_rsb";
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: sun8i: a23/a33: Add R_I2C Controller
  2019-03-18 12:56 [PATCH] ARM: dts: sun8i: a23/a33: Add R_I2C Controller Maxime Ripard
@ 2019-03-22  8:55 ` Chen-Yu Tsai
  2019-03-25 10:04   ` Maxime Ripard
  0 siblings, 1 reply; 3+ messages in thread
From: Chen-Yu Tsai @ 2019-03-22  8:55 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: linux-kernel, linux-arm-kernel

On Mon, Mar 18, 2019 at 8:56 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> The A23 and A33 both have an I2C controller in the ARISC domain, that share
> the same pins with the RSB bus.
>
> Even if it's an unusual configuration, that device can be used to drive the
> PMIC, so let's use it.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>

Acked-by: Chen-Yu Tsai <wens@csie.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: sun8i: a23/a33: Add R_I2C Controller
  2019-03-22  8:55 ` Chen-Yu Tsai
@ 2019-03-25 10:04   ` Maxime Ripard
  0 siblings, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2019-03-25 10:04 UTC (permalink / raw)
  To: Chen-Yu Tsai; +Cc: linux-kernel, linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 594 bytes --]

On Fri, Mar 22, 2019 at 04:55:29PM +0800, Chen-Yu Tsai wrote:
> On Mon, Mar 18, 2019 at 8:56 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > The A23 and A33 both have an I2C controller in the ARISC domain, that share
> > the same pins with the RSB bus.
> >
> > Even if it's an unusual configuration, that device can be used to drive the
> > PMIC, so let's use it.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
>
> Acked-by: Chen-Yu Tsai <wens@csie.org>

Applied, thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-03-25 10:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-18 12:56 [PATCH] ARM: dts: sun8i: a23/a33: Add R_I2C Controller Maxime Ripard
2019-03-22  8:55 ` Chen-Yu Tsai
2019-03-25 10:04   ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).