From: Olof Johansson <olof@lixom.net>
To: Simon Horman <horms+renesas@verge.net.au>
Cc: Arnd Bergmann <arnd@arndb.de>, Kevin Hilman <khilman@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-renesas-soc@vger.kernel.org, arm@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [GIT PULL] Renesas ARM Based SoC Updates for v5.3
Date: Tue, 25 Jun 2019 05:49:24 -0700 [thread overview]
Message-ID: <20190625124924.ubpi3pxwggbz5cbw@localhost> (raw)
In-Reply-To: <cover.1561105093.git.horms+renesas@verge.net.au>
On Fri, Jun 21, 2019 at 11:12:04AM +0200, Simon Horman wrote:
> Hi Olof, Hi Kevin, Hi Arnd,
>
> Please consider these Renesas ARM based SoC updates for v5.3.
>
>
> The following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9:
>
> Linux 5.2-rc1 (2019-05-19 15:47:09 -0700)
>
> are available in the git repository at:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-arm-soc-for-v5.3
>
> for you to fetch changes up to 02af9f90941b6cce5fb672ee058c142adcc11a2f:
>
> soc: renesas: Enable RZ/A1 IRQC on RZ/A1H and RZ/A2M (2019-06-06 10:37:06 +0200)
>
> ----------------------------------------------------------------
> Renesas ARM Based SoC Updates for v5.3
>
> * Auto-enable RZ/A1 IRQC on RZ/A1H and RZ/A2M
> * Don't init CNTVOFF/counter if PSCI is available
>
> ----------------------------------------------------------------
> Geert Uytterhoeven (1):
> soc: renesas: Enable RZ/A1 IRQC on RZ/A1H and RZ/A2M
>
> Oleksandr Tyshchenko (1):
> ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available
Merged, thanks.
Note that in this patch, code like this:
+#ifdef CONFIG_ARM_PSCI_FW
+ if (psci_ops.cpu_on)
+ need_update = false;
+#endif
+
+ if (need_update == false)
+ goto skip_update;
Can either be replaced with a goto under the ifdef, or at the very least, no
need to do a 'need_update == false' -- 'if (need_update)' is sufficient.
-Olof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-25 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 9:12 [GIT PULL] Renesas ARM Based SoC Updates for v5.3 Simon Horman
2019-06-21 9:12 ` [PATCH 1/2] ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available Simon Horman
2019-06-21 9:12 ` [PATCH 2/2] soc: renesas: Enable RZ/A1 IRQC on RZ/A1H and RZ/A2M Simon Horman
2019-06-25 12:49 ` Olof Johansson [this message]
2019-06-25 13:23 ` [GIT PULL] Renesas ARM Based SoC Updates for v5.3 Geert Uytterhoeven
2019-06-27 1:35 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625124924.ubpi3pxwggbz5cbw@localhost \
--to=olof@lixom.net \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=horms+renesas@verge.net.au \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).