From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Olof Johansson <olof@lixom.net>
Cc: Arnd Bergmann <arnd@arndb.de>, Kevin Hilman <khilman@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
arm-soc <arm@kernel.org>,
Simon Horman <horms+renesas@verge.net.au>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [GIT PULL] Renesas ARM Based SoC Updates for v5.3
Date: Tue, 25 Jun 2019 15:23:24 +0200 [thread overview]
Message-ID: <CAMuHMdVj5G6-m9iqQQM5nAQZbhC=GL0DtgUKXff7UBQ8uNwmBw@mail.gmail.com> (raw)
In-Reply-To: <20190625124924.ubpi3pxwggbz5cbw@localhost>
Hi Olof,
On Tue, Jun 25, 2019 at 3:10 PM Olof Johansson <olof@lixom.net> wrote:
> On Fri, Jun 21, 2019 at 11:12:04AM +0200, Simon Horman wrote:
> > Oleksandr Tyshchenko (1):
> > ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available
>
> Merged, thanks.
Thanks!
> Note that in this patch, code like this:
>
> +#ifdef CONFIG_ARM_PSCI_FW
> + if (psci_ops.cpu_on)
> + need_update = false;
> +#endif
> +
> + if (need_update == false)
> + goto skip_update;
>
>
> Can either be replaced with a goto under the ifdef, or at the very least, no
I believe a goto under the ifdef may cause a "label defined but not used"
warning if CONFIG_ARM_PSCI_FW is not defined.
> need to do a 'need_update == false' -- 'if (need_update)' is sufficient.
Yeah, "if (!need_update)" would work too.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-25 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 9:12 [GIT PULL] Renesas ARM Based SoC Updates for v5.3 Simon Horman
2019-06-21 9:12 ` [PATCH 1/2] ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available Simon Horman
2019-06-21 9:12 ` [PATCH 2/2] soc: renesas: Enable RZ/A1 IRQC on RZ/A1H and RZ/A2M Simon Horman
2019-06-25 12:49 ` [GIT PULL] Renesas ARM Based SoC Updates for v5.3 Olof Johansson
2019-06-25 13:23 ` Geert Uytterhoeven [this message]
2019-06-27 1:35 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVj5G6-m9iqQQM5nAQZbhC=GL0DtgUKXff7UBQ8uNwmBw@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=horms+renesas@verge.net.au \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).