From: Mark Brown <broonie@kernel.org>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Mark Rutland <mark.rutland@arm.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
Stephen Boyd <sboyd@kernel.org>, Ray Jui <rjui@broadcom.com>,
Linus Walleij <linus.walleij@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Eric Anholt <eric@anholt.net>, Rob Herring <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org,
Martin Sperl <kernel@martin.sperl.org>,
Michael Turquette <mturquette@baylibre.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH RFC 15/18] spi: bcm2835: enable shared interrupt support
Date: Thu, 18 Jul 2019 19:52:38 +0100 [thread overview]
Message-ID: <20190718185238.GH5761@sirena.org.uk> (raw)
In-Reply-To: <b23c7a5a-a432-5af6-a7dc-0a7dfbe57712@gmx.net>
[-- Attachment #1.1: Type: text/plain, Size: 976 bytes --]
On Thu, Jul 18, 2019 at 07:53:43PM +0200, Stefan Wahren wrote:
> Am 18.07.19 um 14:42 schrieb Mark Brown:
> > On Wed, Jul 17, 2019 at 11:16:01PM +0200, Stefan Wahren wrote:
> >> + /* check if we got interrupt enabled */
> >> + if (!(bcm2835_rd(bs, BCM2835_SPI_CS) & BCM2835_SPI_CS_INTR))
> >> + return IRQ_NONE;
> > Is that checking if the interrupt is enabled or if it is asserted?
> the BCM2835 doesn't provide a SPI register, which shows that the
> interrupt has been asserted.
> So i think, Martin tried to adapt the workaround from spi-bcm2835-aux
> which has the same problem.
OK, I don't know what that workaround was or exactly what this is
checking but if it's just checking if the interrupt was enabled then
there's going to be cases where this gets called while interrupts are
enabled but due to another device asserting the interrupt. If the
driver can cope with that and this is just an optimization then fine but
if it's relying on this there's an issue.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-18 18:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 21:16 [PATCH RFC 14/18] HACK: pinctrl: bcm2835: Implement legacy pull for BCM7211 Stefan Wahren
2019-07-17 21:16 ` [PATCH RFC 15/18] spi: bcm2835: enable shared interrupt support Stefan Wahren
2019-07-18 12:42 ` Mark Brown
2019-07-18 17:53 ` Stefan Wahren
2019-07-18 18:05 ` Florian Fainelli
2019-07-18 18:21 ` Stefan Wahren
2019-07-24 17:15 ` Mark Brown
2019-07-18 18:52 ` Mark Brown [this message]
2019-07-17 21:16 ` [PATCH RFC 16/18] dt-bindings: bcm: Add Raspberry Pi 4 B Stefan Wahren
2019-07-17 21:16 ` [PATCH RFC 17/18] ARM: bcm2835: Add bcm2838 compatible string Stefan Wahren
2019-07-17 21:16 ` [PATCH RFC 18/18] ARM: dts: Add minimal Raspberry Pi 4 support Stefan Wahren
2019-07-17 21:22 ` Florian Fainelli
2019-07-17 21:32 ` Stefan Wahren
2019-07-23 18:13 ` Marc Zyngier
2019-07-24 9:51 ` Vladimir Murzin
2019-07-24 10:41 ` Marc Zyngier
2019-07-24 12:36 ` Vladimir Murzin
2019-07-24 19:04 ` Stefan Wahren
2019-07-28 10:58 ` Stefan Wahren
2019-07-28 11:38 ` Marc Zyngier
2019-07-30 18:33 ` Stefan Wahren
2019-07-31 10:55 ` Marc Zyngier
2019-08-02 22:12 ` [PATCH RFC 14/18] HACK: pinctrl: bcm2835: Implement legacy pull for BCM7211 Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718185238.GH5761@sirena.org.uk \
--to=broonie@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@martin.sperl.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sbranden@broadcom.com \
--cc=ulf.hansson@linaro.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).