* [PATCH] docs/arm64: cpu-feature-registers: Rewrite bitfields that don't follow [e, s]
@ 2019-11-01 15:20 Julien Grall
2019-11-01 15:36 ` Catalin Marinas
2019-11-01 15:38 ` Will Deacon
0 siblings, 2 replies; 4+ messages in thread
From: Julien Grall @ 2019-11-01 15:20 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: catalin.marinas, Julien Grall, will, suzuki.poulose
From: Julien Grall <julien.grall@arm.com>
Commit "docs/arm64: cpu-feature-registers: Documents missing visible
fields" added bitfiels following the convention [s, e]. However, the
documentation is following [s, e] and so does the Arm ARM.
Rewrite the bitfields to match the format [e, s].
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
This is based on the branch for-next/elf-hwcap-docs from the tree
arm64/linux.git.
---
Documentation/arm64/cpu-feature-registers.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/arm64/cpu-feature-registers.rst b/Documentation/arm64/cpu-feature-registers.rst
index ffcf4e2c71ef..7c40e4581bae 100644
--- a/Documentation/arm64/cpu-feature-registers.rst
+++ b/Documentation/arm64/cpu-feature-registers.rst
@@ -193,9 +193,9 @@ infrastructure:
+------------------------------+---------+---------+
| Name | bits | visible |
+------------------------------+---------+---------+
- | SB | [36-39] | y |
+ | SB | [39-36] | y |
+------------------------------+---------+---------+
- | FRINTTS | [32-35] | y |
+ | FRINTTS | [35-32] | y |
+------------------------------+---------+---------+
| GPI | [31-28] | y |
+------------------------------+---------+---------+
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] docs/arm64: cpu-feature-registers: Rewrite bitfields that don't follow [e, s]
2019-11-01 15:20 [PATCH] docs/arm64: cpu-feature-registers: Rewrite bitfields that don't follow [e, s] Julien Grall
@ 2019-11-01 15:36 ` Catalin Marinas
2019-11-01 15:38 ` Will Deacon
1 sibling, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2019-11-01 15:36 UTC (permalink / raw)
To: Julien Grall
Cc: Julien Grall, will, linux-kernel, linux-arm-kernel, suzuki.poulose
On Fri, Nov 01, 2019 at 03:20:22PM +0000, Julien Grall wrote:
> From: Julien Grall <julien.grall@arm.com>
>
> Commit "docs/arm64: cpu-feature-registers: Documents missing visible
> fields" added bitfiels following the convention [s, e]. However, the
> documentation is following [s, e] and so does the Arm ARM.
>
> Rewrite the bitfields to match the format [e, s].
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Applied. Thanks.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] docs/arm64: cpu-feature-registers: Rewrite bitfields that don't follow [e, s]
2019-11-01 15:20 [PATCH] docs/arm64: cpu-feature-registers: Rewrite bitfields that don't follow [e, s] Julien Grall
2019-11-01 15:36 ` Catalin Marinas
@ 2019-11-01 15:38 ` Will Deacon
2019-11-01 15:53 ` Catalin Marinas
1 sibling, 1 reply; 4+ messages in thread
From: Will Deacon @ 2019-11-01 15:38 UTC (permalink / raw)
To: Julien Grall
Cc: catalin.marinas, Julien Grall, linux-kernel, linux-arm-kernel,
suzuki.poulose
On Fri, Nov 01, 2019 at 03:20:22PM +0000, Julien Grall wrote:
> From: Julien Grall <julien.grall@arm.com>
>
> Commit "docs/arm64: cpu-feature-registers: Documents missing visible
> fields" added bitfiels following the convention [s, e]. However, the
typo: bitfiels
> documentation is following [s, e] and so does the Arm ARM.
This should be [e, s], although I think you can spell it out as "end" and
"start" so people know what this is doing.
>
> Rewrite the bitfields to match the format [e, s].
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
> ---
>
> This is based on the branch for-next/elf-hwcap-docs from the tree
> arm64/linux.git.
> ---
> Documentation/arm64/cpu-feature-registers.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/arm64/cpu-feature-registers.rst b/Documentation/arm64/cpu-feature-registers.rst
> index ffcf4e2c71ef..7c40e4581bae 100644
> --- a/Documentation/arm64/cpu-feature-registers.rst
> +++ b/Documentation/arm64/cpu-feature-registers.rst
> @@ -193,9 +193,9 @@ infrastructure:
> +------------------------------+---------+---------+
> | Name | bits | visible |
> +------------------------------+---------+---------+
> - | SB | [36-39] | y |
> + | SB | [39-36] | y |
> +------------------------------+---------+---------+
> - | FRINTTS | [32-35] | y |
> + | FRINTTS | [35-32] | y |
> +------------------------------+---------+---------+
> | GPI | [31-28] | y |
> +------------------------------+---------+---------+
diff looks fine.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] docs/arm64: cpu-feature-registers: Rewrite bitfields that don't follow [e, s]
2019-11-01 15:38 ` Will Deacon
@ 2019-11-01 15:53 ` Catalin Marinas
0 siblings, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2019-11-01 15:53 UTC (permalink / raw)
To: Will Deacon
Cc: Julien Grall, Julien Grall, linux-kernel, linux-arm-kernel,
suzuki.poulose
On Fri, Nov 01, 2019 at 03:38:04PM +0000, Will Deacon wrote:
> On Fri, Nov 01, 2019 at 03:20:22PM +0000, Julien Grall wrote:
> > From: Julien Grall <julien.grall@arm.com>
> >
> > Commit "docs/arm64: cpu-feature-registers: Documents missing visible
> > fields" added bitfiels following the convention [s, e]. However, the
>
> typo: bitfiels
>
> > documentation is following [s, e] and so does the Arm ARM.
>
> This should be [e, s], although I think you can spell it out as "end" and
> "start" so people know what this is doing.
Thanks. I'll make the changes locally.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-01 15:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-01 15:20 [PATCH] docs/arm64: cpu-feature-registers: Rewrite bitfields that don't follow [e, s] Julien Grall
2019-11-01 15:36 ` Catalin Marinas
2019-11-01 15:38 ` Will Deacon
2019-11-01 15:53 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).