linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Amit Daniel Kachhap <amit.kachhap@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Kees Cook <keescook@chromium.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	Kristina Martsenko <kristina.martsenko@arm.com>,
	James Morse <james.morse@arm.com>,
	Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,
	Mark Brown <Mark.Brown@arm.com>,
	Vincenzo Frascino <Vincenzo.Frascino@arm.com>,
	Will Deacon <will@kernel.org>, Dave Martin <Dave.Martin@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 16/16] lkdtm: arm64: test kernel pointer authentication
Date: Fri, 17 Jan 2020 11:53:30 +0000	[thread overview]
Message-ID: <20200117115330.GH26090@arrakis.emea.arm.com> (raw)
In-Reply-To: <1576486038-9899-17-git-send-email-amit.kachhap@arm.com>

On Mon, Dec 16, 2019 at 02:17:18PM +0530, Amit Daniel Kachhap wrote:
> This test is specific for arm64. When in-kernel Pointer Authentication
> config is enabled, the return address stored in the stack is signed.
> This feature helps in ROP kind of attack. If any parameters used to
> generate the pac (<key, sp, lr>) is modified then this will fail in
> the authentication stage and will lead to abort.
> 
> This test changes the input parameter APIA kernel keys to cause abort.
> The pac computed from the new key can be same as last due to hash
> collision so this is retried for few times as there is no reliable way
> to compare the pacs. Even though this test may fail even after retries
> but this may cause authentication failure at a later stage in earlier
> function returns.
> 
> This test can be invoked as,
> echo CORRUPT_PAC > /sys/kernel/debug/provoke-crash/DIRECT
> 
> or as below if inserted as a module,
> insmod lkdtm.ko cpoint_name=DIRECT cpoint_type=CORRUPT_PAC cpoint_count=1
> 
> [   13.118166] lkdtm: Performing direct entry CORRUPT_PAC
> [   13.118298] lkdtm: Clearing PAC from the return address
> [   13.118466] Unable to handle kernel paging request at virtual address bfff8000108648ec
> [   13.118626] Mem abort info:
> [   13.118666]   ESR = 0x86000004
> [   13.118866]   EC = 0x21: IABT (current EL), IL = 32 bits
> [   13.118966]   SET = 0, FnV = 0
> [   13.119117]   EA = 0, S1PTW = 0
> 
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com>

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-01-17 11:53 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16  8:47 [PATCH v3 00/16] arm64: return address signing Amit Daniel Kachhap
2019-12-16  8:47 ` [PATCH v3 01/16] arm64: cpufeature: add pointer auth meta-capabilities Amit Daniel Kachhap
2020-01-15 12:26   ` Catalin Marinas
2020-01-15 13:52     ` Suzuki Kuruppassery Poulose
2020-01-15 16:01       ` Catalin Marinas
2020-01-16 12:35         ` Amit Kachhap
2019-12-16  8:47 ` [PATCH v3 02/16] arm64: rename ptrauth key structures to be user-specific Amit Daniel Kachhap
2020-01-15 16:42   ` Catalin Marinas
2019-12-16  8:47 ` [PATCH v3 03/16] arm64: install user ptrauth keys at kernel exit time Amit Daniel Kachhap
2020-01-15 17:02   ` Catalin Marinas
2020-01-16 12:39     ` Amit Kachhap
2019-12-16  8:47 ` [PATCH v3 04/16] arm64: create macro to park cpu in an infinite loop Amit Daniel Kachhap
2020-01-07 11:13   ` Suzuki Kuruppassery Poulose
2020-01-15 17:03   ` Catalin Marinas
2019-12-16  8:47 ` [PATCH v3 05/16] arm64: ptrauth: Add bootup/runtime flags for __cpu_setup Amit Daniel Kachhap
2020-01-07 11:18   ` Suzuki Kuruppassery Poulose
2020-01-09  8:33     ` Amit Kachhap
2020-01-15 17:30   ` Catalin Marinas
2020-01-16 12:40     ` Amit Kachhap
2019-12-16  8:47 ` [PATCH v3 06/16] arm64: enable ptrauth earlier Amit Daniel Kachhap
2020-01-07 11:35   ` Suzuki Kuruppassery Poulose
2020-01-09  8:29     ` Amit Kachhap
2020-01-10 10:18       ` Suzuki Kuruppassery Poulose
2020-01-16 16:24   ` Catalin Marinas
2020-01-17 10:43     ` Amit Kachhap
2020-01-17 12:00       ` Catalin Marinas
2020-01-20 14:27         ` Amit Kachhap
2019-12-16  8:47 ` [PATCH v3 07/16] arm64: initialize and switch ptrauth kernel keys Amit Daniel Kachhap
2020-01-16 18:00   ` Catalin Marinas
2019-12-16  8:47 ` [PATCH v3 08/16] arm64: initialize ptrauth keys for kernel booting task Amit Daniel Kachhap
2020-01-16 17:59   ` Catalin Marinas
2020-01-20 10:50     ` Amit Kachhap
2019-12-16  8:47 ` [PATCH v3 09/16] arm64: mask PAC bits of __builtin_return_address Amit Daniel Kachhap
2020-01-17 10:14   ` Catalin Marinas
2020-01-20 14:20     ` Amit Kachhap
2020-01-21 16:52       ` Catalin Marinas
2019-12-16  8:47 ` [PATCH v3 10/16] arm64: unwind: strip PAC from kernel addresses Amit Daniel Kachhap
2020-01-17 10:22   ` Catalin Marinas
2019-12-16  8:47 ` [PATCH v3 11/16] arm64: __show_regs: strip PAC from lr in printk Amit Daniel Kachhap
2020-01-17 10:25   ` Catalin Marinas
2019-12-16  8:47 ` [PATCH v3 12/16] arm64: suspend: restore the kernel ptrauth keys Amit Daniel Kachhap
2020-01-17 10:31   ` Catalin Marinas
2019-12-16  8:47 ` [PATCH v3 13/16] arm64: kprobe: disable probe of ptrauth instruction Amit Daniel Kachhap
2020-01-17 11:16   ` Catalin Marinas
2020-01-20 14:24     ` Amit Kachhap
2019-12-16  8:47 ` [PATCH v3 14/16] kconfig: Add support for 'as-option' Amit Daniel Kachhap
2019-12-17 11:43   ` Masahiro Yamada
2020-01-17 11:33   ` Catalin Marinas
2020-01-17 17:51     ` Masahiro Yamada
2020-01-20 10:26     ` Vincenzo Frascino
2019-12-16  8:47 ` [PATCH v3 15/16] arm64: compile the kernel with ptrauth return address signing Amit Daniel Kachhap
2020-01-17 11:49   ` Catalin Marinas
2020-01-21 14:37     ` Amit Kachhap
2020-01-21 14:46       ` Vincenzo Frascino
2020-01-21 16:50       ` Catalin Marinas
2019-12-16  8:47 ` [PATCH v3 16/16] lkdtm: arm64: test kernel pointer authentication Amit Daniel Kachhap
2020-01-17 11:53   ` Catalin Marinas [this message]
2019-12-16  9:35 ` [RESEND PATCH v3 00/16] arm64: return address signing Amit Daniel Kachhap
2019-12-30 19:09 ` [PATCH " Kees Cook
2020-01-07 11:07   ` Amit Kachhap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200117115330.GH26090@arrakis.emea.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=Dave.Martin@arm.com \
    --cc=Mark.Brown@arm.com \
    --cc=Vincenzo.Frascino@arm.com \
    --cc=amit.kachhap@arm.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=james.morse@arm.com \
    --cc=keescook@chromium.org \
    --cc=kristina.martsenko@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=ramana.radhakrishnan@arm.com \
    --cc=richard.henderson@linaro.org \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).