From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Amit Kachhap <amit.kachhap@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Kees Cook <keescook@chromium.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
Kristina Martsenko <kristina.martsenko@arm.com>,
James Morse <james.morse@arm.com>,
Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,
Mark Brown <Mark.Brown@arm.com>, Will Deacon <will@kernel.org>,
Dave Martin <Dave.Martin@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 15/16] arm64: compile the kernel with ptrauth return address signing
Date: Tue, 21 Jan 2020 14:46:08 +0000 [thread overview]
Message-ID: <6ac0a651-0d72-b8d8-645f-45ba2cb39009@arm.com> (raw)
In-Reply-To: <7e1826b5-bf1b-b3c1-c5ab-47ab464baa8c@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]
On 21/01/2020 14:37, Amit Kachhap wrote:
[...]
>>
>> Also Will had a preference for warning during build if the user
>> requested a feature in .config (i.e. PAC) but the compiler/assembler
>> does not support it (that was for the LSE patch above). You could
>> attempt something similar with this patch.
>
> I tried to add warnings like below which are in similar line to the above link,
>
> ifeq ($(CONFIG_ARM64_PTR_AUTH),y)
> + ifneq ($(CONFIG_CC_HAS_SIGN_RETURN_ADDRESS),y)
> + ifneq ($(CONFIG_CC_HAS_BRANCH_PROT_PAC_RET),y)
> +$(warning Pointer authentication not supported by compiler)
> + endif
> + endif
> + ifneq ($(CONFIG_AS_HAS_PAC),y)
> +$(warning Pointer authentication not supported by assembler)
> + endif
> endif
>
> But the issue is that warnings are printed twice and becomes confusing. First
> warning computed with the incorrect Kconfig flags and later with the correct
> computed Kconfig flags. This may be due to arch/arm64/Kconfig sourced twice.
>
This seems similar to the problem we had on vDSOs some time ago. The main
Makefile includes the arch specific twice, once for generating the building
scripts and once for building the kernel. As a consequence of this the arch
Kconfig is sourced twice. For the vDSOs we discarded the warning because it was
causing confusion.
>
>>
--
Regards,
Vincenzo
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 14291 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-21 14:46 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 8:47 [PATCH v3 00/16] arm64: return address signing Amit Daniel Kachhap
2019-12-16 8:47 ` [PATCH v3 01/16] arm64: cpufeature: add pointer auth meta-capabilities Amit Daniel Kachhap
2020-01-15 12:26 ` Catalin Marinas
2020-01-15 13:52 ` Suzuki Kuruppassery Poulose
2020-01-15 16:01 ` Catalin Marinas
2020-01-16 12:35 ` Amit Kachhap
2019-12-16 8:47 ` [PATCH v3 02/16] arm64: rename ptrauth key structures to be user-specific Amit Daniel Kachhap
2020-01-15 16:42 ` Catalin Marinas
2019-12-16 8:47 ` [PATCH v3 03/16] arm64: install user ptrauth keys at kernel exit time Amit Daniel Kachhap
2020-01-15 17:02 ` Catalin Marinas
2020-01-16 12:39 ` Amit Kachhap
2019-12-16 8:47 ` [PATCH v3 04/16] arm64: create macro to park cpu in an infinite loop Amit Daniel Kachhap
2020-01-07 11:13 ` Suzuki Kuruppassery Poulose
2020-01-15 17:03 ` Catalin Marinas
2019-12-16 8:47 ` [PATCH v3 05/16] arm64: ptrauth: Add bootup/runtime flags for __cpu_setup Amit Daniel Kachhap
2020-01-07 11:18 ` Suzuki Kuruppassery Poulose
2020-01-09 8:33 ` Amit Kachhap
2020-01-15 17:30 ` Catalin Marinas
2020-01-16 12:40 ` Amit Kachhap
2019-12-16 8:47 ` [PATCH v3 06/16] arm64: enable ptrauth earlier Amit Daniel Kachhap
2020-01-07 11:35 ` Suzuki Kuruppassery Poulose
2020-01-09 8:29 ` Amit Kachhap
2020-01-10 10:18 ` Suzuki Kuruppassery Poulose
2020-01-16 16:24 ` Catalin Marinas
2020-01-17 10:43 ` Amit Kachhap
2020-01-17 12:00 ` Catalin Marinas
2020-01-20 14:27 ` Amit Kachhap
2019-12-16 8:47 ` [PATCH v3 07/16] arm64: initialize and switch ptrauth kernel keys Amit Daniel Kachhap
2020-01-16 18:00 ` Catalin Marinas
2019-12-16 8:47 ` [PATCH v3 08/16] arm64: initialize ptrauth keys for kernel booting task Amit Daniel Kachhap
2020-01-16 17:59 ` Catalin Marinas
2020-01-20 10:50 ` Amit Kachhap
2019-12-16 8:47 ` [PATCH v3 09/16] arm64: mask PAC bits of __builtin_return_address Amit Daniel Kachhap
2020-01-17 10:14 ` Catalin Marinas
2020-01-20 14:20 ` Amit Kachhap
2020-01-21 16:52 ` Catalin Marinas
2019-12-16 8:47 ` [PATCH v3 10/16] arm64: unwind: strip PAC from kernel addresses Amit Daniel Kachhap
2020-01-17 10:22 ` Catalin Marinas
2019-12-16 8:47 ` [PATCH v3 11/16] arm64: __show_regs: strip PAC from lr in printk Amit Daniel Kachhap
2020-01-17 10:25 ` Catalin Marinas
2019-12-16 8:47 ` [PATCH v3 12/16] arm64: suspend: restore the kernel ptrauth keys Amit Daniel Kachhap
2020-01-17 10:31 ` Catalin Marinas
2019-12-16 8:47 ` [PATCH v3 13/16] arm64: kprobe: disable probe of ptrauth instruction Amit Daniel Kachhap
2020-01-17 11:16 ` Catalin Marinas
2020-01-20 14:24 ` Amit Kachhap
2019-12-16 8:47 ` [PATCH v3 14/16] kconfig: Add support for 'as-option' Amit Daniel Kachhap
2019-12-17 11:43 ` Masahiro Yamada
2020-01-17 11:33 ` Catalin Marinas
2020-01-17 17:51 ` Masahiro Yamada
2020-01-20 10:26 ` Vincenzo Frascino
2019-12-16 8:47 ` [PATCH v3 15/16] arm64: compile the kernel with ptrauth return address signing Amit Daniel Kachhap
2020-01-17 11:49 ` Catalin Marinas
2020-01-21 14:37 ` Amit Kachhap
2020-01-21 14:46 ` Vincenzo Frascino [this message]
2020-01-21 16:50 ` Catalin Marinas
2019-12-16 8:47 ` [PATCH v3 16/16] lkdtm: arm64: test kernel pointer authentication Amit Daniel Kachhap
2020-01-17 11:53 ` Catalin Marinas
2019-12-16 9:35 ` [RESEND PATCH v3 00/16] arm64: return address signing Amit Daniel Kachhap
2019-12-30 19:09 ` [PATCH " Kees Cook
2020-01-07 11:07 ` Amit Kachhap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ac0a651-0d72-b8d8-645f-45ba2cb39009@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=Dave.Martin@arm.com \
--cc=Mark.Brown@arm.com \
--cc=amit.kachhap@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=keescook@chromium.org \
--cc=kristina.martsenko@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=ramana.radhakrishnan@arm.com \
--cc=richard.henderson@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).