* [PATCH] ARM: dts: bcm283x: Add cells encoding format to firmware bus
@ 2020-03-26 13:44 Nicolas Saenz Julienne
2020-03-27 16:15 ` Matthias Brugger
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Saenz Julienne @ 2020-03-26 13:44 UTC (permalink / raw)
To: Rob Herring, Nicolas Saenz Julienne, Florian Fainelli, Ray Jui,
Scott Branden, bcm-kernel-feedback-list
Cc: devicetree, linux-rpi-kernel, linux-arm-kernel, linux-kernel
With the introduction of 55c7c0621078 ("ARM: dts: bcm283x: Fix vc4's
firmware bus DMA limitations") the firmware bus has to comply with
/soc's DMA limitations. Ultimately linking both buses to a same
dma-ranges property. The patch (and author) missed the fact that a bus'
#address-cells and #size-cells properties are not inherited, but set to
a fixed value which, in this case, doesn't match /soc's. This, although
not breaking Linux's DMA mapping functionality, generates ugly dtc
warnings.
Fix the issue by adding the correct address and size cells properties
under the firmware bus.
Fixes: 55c7c0621078 ("ARM: dts: bcm283x: Fix vc4's firmware bus DMA limitations")
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
---
arch/arm/boot/dts/bcm2835-rpi.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
index fd2c766e0f71..f7ae5a4530b8 100644
--- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
+++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
@@ -14,6 +14,9 @@ act {
soc {
firmware: firmware {
compatible = "raspberrypi,bcm2835-firmware", "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <1>;
+
mboxes = <&mailbox>;
dma-ranges;
};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: bcm283x: Add cells encoding format to firmware bus
2020-03-26 13:44 [PATCH] ARM: dts: bcm283x: Add cells encoding format to firmware bus Nicolas Saenz Julienne
@ 2020-03-27 16:15 ` Matthias Brugger
2020-03-27 16:17 ` Florian Fainelli
0 siblings, 1 reply; 4+ messages in thread
From: Matthias Brugger @ 2020-03-27 16:15 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Rob Herring, Florian Fainelli, Ray Jui,
Scott Branden, bcm-kernel-feedback-list
Cc: devicetree, linux-rpi-kernel, linux-arm-kernel, linux-kernel
On 26/03/2020 14:44, Nicolas Saenz Julienne wrote:
> With the introduction of 55c7c0621078 ("ARM: dts: bcm283x: Fix vc4's
> firmware bus DMA limitations") the firmware bus has to comply with
> /soc's DMA limitations. Ultimately linking both buses to a same
> dma-ranges property. The patch (and author) missed the fact that a bus'
> #address-cells and #size-cells properties are not inherited, but set to
> a fixed value which, in this case, doesn't match /soc's. This, although
> not breaking Linux's DMA mapping functionality, generates ugly dtc
> warnings.
>
> Fix the issue by adding the correct address and size cells properties
> under the firmware bus.
>
> Fixes: 55c7c0621078 ("ARM: dts: bcm283x: Fix vc4's firmware bus DMA limitations")
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Matthias Brugger <mbrugger@suse.com>
> ---
> arch/arm/boot/dts/bcm2835-rpi.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> index fd2c766e0f71..f7ae5a4530b8 100644
> --- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
> +++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> @@ -14,6 +14,9 @@ act {
> soc {
> firmware: firmware {
> compatible = "raspberrypi,bcm2835-firmware", "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> mboxes = <&mailbox>;
> dma-ranges;
> };
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: bcm283x: Add cells encoding format to firmware bus
2020-03-27 16:15 ` Matthias Brugger
@ 2020-03-27 16:17 ` Florian Fainelli
2020-03-27 16:48 ` Matthias Brugger
0 siblings, 1 reply; 4+ messages in thread
From: Florian Fainelli @ 2020-03-27 16:17 UTC (permalink / raw)
To: Matthias Brugger, Nicolas Saenz Julienne, Rob Herring,
Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list
Cc: devicetree, linux-rpi-kernel, linux-arm-kernel, linux-kernel
On 3/27/2020 9:15 AM, Matthias Brugger wrote:
>
>
> On 26/03/2020 14:44, Nicolas Saenz Julienne wrote:
>> With the introduction of 55c7c0621078 ("ARM: dts: bcm283x: Fix vc4's
>> firmware bus DMA limitations") the firmware bus has to comply with
>> /soc's DMA limitations. Ultimately linking both buses to a same
>> dma-ranges property. The patch (and author) missed the fact that a bus'
>> #address-cells and #size-cells properties are not inherited, but set to
>> a fixed value which, in this case, doesn't match /soc's. This, although
>> not breaking Linux's DMA mapping functionality, generates ugly dtc
>> warnings.
>>
>> Fix the issue by adding the correct address and size cells properties
>> under the firmware bus.
>>
>> Fixes: 55c7c0621078 ("ARM: dts: bcm283x: Fix vc4's firmware bus DMA limitations")
>> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>
> Reviewed-by: Matthias Brugger <mbrugger@suse.com>
Should this be squashed into "ARM: dts: bcm283x: Fix vc4's firmware bus
DMA limitations"? I have not gotten a response it has been accepted yet.
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: bcm283x: Add cells encoding format to firmware bus
2020-03-27 16:17 ` Florian Fainelli
@ 2020-03-27 16:48 ` Matthias Brugger
0 siblings, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2020-03-27 16:48 UTC (permalink / raw)
To: Florian Fainelli, Nicolas Saenz Julienne, Rob Herring, Ray Jui,
Scott Branden, bcm-kernel-feedback-list
Cc: devicetree, linux-rpi-kernel, linux-arm-kernel, linux-kernel
On 27/03/2020 17:17, Florian Fainelli wrote:
>
>
> On 3/27/2020 9:15 AM, Matthias Brugger wrote:
>>
>>
>> On 26/03/2020 14:44, Nicolas Saenz Julienne wrote:
>>> With the introduction of 55c7c0621078 ("ARM: dts: bcm283x: Fix vc4's
>>> firmware bus DMA limitations") the firmware bus has to comply with
>>> /soc's DMA limitations. Ultimately linking both buses to a same
>>> dma-ranges property. The patch (and author) missed the fact that a bus'
>>> #address-cells and #size-cells properties are not inherited, but set to
>>> a fixed value which, in this case, doesn't match /soc's. This, although
>>> not breaking Linux's DMA mapping functionality, generates ugly dtc
>>> warnings.
>>>
>>> Fix the issue by adding the correct address and size cells properties
>>> under the firmware bus.
>>>
>>> Fixes: 55c7c0621078 ("ARM: dts: bcm283x: Fix vc4's firmware bus DMA limitations")
>>> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>>
>> Reviewed-by: Matthias Brugger <mbrugger@suse.com>
>
> Should this be squashed into "ARM: dts: bcm283x: Fix vc4's firmware bus
> DMA limitations"? I have not gotten a response it has been accepted yet.
>
Well I think if we can squash the two instead of providing a Fixes-tag, even better.
Regards,
Matthias
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-27 16:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26 13:44 [PATCH] ARM: dts: bcm283x: Add cells encoding format to firmware bus Nicolas Saenz Julienne
2020-03-27 16:15 ` Matthias Brugger
2020-03-27 16:17 ` Florian Fainelli
2020-03-27 16:48 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).