* [PATCH] clocksource/drivers/timer-ti-dm: Fix warning for set but not used
@ 2020-05-19 15:51 Tony Lindgren
2020-05-19 16:00 ` Daniel Lezcano
0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2020-05-19 15:51 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner
Cc: linux-omap, linux-kernel, linux-arm-kernel, kbuild test robot
We can get a warning for dmtimer_clocksource_init() with 'pa' set but
not used. This was used in the earlier revisions of the code but no
longer needed, so let's remove the unused pa and of_translate_address().
Let's also do it for dmtimer_clockevent_init() that has a similar issue.
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/clocksource/timer-ti-dm-systimer.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/clocksource/timer-ti-dm-systimer.c b/drivers/clocksource/timer-ti-dm-systimer.c
--- a/drivers/clocksource/timer-ti-dm-systimer.c
+++ b/drivers/clocksource/timer-ti-dm-systimer.c
@@ -514,7 +514,6 @@ static int __init dmtimer_clockevent_init(struct device_node *np)
struct clock_event_device *dev;
struct dmtimer_systimer *t;
int error;
- u32 pa;
clkevt = kzalloc(sizeof(*clkevt), GFP_KERNEL);
if (!clkevt)
@@ -563,7 +562,6 @@ static int __init dmtimer_clockevent_init(struct device_node *np)
writel_relaxed(OMAP_TIMER_INT_OVERFLOW, t->base + t->irq_ena);
writel_relaxed(OMAP_TIMER_INT_OVERFLOW, t->base + t->wakeup);
- pa = of_translate_address(np, of_get_address(np, 0, NULL, NULL));
pr_info("TI gptimer clockevent: %s%lu Hz at %pOF\n",
of_find_property(np, "ti,timer-alwon", NULL) ?
"always-on " : "", t->rate, np->parent);
@@ -637,7 +635,6 @@ static int __init dmtimer_clocksource_init(struct device_node *np)
struct dmtimer_systimer *t;
struct clocksource *dev;
int error;
- u32 pa;
clksrc = kzalloc(sizeof(*clksrc), GFP_KERNEL);
if (!clksrc)
@@ -666,7 +663,6 @@ static int __init dmtimer_clocksource_init(struct device_node *np)
writel_relaxed(OMAP_TIMER_CTRL_ST | OMAP_TIMER_CTRL_AR,
t->base + t->ctrl);
- pa = of_translate_address(np, of_get_address(np, 0, NULL, NULL));
pr_info("TI gptimer clocksource: %s%pOF\n",
of_find_property(np, "ti,timer-alwon", NULL) ?
"always-on " : "", np->parent);
--
2.26.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clocksource/drivers/timer-ti-dm: Fix warning for set but not used
2020-05-19 15:51 [PATCH] clocksource/drivers/timer-ti-dm: Fix warning for set but not used Tony Lindgren
@ 2020-05-19 16:00 ` Daniel Lezcano
2020-05-19 16:06 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Lezcano @ 2020-05-19 16:00 UTC (permalink / raw)
To: Tony Lindgren, Thomas Gleixner
Cc: linux-omap, linux-kernel, linux-arm-kernel, kbuild test robot
On 19/05/2020 17:51, Tony Lindgren wrote:
> We can get a warning for dmtimer_clocksource_init() with 'pa' set but
> not used. This was used in the earlier revisions of the code but no
> longer needed, so let's remove the unused pa and of_translate_address().
> Let's also do it for dmtimer_clockevent_init() that has a similar issue.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clocksource/drivers/timer-ti-dm: Fix warning for set but not used
2020-05-19 16:00 ` Daniel Lezcano
@ 2020-05-19 16:06 ` Tony Lindgren
2020-05-19 16:26 ` Daniel Lezcano
0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2020-05-19 16:06 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Thomas Gleixner, linux-omap, linux-kernel, linux-arm-kernel,
kbuild test robot
* Daniel Lezcano <daniel.lezcano@linaro.org> [200519 16:01]:
> On 19/05/2020 17:51, Tony Lindgren wrote:
> > We can get a warning for dmtimer_clocksource_init() with 'pa' set but
> > not used. This was used in the earlier revisions of the code but no
> > longer needed, so let's remove the unused pa and of_translate_address().
> > Let's also do it for dmtimer_clockevent_init() that has a similar issue.
> >
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > ---
>
> Applied, thanks
Thanks! Do you already have some immutable commit I can use
as the base for the SoC and dts changes? Or do you want to
wait a bit for that?
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clocksource/drivers/timer-ti-dm: Fix warning for set but not used
2020-05-19 16:06 ` Tony Lindgren
@ 2020-05-19 16:26 ` Daniel Lezcano
2020-05-19 16:28 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Lezcano @ 2020-05-19 16:26 UTC (permalink / raw)
To: Tony Lindgren
Cc: Thomas Gleixner, linux-omap, linux-kernel, linux-arm-kernel,
kbuild test robot
On 19/05/2020 18:06, Tony Lindgren wrote:
> * Daniel Lezcano <daniel.lezcano@linaro.org> [200519 16:01]:
>> On 19/05/2020 17:51, Tony Lindgren wrote:
>>> We can get a warning for dmtimer_clocksource_init() with 'pa' set but
>>> not used. This was used in the earlier revisions of the code but no
>>> longer needed, so let's remove the unused pa and of_translate_address().
>>> Let's also do it for dmtimer_clockevent_init() that has a similar issue.
>>>
>>> Reported-by: kbuild test robot <lkp@intel.com>
>>> Signed-off-by: Tony Lindgren <tony@atomide.com>
>>> ---
>>
>> Applied, thanks
>
> Thanks! Do you already have some immutable commit I can use
> as the base for the SoC and dts changes? Or do you want to
> wait a bit for that?
Hi Tony,
https://git.linaro.org/people/daniel.lezcano/linux.git/log/?h=timers/drivers/timer-ti
it contains the two patches + the warning fix
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clocksource/drivers/timer-ti-dm: Fix warning for set but not used
2020-05-19 16:26 ` Daniel Lezcano
@ 2020-05-19 16:28 ` Tony Lindgren
0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2020-05-19 16:28 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Thomas Gleixner, linux-omap, linux-kernel, linux-arm-kernel,
kbuild test robot
* Daniel Lezcano <daniel.lezcano@linaro.org> [200519 16:27]:
> On 19/05/2020 18:06, Tony Lindgren wrote:
> > * Daniel Lezcano <daniel.lezcano@linaro.org> [200519 16:01]:
> >> On 19/05/2020 17:51, Tony Lindgren wrote:
> >>> We can get a warning for dmtimer_clocksource_init() with 'pa' set but
> >>> not used. This was used in the earlier revisions of the code but no
> >>> longer needed, so let's remove the unused pa and of_translate_address().
> >>> Let's also do it for dmtimer_clockevent_init() that has a similar issue.
> >>>
> >>> Reported-by: kbuild test robot <lkp@intel.com>
> >>> Signed-off-by: Tony Lindgren <tony@atomide.com>
> >>> ---
> >>
> >> Applied, thanks
> >
> > Thanks! Do you already have some immutable commit I can use
> > as the base for the SoC and dts changes? Or do you want to
> > wait a bit for that?
>
> Hi Tony,
>
> https://git.linaro.org/people/daniel.lezcano/linux.git/log/?h=timers/drivers/timer-ti
>
> it contains the two patches + the warning fix
OK thanks a lot! Will use that as the base then.
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-19 16:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-19 15:51 [PATCH] clocksource/drivers/timer-ti-dm: Fix warning for set but not used Tony Lindgren
2020-05-19 16:00 ` Daniel Lezcano
2020-05-19 16:06 ` Tony Lindgren
2020-05-19 16:26 ` Daniel Lezcano
2020-05-19 16:28 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).