linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm: remove unnecessary code for handling SA_THIRTYTWO
@ 2020-08-18  3:17 Peter Collingbourne
  0 siblings, 0 replies; only message in thread
From: Peter Collingbourne @ 2020-08-18  3:17 UTC (permalink / raw)
  To: Russell King; +Cc: Peter Collingbourne, linux-arm-kernel

Support for 26-bit ARM was removed back in commit 99eb8a550dbc ("Remove
the arm26 port") from 2007. This remaining code was intended to
potentially set the MODE_MASK bits of CPSR from the previously-defined
USR26_MODE to USR_MODE. However, we can now expect CPSR to always be
set to USR_MODE at this point, so the code was not doing anything.

Signed-off-by: Peter Collingbourne <pcc@google.com>
---
View this change in Gerrit: https://linux-review.googlesource.com/q/Icf0635756e8591c6af22fb86319d3ca9df4a6b87

 arch/arm/kernel/signal.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm/kernel/signal.c b/arch/arm/kernel/signal.c
index c9dc912b83f0..7c0f33c38d2b 100644
--- a/arch/arm/kernel/signal.c
+++ b/arch/arm/kernel/signal.c
@@ -380,12 +380,6 @@ setup_return(struct pt_regs *regs, struct ksignal *ksig,
 
 	cpsr |= PSR_ENDSTATE;
 
-	/*
-	 * Maybe we need to deliver a 32-bit signal to a 26-bit task.
-	 */
-	if (ksig->ka.sa.sa_flags & SA_THIRTYTWO)
-		cpsr = (cpsr & ~MODE_MASK) | USR_MODE;
-
 #ifdef CONFIG_ARM_THUMB
 	if (elf_hwcap & HWCAP_THUMB) {
 		/*
-- 
2.28.0.220.ged08abb693-goog


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-08-18  3:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-18  3:17 [PATCH] arm: remove unnecessary code for handling SA_THIRTYTWO Peter Collingbourne

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).