* [PATCH v2 9/9] phy/drivers/stm32: Use HZ macros
[not found] <20210224144222.23762-1-daniel.lezcano@linaro.org>
@ 2021-02-24 14:42 ` Daniel Lezcano
2021-03-02 16:32 ` Vinod Koul
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Lezcano @ 2021-02-24 14:42 UTC (permalink / raw)
To: rafael, andriy.shevchenko
Cc: Etienne Carriere, Amelie Delaunay, Alexandre Torgue,
linux-kernel, Kishon Vijay Abraham I, Vinod Koul,
Maxime Coquelin, Chunfeng Yun,
moderated list:ARM/STM32 ARCHITECTURE,
moderated list:ARM/STM32 ARCHITECTURE
HZ unit conversion macros are available in units.h, use them and
remove the duplicate definition.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/phy/st/phy-stm32-usbphyc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
index a54317e96c41..02dd12bb4692 100644
--- a/drivers/phy/st/phy-stm32-usbphyc.c
+++ b/drivers/phy/st/phy-stm32-usbphyc.c
@@ -14,6 +14,7 @@
#include <linux/of_platform.h>
#include <linux/phy/phy.h>
#include <linux/reset.h>
+#include <linux/units.h>
#define STM32_USBPHYC_PLL 0x0
#define STM32_USBPHYC_MISC 0x8
@@ -48,7 +49,6 @@ static const char * const supplies_names[] = {
#define PLL_FVCO_MHZ 2880
#define PLL_INFF_MIN_RATE_HZ 19200000
#define PLL_INFF_MAX_RATE_HZ 38400000
-#define HZ_PER_MHZ 1000000L
struct pll_params {
u8 ndiv;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 9/9] phy/drivers/stm32: Use HZ macros
2021-02-24 14:42 ` [PATCH v2 9/9] phy/drivers/stm32: Use HZ macros Daniel Lezcano
@ 2021-03-02 16:32 ` Vinod Koul
2021-03-02 17:03 ` Daniel Lezcano
0 siblings, 1 reply; 5+ messages in thread
From: Vinod Koul @ 2021-03-02 16:32 UTC (permalink / raw)
To: Daniel Lezcano
Cc: rafael, andriy.shevchenko, linux-kernel, Kishon Vijay Abraham I,
Maxime Coquelin, Alexandre Torgue, Amelie Delaunay,
Etienne Carriere, Chunfeng Yun,
moderated list:ARM/STM32 ARCHITECTURE,
moderated list:ARM/STM32 ARCHITECTURE
On 24-02-21, 15:42, Daniel Lezcano wrote:
> HZ unit conversion macros are available in units.h, use them and
> remove the duplicate definition.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> drivers/phy/st/phy-stm32-usbphyc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
> index a54317e96c41..02dd12bb4692 100644
> --- a/drivers/phy/st/phy-stm32-usbphyc.c
> +++ b/drivers/phy/st/phy-stm32-usbphyc.c
> @@ -14,6 +14,7 @@
> #include <linux/of_platform.h>
> #include <linux/phy/phy.h>
> #include <linux/reset.h>
> +#include <linux/units.h>
>
> #define STM32_USBPHYC_PLL 0x0
> #define STM32_USBPHYC_MISC 0x8
> @@ -48,7 +49,6 @@ static const char * const supplies_names[] = {
> #define PLL_FVCO_MHZ 2880
> #define PLL_INFF_MIN_RATE_HZ 19200000
> #define PLL_INFF_MAX_RATE_HZ 38400000
> -#define HZ_PER_MHZ 1000000L
I dont see this in units.h, can you send this once it is merged upstream
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 9/9] phy/drivers/stm32: Use HZ macros
2021-03-02 16:32 ` Vinod Koul
@ 2021-03-02 17:03 ` Daniel Lezcano
2021-03-03 5:40 ` Vinod Koul
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Lezcano @ 2021-03-02 17:03 UTC (permalink / raw)
To: Vinod Koul
Cc: rafael, andriy.shevchenko, linux-kernel, Kishon Vijay Abraham I,
Maxime Coquelin, Alexandre Torgue, Amelie Delaunay,
Etienne Carriere, Chunfeng Yun,
moderated list:ARM/STM32 ARCHITECTURE,
moderated list:ARM/STM32 ARCHITECTURE
On 02/03/2021 17:32, Vinod Koul wrote:
> On 24-02-21, 15:42, Daniel Lezcano wrote:
>> HZ unit conversion macros are available in units.h, use them and
>> remove the duplicate definition.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> ---
>> drivers/phy/st/phy-stm32-usbphyc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
>> index a54317e96c41..02dd12bb4692 100644
>> --- a/drivers/phy/st/phy-stm32-usbphyc.c
>> +++ b/drivers/phy/st/phy-stm32-usbphyc.c
>> @@ -14,6 +14,7 @@
>> #include <linux/of_platform.h>
>> #include <linux/phy/phy.h>
>> #include <linux/reset.h>
>> +#include <linux/units.h>
>>
>> #define STM32_USBPHYC_PLL 0x0
>> #define STM32_USBPHYC_MISC 0x8
>> @@ -48,7 +49,6 @@ static const char * const supplies_names[] = {
>> #define PLL_FVCO_MHZ 2880
>> #define PLL_INFF_MIN_RATE_HZ 19200000
>> #define PLL_INFF_MAX_RATE_HZ 38400000
>> -#define HZ_PER_MHZ 1000000L
>
> I dont see this in units.h, can you send this once it is merged upstream
Actually, it is the first patch of the series.
I asked Rafael if he can merge the entire series.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 9/9] phy/drivers/stm32: Use HZ macros
2021-03-02 17:03 ` Daniel Lezcano
@ 2021-03-03 5:40 ` Vinod Koul
2021-03-03 6:09 ` Daniel Lezcano
0 siblings, 1 reply; 5+ messages in thread
From: Vinod Koul @ 2021-03-03 5:40 UTC (permalink / raw)
To: Daniel Lezcano
Cc: rafael, andriy.shevchenko, linux-kernel, Kishon Vijay Abraham I,
Maxime Coquelin, Alexandre Torgue, Amelie Delaunay,
Etienne Carriere, Chunfeng Yun,
moderated list:ARM/STM32 ARCHITECTURE,
moderated list:ARM/STM32 ARCHITECTURE
On 02-03-21, 18:03, Daniel Lezcano wrote:
> On 02/03/2021 17:32, Vinod Koul wrote:
> > On 24-02-21, 15:42, Daniel Lezcano wrote:
> >> HZ unit conversion macros are available in units.h, use them and
> >> remove the duplicate definition.
> >>
> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> >> ---
> >> drivers/phy/st/phy-stm32-usbphyc.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
> >> index a54317e96c41..02dd12bb4692 100644
> >> --- a/drivers/phy/st/phy-stm32-usbphyc.c
> >> +++ b/drivers/phy/st/phy-stm32-usbphyc.c
> >> @@ -14,6 +14,7 @@
> >> #include <linux/of_platform.h>
> >> #include <linux/phy/phy.h>
> >> #include <linux/reset.h>
> >> +#include <linux/units.h>
> >>
> >> #define STM32_USBPHYC_PLL 0x0
> >> #define STM32_USBPHYC_MISC 0x8
> >> @@ -48,7 +49,6 @@ static const char * const supplies_names[] = {
> >> #define PLL_FVCO_MHZ 2880
> >> #define PLL_INFF_MIN_RATE_HZ 19200000
> >> #define PLL_INFF_MAX_RATE_HZ 38400000
> >> -#define HZ_PER_MHZ 1000000L
> >
> > I dont see this in units.h, can you send this once it is merged upstream
>
> Actually, it is the first patch of the series.
>
> I asked Rafael if he can merge the entire series.
Pls cc folks on cover at least so that they are aware.
Thanks
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 9/9] phy/drivers/stm32: Use HZ macros
2021-03-03 5:40 ` Vinod Koul
@ 2021-03-03 6:09 ` Daniel Lezcano
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Lezcano @ 2021-03-03 6:09 UTC (permalink / raw)
To: Vinod Koul
Cc: rafael, andriy.shevchenko, linux-kernel, Kishon Vijay Abraham I,
Maxime Coquelin, Alexandre Torgue, Amelie Delaunay,
Etienne Carriere, Chunfeng Yun,
moderated list:ARM/STM32 ARCHITECTURE,
moderated list:ARM/STM32 ARCHITECTURE
On 03/03/2021 06:40, Vinod Koul wrote:
> On 02-03-21, 18:03, Daniel Lezcano wrote:
>> On 02/03/2021 17:32, Vinod Koul wrote:
>>> On 24-02-21, 15:42, Daniel Lezcano wrote:
>>>> HZ unit conversion macros are available in units.h, use them and
>>>> remove the duplicate definition.
>>>>
>>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>>>> ---
>>>> drivers/phy/st/phy-stm32-usbphyc.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
>>>> index a54317e96c41..02dd12bb4692 100644
>>>> --- a/drivers/phy/st/phy-stm32-usbphyc.c
>>>> +++ b/drivers/phy/st/phy-stm32-usbphyc.c
>>>> @@ -14,6 +14,7 @@
>>>> #include <linux/of_platform.h>
>>>> #include <linux/phy/phy.h>
>>>> #include <linux/reset.h>
>>>> +#include <linux/units.h>
>>>>
>>>> #define STM32_USBPHYC_PLL 0x0
>>>> #define STM32_USBPHYC_MISC 0x8
>>>> @@ -48,7 +49,6 @@ static const char * const supplies_names[] = {
>>>> #define PLL_FVCO_MHZ 2880
>>>> #define PLL_INFF_MIN_RATE_HZ 19200000
>>>> #define PLL_INFF_MAX_RATE_HZ 38400000
>>>> -#define HZ_PER_MHZ 1000000L
>>>
>>> I dont see this in units.h, can you send this once it is merged upstream
>>
>> Actually, it is the first patch of the series.
>>
>> I asked Rafael if he can merge the entire series.
>
> Pls cc folks on cover at least so that they are aware.
Yeah, sorry for that. I tend to rely too much on the default 'cccmd'.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-03 21:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210224144222.23762-1-daniel.lezcano@linaro.org>
2021-02-24 14:42 ` [PATCH v2 9/9] phy/drivers/stm32: Use HZ macros Daniel Lezcano
2021-03-02 16:32 ` Vinod Koul
2021-03-02 17:03 ` Daniel Lezcano
2021-03-03 5:40 ` Vinod Koul
2021-03-03 6:09 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).