From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Mason Zhang <Mason.Zhang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-spi <linux-spi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Mediatek WSD Upstream <wsd_upstream@mediatek.com>
Subject: Re: [PATCH v2 3/4] spi: mediatek: modify set_cs_timing callback
Date: Tue, 3 Aug 2021 20:30:49 +0100 [thread overview]
Message-ID: <20210803193049.GQ4668@sirena.org.uk> (raw)
In-Reply-To: <CAHp75VcPhBB+21wVErWRq+mSDaCkpQBovn+xvMbXyfENnuu40Q@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 387 bytes --]
On Tue, Aug 03, 2021 at 09:20:19PM +0300, Andy Shevchenko wrote:
> On Tue, Aug 3, 2021 at 1:42 PM Mason Zhang <Mason.Zhang@mediatek.com> wrote:
> > + inactive = inactive ? inactive : 1;
> All of these can be simplified by using ?: (short ternary) form.
Please don't, if anything just don't use the ternery operator at all for
things like this - it doesn't help with legibility.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-08-03 19:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 10:24 [PATCH v2 3/4] spi: mediatek: modify set_cs_timing callback Mason Zhang
2021-08-03 18:20 ` Andy Shevchenko
2021-08-03 19:30 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210803193049.GQ4668@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Mason.Zhang@mediatek.com \
--cc=andy.shevchenko@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).