* [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error
@ 2014-09-03 15:50 Chen Gang
2014-09-08 5:20 ` Michal Simek
0 siblings, 1 reply; 7+ messages in thread
From: Chen Gang @ 2014-09-03 15:50 UTC (permalink / raw)
To: linux-arm-kernel
Need include it for irq_of_parse_and_map(), the related error with
allmodconfig under microblaze:
drivers/usb/host/ehci-xilinx-of.c: In function ?ehci_hcd_xilinx_of_probe?:
drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ?irq_of_parse_and_map? [-Werror=implicit-function-declaration]
irq = irq_of_parse_and_map(dn, 0);
^
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/usb/host/ehci-xilinx-of.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
index fe57710..a232836 100644
--- a/drivers/usb/host/ehci-xilinx-of.c
+++ b/drivers/usb/host/ehci-xilinx-of.c
@@ -31,6 +31,7 @@
#include <linux/of.h>
#include <linux/of_platform.h>
#include <linux/of_address.h>
+#include <linux/of_irq.h>
/**
* ehci_xilinx_port_handed_over - hand the port out if failed to enable it
--
1.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error
2014-09-03 15:50 [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error Chen Gang
@ 2014-09-08 5:20 ` Michal Simek
2014-09-20 4:19 ` Chen Gang
0 siblings, 1 reply; 7+ messages in thread
From: Michal Simek @ 2014-09-08 5:20 UTC (permalink / raw)
To: linux-arm-kernel
On 09/03/2014 05:50 PM, Chen Gang wrote:
> Need include it for irq_of_parse_and_map(), the related error with
> allmodconfig under microblaze:
>
> drivers/usb/host/ehci-xilinx-of.c: In function ?ehci_hcd_xilinx_of_probe?:
> drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ?irq_of_parse_and_map? [-Werror=implicit-function-declaration]
> irq = irq_of_parse_and_map(dn, 0);
> ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> drivers/usb/host/ehci-xilinx-of.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
> index fe57710..a232836 100644
> --- a/drivers/usb/host/ehci-xilinx-of.c
> +++ b/drivers/usb/host/ehci-xilinx-of.c
> @@ -31,6 +31,7 @@
> #include <linux/of.h>
> #include <linux/of_platform.h>
> #include <linux/of_address.h>
> +#include <linux/of_irq.h>
>
> /**
> * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
>
Acked-by: Michal Simek <monstr@monstr.eu>
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140908/51d60e4e/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error
2014-09-08 5:20 ` Michal Simek
@ 2014-09-20 4:19 ` Chen Gang
2014-09-22 13:25 ` Michal Simek
0 siblings, 1 reply; 7+ messages in thread
From: Chen Gang @ 2014-09-20 4:19 UTC (permalink / raw)
To: linux-arm-kernel
Hello Maintainers:
Please help check this patch, when you have time.
Thanks.
On 09/08/2014 01:20 PM, Michal Simek wrote:
> On 09/03/2014 05:50 PM, Chen Gang wrote:
>> Need include it for irq_of_parse_and_map(), the related error with
>> allmodconfig under microblaze:
>>
>> drivers/usb/host/ehci-xilinx-of.c: In function ?ehci_hcd_xilinx_of_probe?:
>> drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ?irq_of_parse_and_map? [-Werror=implicit-function-declaration]
>> irq = irq_of_parse_and_map(dn, 0);
>> ^
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>> drivers/usb/host/ehci-xilinx-of.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
>> index fe57710..a232836 100644
>> --- a/drivers/usb/host/ehci-xilinx-of.c
>> +++ b/drivers/usb/host/ehci-xilinx-of.c
>> @@ -31,6 +31,7 @@
>> #include <linux/of.h>
>> #include <linux/of_platform.h>
>> #include <linux/of_address.h>
>> +#include <linux/of_irq.h>
>>
>> /**
>> * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
>>
>
> Acked-by: Michal Simek <monstr@monstr.eu>
>
> Thanks,
> Michal
>
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error
2014-09-20 4:19 ` Chen Gang
@ 2014-09-22 13:25 ` Michal Simek
2014-09-24 15:41 ` Alan Stern
0 siblings, 1 reply; 7+ messages in thread
From: Michal Simek @ 2014-09-22 13:25 UTC (permalink / raw)
To: linux-arm-kernel
Hi Alan and Greg,
On 09/20/2014 06:19 AM, Chen Gang wrote:
> Hello Maintainers:
>
> Please help check this patch, when you have time.
>
> Thanks.
>
> On 09/08/2014 01:20 PM, Michal Simek wrote:
>> On 09/03/2014 05:50 PM, Chen Gang wrote:
>>> Need include it for irq_of_parse_and_map(), the related error with
>>> allmodconfig under microblaze:
>>>
>>> drivers/usb/host/ehci-xilinx-of.c: In function ?ehci_hcd_xilinx_of_probe?:
>>> drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ?irq_of_parse_and_map? [-Werror=implicit-function-declaration]
>>> irq = irq_of_parse_and_map(dn, 0);
>>> ^
>>>
>>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>>> ---
>>> drivers/usb/host/ehci-xilinx-of.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
>>> index fe57710..a232836 100644
>>> --- a/drivers/usb/host/ehci-xilinx-of.c
>>> +++ b/drivers/usb/host/ehci-xilinx-of.c
>>> @@ -31,6 +31,7 @@
>>> #include <linux/of.h>
>>> #include <linux/of_platform.h>
>>> #include <linux/of_address.h>
>>> +#include <linux/of_irq.h>
>>>
>>> /**
>>> * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
>>>
>>
>> Acked-by: Michal Simek <monstr@monstr.eu>
Alan: Can you please add this patch to your queue?
Greg: If Alan is not maintaining this part of kernel, is this patch in your queue?
I have also not a problem to add this patch through my microblaze tree
but I think it will be much better to use any USB tree.
Thanks,
Michal
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error
2014-09-22 13:25 ` Michal Simek
@ 2014-09-24 15:41 ` Alan Stern
2014-09-29 1:52 ` Greg Kroah-Hartman
0 siblings, 1 reply; 7+ messages in thread
From: Alan Stern @ 2014-09-24 15:41 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 22 Sep 2014, Michal Simek wrote:
> Hi Alan and Greg,
>
> On 09/20/2014 06:19 AM, Chen Gang wrote:
> > Hello Maintainers:
> >
> > Please help check this patch, when you have time.
> >
> > Thanks.
> >
> > On 09/08/2014 01:20 PM, Michal Simek wrote:
> >> On 09/03/2014 05:50 PM, Chen Gang wrote:
> >>> Need include it for irq_of_parse_and_map(), the related error with
> >>> allmodconfig under microblaze:
> >>>
> >>> drivers/usb/host/ehci-xilinx-of.c: In function ?ehci_hcd_xilinx_of_probe?:
> >>> drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ?irq_of_parse_and_map? [-Werror=implicit-function-declaration]
> >>> irq = irq_of_parse_and_map(dn, 0);
> >>> ^
> >>>
> >>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> >>> ---
> >>> drivers/usb/host/ehci-xilinx-of.c | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
> >>> index fe57710..a232836 100644
> >>> --- a/drivers/usb/host/ehci-xilinx-of.c
> >>> +++ b/drivers/usb/host/ehci-xilinx-of.c
> >>> @@ -31,6 +31,7 @@
> >>> #include <linux/of.h>
> >>> #include <linux/of_platform.h>
> >>> #include <linux/of_address.h>
> >>> +#include <linux/of_irq.h>
> >>>
> >>> /**
> >>> * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
> >>>
> >>
> >> Acked-by: Michal Simek <monstr@monstr.eu>
>
> Alan: Can you please add this patch to your queue?
> Greg: If Alan is not maintaining this part of kernel, is this patch in your queue?
>
> I have also not a problem to add this patch through my microblaze tree
> but I think it will be much better to use any USB tree.
Greg should be able to accept a trivial patch like this one directly.
Alan Stern
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error
2014-09-24 15:41 ` Alan Stern
@ 2014-09-29 1:52 ` Greg Kroah-Hartman
2014-09-29 7:01 ` Chen Gang
0 siblings, 1 reply; 7+ messages in thread
From: Greg Kroah-Hartman @ 2014-09-29 1:52 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 24, 2014 at 11:41:55AM -0400, Alan Stern wrote:
> On Mon, 22 Sep 2014, Michal Simek wrote:
>
> > Hi Alan and Greg,
> >
> > On 09/20/2014 06:19 AM, Chen Gang wrote:
> > > Hello Maintainers:
> > >
> > > Please help check this patch, when you have time.
> > >
> > > Thanks.
> > >
> > > On 09/08/2014 01:20 PM, Michal Simek wrote:
> > >> On 09/03/2014 05:50 PM, Chen Gang wrote:
> > >>> Need include it for irq_of_parse_and_map(), the related error with
> > >>> allmodconfig under microblaze:
> > >>>
> > >>> drivers/usb/host/ehci-xilinx-of.c: In function ?ehci_hcd_xilinx_of_probe?:
> > >>> drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ?irq_of_parse_and_map? [-Werror=implicit-function-declaration]
> > >>> irq = irq_of_parse_and_map(dn, 0);
> > >>> ^
> > >>>
> > >>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> > >>> ---
> > >>> drivers/usb/host/ehci-xilinx-of.c | 1 +
> > >>> 1 file changed, 1 insertion(+)
> > >>>
> > >>> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
> > >>> index fe57710..a232836 100644
> > >>> --- a/drivers/usb/host/ehci-xilinx-of.c
> > >>> +++ b/drivers/usb/host/ehci-xilinx-of.c
> > >>> @@ -31,6 +31,7 @@
> > >>> #include <linux/of.h>
> > >>> #include <linux/of_platform.h>
> > >>> #include <linux/of_address.h>
> > >>> +#include <linux/of_irq.h>
> > >>>
> > >>> /**
> > >>> * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
> > >>>
> > >>
> > >> Acked-by: Michal Simek <monstr@monstr.eu>
> >
> > Alan: Can you please add this patch to your queue?
> > Greg: If Alan is not maintaining this part of kernel, is this patch in your queue?
> >
> > I have also not a problem to add this patch through my microblaze tree
> > but I think it will be much better to use any USB tree.
>
> Greg should be able to accept a trivial patch like this one directly.
I can, if someone will resend it so I can apply it :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error
2014-09-29 1:52 ` Greg Kroah-Hartman
@ 2014-09-29 7:01 ` Chen Gang
0 siblings, 0 replies; 7+ messages in thread
From: Chen Gang @ 2014-09-29 7:01 UTC (permalink / raw)
To: linux-arm-kernel
On 9/29/14 9:52, Greg Kroah-Hartman wrote:
> On Wed, Sep 24, 2014 at 11:41:55AM -0400, Alan Stern wrote:
>> On Mon, 22 Sep 2014, Michal Simek wrote:
>>
>>> Alan: Can you please add this patch to your queue?
>>> Greg: If Alan is not maintaining this part of kernel, is this patch in your queue?
>>>
>>> I have also not a problem to add this patch through my microblaze tree
>>> but I think it will be much better to use any USB tree.
>>
>> Greg should be able to accept a trivial patch like this one directly.
>
> I can, if someone will resend it so I can apply it :)
>
This patch you have already applied (applied this patch in 2014-09-24),
so I need not resend it.
Thank all of you for your work.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-09-29 7:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-03 15:50 [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error Chen Gang
2014-09-08 5:20 ` Michal Simek
2014-09-20 4:19 ` Chen Gang
2014-09-22 13:25 ` Michal Simek
2014-09-24 15:41 ` Alan Stern
2014-09-29 1:52 ` Greg Kroah-Hartman
2014-09-29 7:01 ` Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).