* [PATCH] ARM64:ftrace: fix ftrace_modify_graph_caller for branch replace
@ 2015-02-12 15:33 Pratyush Anand
2015-02-12 19:51 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Pratyush Anand @ 2015-02-12 15:33 UTC (permalink / raw)
To: linux-arm-kernel
ftrace_enable_ftrace_graph_caller and ftrace_disable_ftrace_graph_caller
should replace B(jmp) instruction and not BL(call) instruction.
patch 9f1ae7596aad71d18c3e88a3927f3f76b037b8fe did a typo and used
AARCH64_INSN_BRANCH_LINK instead of AARCH64_INSN_BRANCH_NOLINK.
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
arch/arm64/kernel/ftrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/ftrace.c b/arch/arm64/kernel/ftrace.c
index cf8556ae09d0..c851be795080 100644
--- a/arch/arm64/kernel/ftrace.c
+++ b/arch/arm64/kernel/ftrace.c
@@ -156,7 +156,7 @@ static int ftrace_modify_graph_caller(bool enable)
branch = aarch64_insn_gen_branch_imm(pc,
(unsigned long)ftrace_graph_caller,
- AARCH64_INSN_BRANCH_LINK);
+ AARCH64_INSN_BRANCH_NOLINK);
nop = aarch64_insn_gen_nop();
if (enable)
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM64:ftrace: fix ftrace_modify_graph_caller for branch replace
2015-02-12 15:33 [PATCH] ARM64:ftrace: fix ftrace_modify_graph_caller for branch replace Pratyush Anand
@ 2015-02-12 19:51 ` Sergei Shtylyov
2015-02-13 4:08 ` Pratyush Anand
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2015-02-12 19:51 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 02/12/2015 06:33 PM, Pratyush Anand wrote:
> ftrace_enable_ftrace_graph_caller and ftrace_disable_ftrace_graph_caller
> should replace B(jmp) instruction and not BL(call) instruction.
> patch 9f1ae7596aad71d18c3e88a3927f3f76b037b8fe did a typo and used
s/patch/commit/. And please specify that commit's summary line in parens.
> AARCH64_INSN_BRANCH_LINK instead of AARCH64_INSN_BRANCH_NOLINK.
> Signed-off-by: Pratyush Anand <panand@redhat.com>
[...]
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM64:ftrace: fix ftrace_modify_graph_caller for branch replace
2015-02-12 19:51 ` Sergei Shtylyov
@ 2015-02-13 4:08 ` Pratyush Anand
0 siblings, 0 replies; 3+ messages in thread
From: Pratyush Anand @ 2015-02-13 4:08 UTC (permalink / raw)
To: linux-arm-kernel
On Friday 13 February 2015 01:21 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 02/12/2015 06:33 PM, Pratyush Anand wrote:
>
>> ftrace_enable_ftrace_graph_caller and ftrace_disable_ftrace_graph_caller
>> should replace B(jmp) instruction and not BL(call) instruction.
>
>> patch 9f1ae7596aad71d18c3e88a3927f3f76b037b8fe did a typo and used
>
> s/patch/commit/. And please specify that commit's summary line in
> parens.
Thanks for review, resend it with modified log.
~Pratyush
>
>> AARCH64_INSN_BRANCH_LINK instead of AARCH64_INSN_BRANCH_NOLINK.
>
>> Signed-off-by: Pratyush Anand <panand@redhat.com>
>
> [...]
>
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-13 4:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-12 15:33 [PATCH] ARM64:ftrace: fix ftrace_modify_graph_caller for branch replace Pratyush Anand
2015-02-12 19:51 ` Sergei Shtylyov
2015-02-13 4:08 ` Pratyush Anand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).