[PATCH] mailbox: make cmd_dma a __le64 to reduce warnings

[PATCH] mailbox: make cmd_dma a __le64 to reduce warnings

[Ben Dooks (Codethink)]

The cmd_dma of the brcm_sba_command is often set from the
result of cpu_to_le64, which means it should really be an
__le64 type to avoid warnings such as:

drivers/dma/bcm-sba-raid.c:583:25: warning: incorrect type in assignment (different base types)
drivers/dma/bcm-sba-raid.c:583:25:    expected unsigned long long [usertype]
drivers/dma/bcm-sba-raid.c:583:25:    got restricted __le64 [usertype]

Note, this header dos not seem to be covered by the maintainers
file, so just sending to the normal lists.

Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
---
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 include/linux/mailbox/brcm-message.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mailbox/brcm-message.h b/include/linux/mailbox/brcm-message.h
index 18da82115476..db49dc360a6b 100644
--- a/include/linux/mailbox/brcm-message.h
+++ b/include/linux/mailbox/brcm-message.h
@@ -21,7 +21,7 @@ enum brcm_message_type {
 
 struct brcm_sba_command {
 	u64 cmd;
-	u64 *cmd_dma;
+	__le64 *cmd_dma;
 	dma_addr_t cmd_dma_addr;
 #define BRCM_SBA_CMD_TYPE_A		BIT(0)
 #define BRCM_SBA_CMD_TYPE_B		BIT(1)
-- 
2.24.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mailbox: make cmd_dma a __le64 to reduce warnings

[Florian Fainelli]

On 12/19/19 9:01 AM, Ben Dooks (Codethink) wrote:
> The cmd_dma of the brcm_sba_command is often set from the
> result of cpu_to_le64, which means it should really be an
> __le64 type to avoid warnings such as:

It actually is always set from the result of cpu_to_le64() which is why
this is the correct thing to do.

> 
> drivers/dma/bcm-sba-raid.c:583:25: warning: incorrect type in assignment (different base types)
> drivers/dma/bcm-sba-raid.c:583:25:    expected unsigned long long [usertype]
> drivers/dma/bcm-sba-raid.c:583:25:    got restricted __le64 [usertype]
> 
> Note, this header dos not seem to be covered by the maintainers
> file, so just sending to the normal lists.
> 
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel