* [PATCH 1/5] dt-bindings: usb: mtu3: fix typo of DMA clock name
@ 2019-06-12 5:55 Chunfeng Yun
2019-06-12 5:55 ` [PATCH 2/5] dt-bindings: usb: mtu3: support force_vbus mode Chunfeng Yun
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Chunfeng Yun @ 2019-06-12 5:55 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring
Cc: Mark Rutland, devicetree, Jumin Li, Mathias Nyman, linux-usb,
linux-kernel, Chunfeng Yun, linux-mediatek, Matthias Brugger,
linux-arm-kernel
Fix typo of dma_ck
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
Documentation/devicetree/bindings/usb/mediatek,mtu3.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
index 3382b5cb471d..5d740e9d4525 100644
--- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
+++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
@@ -16,7 +16,7 @@ Required properties:
entry in clock-names
- clock-names : must contain "sys_ck" for clock of controller,
the following clocks are optional:
- "ref_ck", "mcu_ck" and "dam_ck";
+ "ref_ck", "mcu_ck" and "dma_ck";
- phys : see usb-hcd.txt in the current directory
- dr_mode : should be one of "host", "peripheral" or "otg",
refer to usb/generic.txt
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/5] dt-bindings: usb: mtu3: support force_vbus mode
2019-06-12 5:55 [PATCH 1/5] dt-bindings: usb: mtu3: fix typo of DMA clock name Chunfeng Yun
@ 2019-06-12 5:55 ` Chunfeng Yun
2019-07-09 14:21 ` Rob Herring
2019-06-12 5:55 ` [PATCH 3/5] dt-bindings: usb: mtk-xhci: add an optional xhci_ck clock Chunfeng Yun
` (3 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Chunfeng Yun @ 2019-06-12 5:55 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring
Cc: Mark Rutland, devicetree, Jumin Li, Mathias Nyman, linux-usb,
linux-kernel, Chunfeng Yun, linux-mediatek, Matthias Brugger,
linux-arm-kernel
Add a new property to indicate that the controller doesn't support Vbus
detection due to non-exist Vbus PIN, and the driver should set force_vbus
state for device mode
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
Documentation/devicetree/bindings/usb/mediatek,mtu3.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
index 5d740e9d4525..c13cc8642154 100644
--- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
+++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
@@ -52,6 +52,8 @@ Optional properties:
- 2 : used by mt2712 etc
- mediatek,u3p-dis-msk : mask to disable u3ports, bit0 for u3port0,
bit1 for u3port1, ... etc;
+ - mediatek,force-vbus : boolean, indicates that the controller doesn't support
+ Vbus detection due to non-exist Vbus PIN.
additionally the properties from usb-hcd.txt (in the current directory) are
supported.
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/5] dt-bindings: usb: mtk-xhci: add an optional xhci_ck clock
2019-06-12 5:55 [PATCH 1/5] dt-bindings: usb: mtu3: fix typo of DMA clock name Chunfeng Yun
2019-06-12 5:55 ` [PATCH 2/5] dt-bindings: usb: mtu3: support force_vbus mode Chunfeng Yun
@ 2019-06-12 5:55 ` Chunfeng Yun
2019-07-09 14:22 ` Rob Herring
2019-06-12 5:55 ` [PATCH 4/5] usb: mtu3: support force_vbus mode Chunfeng Yun
` (2 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Chunfeng Yun @ 2019-06-12 5:55 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring
Cc: Mark Rutland, devicetree, Jumin Li, Mathias Nyman, linux-usb,
linux-kernel, Chunfeng Yun, linux-mediatek, Matthias Brugger,
linux-arm-kernel
Add a new optional clock xhci_ck
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
index 266c2d917a28..91c0704b586b 100644
--- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
+++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
@@ -29,6 +29,7 @@ Required properties:
"sys_ck": controller clock used by normal mode,
the following ones are optional:
"ref_ck": reference clock used by low power mode etc,
+ "xhci_ck": controller clock,
"mcu_ck": mcu_bus clock for register access,
"dma_ck": dma_bus clock for data transfer by DMA
@@ -100,7 +101,7 @@ Required properties:
- clocks : a list of phandle + clock-specifier pairs, one for each
entry in clock-names
- clock-names : must contain "sys_ck", and the following ones are optional:
- "ref_ck", "mcu_ck" and "dma_ck"
+ "ref_ck", "xhci_ck", "mcu_ck" and "dma_ck"
Optional properties:
- vbus-supply : reference to the VBUS regulator;
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 4/5] usb: mtu3: support force_vbus mode
2019-06-12 5:55 [PATCH 1/5] dt-bindings: usb: mtu3: fix typo of DMA clock name Chunfeng Yun
2019-06-12 5:55 ` [PATCH 2/5] dt-bindings: usb: mtu3: support force_vbus mode Chunfeng Yun
2019-06-12 5:55 ` [PATCH 3/5] dt-bindings: usb: mtk-xhci: add an optional xhci_ck clock Chunfeng Yun
@ 2019-06-12 5:55 ` Chunfeng Yun
2019-06-12 5:55 ` [PATCH 5/5] usb: xhci-mtk: add an optional xhci_ck clock Chunfeng Yun
2019-07-09 14:20 ` [PATCH 1/5] dt-bindings: usb: mtu3: fix typo of DMA clock name Rob Herring
4 siblings, 0 replies; 9+ messages in thread
From: Chunfeng Yun @ 2019-06-12 5:55 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring
Cc: Mark Rutland, devicetree, Jumin Li, Mathias Nyman, linux-usb,
linux-kernel, Chunfeng Yun, linux-mediatek, Matthias Brugger,
linux-arm-kernel
Some SoCs don't support Vbus detection due to non-exist Vbus PIN,
so software need set force_vbus state when the controller works
as device mode.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/usb/mtu3/mtu3.h | 3 +++
drivers/usb/mtu3/mtu3_core.c | 1 +
drivers/usb/mtu3/mtu3_dr.c | 2 ++
drivers/usb/mtu3/mtu3_host.c | 1 +
drivers/usb/mtu3/mtu3_plat.c | 23 +++++++++++++++++++++++
5 files changed, 30 insertions(+)
diff --git a/drivers/usb/mtu3/mtu3.h b/drivers/usb/mtu3/mtu3.h
index 76ecf12fdf62..01b0dc9caa3e 100644
--- a/drivers/usb/mtu3/mtu3.h
+++ b/drivers/usb/mtu3/mtu3.h
@@ -231,6 +231,7 @@ struct otg_switch_mtk {
* @u3p_dis_msk: mask of disabling usb3 ports, for example, bit0==1 to
* disable u3port0, bit1==1 to disable u3port1,... etc
* @dbgfs_root: only used when supports manual dual-role switch via debugfs
+ * @force_vbus: without Vbus PIN, SW need set force_vbus state for device
* @uwk_en: it's true when supports remote wakeup in host mode
* @uwk: syscon including usb wakeup glue layer between SSUSB IP and SPM
* @uwk_reg_base: the base address of the wakeup glue layer in @uwk
@@ -257,6 +258,7 @@ struct ssusb_mtk {
int u3_ports;
int u3p_dis_msk;
struct dentry *dbgfs_root;
+ bool force_vbus;
/* usb wakeup for host mode */
bool uwk_en;
struct regmap *uwk;
@@ -415,6 +417,7 @@ static inline void mtu3_clrbits(void __iomem *base, u32 offset, u32 bits)
}
int ssusb_check_clocks(struct ssusb_mtk *ssusb, u32 ex_clks);
+void ssusb_set_force_vbus(struct ssusb_mtk *ssusb, bool vbus_on);
struct usb_request *mtu3_alloc_request(struct usb_ep *ep, gfp_t gfp_flags);
void mtu3_free_request(struct usb_ep *ep, struct usb_request *req);
void mtu3_req_complete(struct mtu3_ep *mep,
diff --git a/drivers/usb/mtu3/mtu3_core.c b/drivers/usb/mtu3/mtu3_core.c
index f8bd1d57e795..65aa382ffb85 100644
--- a/drivers/usb/mtu3/mtu3_core.c
+++ b/drivers/usb/mtu3/mtu3_core.c
@@ -604,6 +604,7 @@ static void mtu3_regs_init(struct mtu3 *mtu)
/* enable automatical HWRW from L1 */
mtu3_setbits(mbase, U3D_POWER_MANAGEMENT, LPM_HRWE);
+ ssusb_set_force_vbus(mtu->ssusb, true);
/* use new QMU format when HW version >= 0x1003 */
if (mtu->gen2cp)
mtu3_writel(mbase, U3D_QFCR, ~0x0);
diff --git a/drivers/usb/mtu3/mtu3_dr.c b/drivers/usb/mtu3/mtu3_dr.c
index 5fcb71af875a..006c5864ff45 100644
--- a/drivers/usb/mtu3/mtu3_dr.c
+++ b/drivers/usb/mtu3/mtu3_dr.c
@@ -173,8 +173,10 @@ static void ssusb_set_mailbox(struct otg_switch_mtk *otg_sx,
case MTU3_VBUS_OFF:
mtu3_stop(mtu);
pm_relax(ssusb->dev);
+ ssusb_set_force_vbus(ssusb, false);
break;
case MTU3_VBUS_VALID:
+ ssusb_set_force_vbus(ssusb, true);
/* avoid suspend when works as device */
pm_stay_awake(ssusb->dev);
mtu3_start(mtu);
diff --git a/drivers/usb/mtu3/mtu3_host.c b/drivers/usb/mtu3/mtu3_host.c
index c871b94f3e6f..7618a0c384f9 100644
--- a/drivers/usb/mtu3/mtu3_host.c
+++ b/drivers/usb/mtu3/mtu3_host.c
@@ -205,6 +205,7 @@ static void ssusb_host_setup(struct ssusb_mtk *ssusb)
ssusb_set_force_mode(ssusb, MTU3_DR_FORCE_HOST);
/* if port0 supports dual-role, works as host mode by default */
+ ssusb_set_force_vbus(ssusb, false);
ssusb_set_vbus(&ssusb->otg_switch, 1);
}
diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c
index fd0f6c5dfbc1..e9d313e92fc3 100644
--- a/drivers/usb/mtu3/mtu3_plat.c
+++ b/drivers/usb/mtu3/mtu3_plat.c
@@ -45,6 +45,27 @@ int ssusb_check_clocks(struct ssusb_mtk *ssusb, u32 ex_clks)
return 0;
}
+void ssusb_set_force_vbus(struct ssusb_mtk *ssusb, bool vbus_on)
+{
+ u32 u2ctl;
+ u32 misc;
+
+ if (!ssusb->force_vbus)
+ return;
+
+ u2ctl = mtu3_readl(ssusb->ippc_base, SSUSB_U2_CTRL(0));
+ misc = mtu3_readl(ssusb->mac_base, U3D_MISC_CTRL);
+ if (vbus_on) {
+ u2ctl &= ~SSUSB_U2_PORT_OTG_SEL;
+ misc |= VBUS_FRC_EN | VBUS_ON;
+ } else {
+ u2ctl |= SSUSB_U2_PORT_OTG_SEL;
+ misc &= ~(VBUS_FRC_EN | VBUS_ON);
+ }
+ mtu3_writel(ssusb->ippc_base, SSUSB_U2_CTRL(0), u2ctl);
+ mtu3_writel(ssusb->mac_base, U3D_MISC_CTRL, misc);
+}
+
static int ssusb_phy_init(struct ssusb_mtk *ssusb)
{
int i;
@@ -268,6 +289,8 @@ static int get_ssusb_rscs(struct platform_device *pdev, struct ssusb_mtk *ssusb)
if (IS_ERR(ssusb->ippc_base))
return PTR_ERR(ssusb->ippc_base);
+ ssusb->force_vbus = of_property_read_bool(node, "mediatek,force-vbus");
+
ssusb->dr_mode = usb_get_dr_mode(dev);
if (ssusb->dr_mode == USB_DR_MODE_UNKNOWN)
ssusb->dr_mode = USB_DR_MODE_OTG;
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 5/5] usb: xhci-mtk: add an optional xhci_ck clock
2019-06-12 5:55 [PATCH 1/5] dt-bindings: usb: mtu3: fix typo of DMA clock name Chunfeng Yun
` (2 preceding siblings ...)
2019-06-12 5:55 ` [PATCH 4/5] usb: mtu3: support force_vbus mode Chunfeng Yun
@ 2019-06-12 5:55 ` Chunfeng Yun
2019-07-09 14:20 ` [PATCH 1/5] dt-bindings: usb: mtu3: fix typo of DMA clock name Rob Herring
4 siblings, 0 replies; 9+ messages in thread
From: Chunfeng Yun @ 2019-06-12 5:55 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring
Cc: Mark Rutland, devicetree, Jumin Li, Mathias Nyman, linux-usb,
linux-kernel, Chunfeng Yun, linux-mediatek, Matthias Brugger,
linux-arm-kernel
Some SoCs may have an optional clock xhci_ck (125M or 200M), it
usually uses the same PLL as sys_ck, so support it.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/usb/host/xhci-mtk.c | 13 +++++++++++++
drivers/usb/host/xhci-mtk.h | 1 +
2 files changed, 14 insertions(+)
diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index 026fe18972d3..b18a6baef204 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -216,6 +216,10 @@ static int xhci_mtk_clks_get(struct xhci_hcd_mtk *mtk)
return PTR_ERR(mtk->sys_clk);
}
+ mtk->xhci_clk = devm_clk_get_optional(dev, "xhci_ck");
+ if (IS_ERR(mtk->xhci_clk))
+ return PTR_ERR(mtk->xhci_clk);
+
mtk->ref_clk = devm_clk_get_optional(dev, "ref_ck");
if (IS_ERR(mtk->ref_clk))
return PTR_ERR(mtk->ref_clk);
@@ -244,6 +248,12 @@ static int xhci_mtk_clks_enable(struct xhci_hcd_mtk *mtk)
goto sys_clk_err;
}
+ ret = clk_prepare_enable(mtk->xhci_clk);
+ if (ret) {
+ dev_err(mtk->dev, "failed to enable xhci_clk\n");
+ goto xhci_clk_err;
+ }
+
ret = clk_prepare_enable(mtk->mcu_clk);
if (ret) {
dev_err(mtk->dev, "failed to enable mcu_clk\n");
@@ -261,6 +271,8 @@ static int xhci_mtk_clks_enable(struct xhci_hcd_mtk *mtk)
dma_clk_err:
clk_disable_unprepare(mtk->mcu_clk);
mcu_clk_err:
+ clk_disable_unprepare(mtk->xhci_clk);
+xhci_clk_err:
clk_disable_unprepare(mtk->sys_clk);
sys_clk_err:
clk_disable_unprepare(mtk->ref_clk);
@@ -272,6 +284,7 @@ static void xhci_mtk_clks_disable(struct xhci_hcd_mtk *mtk)
{
clk_disable_unprepare(mtk->dma_clk);
clk_disable_unprepare(mtk->mcu_clk);
+ clk_disable_unprepare(mtk->xhci_clk);
clk_disable_unprepare(mtk->sys_clk);
clk_disable_unprepare(mtk->ref_clk);
}
diff --git a/drivers/usb/host/xhci-mtk.h b/drivers/usb/host/xhci-mtk.h
index 8be8c5f7ff62..5ac458b7d2e0 100644
--- a/drivers/usb/host/xhci-mtk.h
+++ b/drivers/usb/host/xhci-mtk.h
@@ -139,6 +139,7 @@ struct xhci_hcd_mtk {
struct regulator *vusb33;
struct regulator *vbus;
struct clk *sys_clk; /* sys and mac clock */
+ struct clk *xhci_clk;
struct clk *ref_clk;
struct clk *mcu_clk;
struct clk *dma_clk;
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/5] dt-bindings: usb: mtu3: fix typo of DMA clock name
2019-06-12 5:55 [PATCH 1/5] dt-bindings: usb: mtu3: fix typo of DMA clock name Chunfeng Yun
` (3 preceding siblings ...)
2019-06-12 5:55 ` [PATCH 5/5] usb: xhci-mtk: add an optional xhci_ck clock Chunfeng Yun
@ 2019-07-09 14:20 ` Rob Herring
4 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2019-07-09 14:20 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Mark Rutland, devicetree, Jumin Li, Mathias Nyman,
Greg Kroah-Hartman, linux-usb, linux-kernel, Matthias Brugger,
Rob Herring, linux-mediatek, Chunfeng Yun, linux-arm-kernel
On Wed, 12 Jun 2019 13:55:17 +0800, Chunfeng Yun wrote:
> Fix typo of dma_ck
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> Documentation/devicetree/bindings/usb/mediatek,mtu3.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/5] dt-bindings: usb: mtu3: support force_vbus mode
2019-06-12 5:55 ` [PATCH 2/5] dt-bindings: usb: mtu3: support force_vbus mode Chunfeng Yun
@ 2019-07-09 14:21 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2019-07-09 14:21 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Mark Rutland, devicetree, Jumin Li, Mathias Nyman,
Greg Kroah-Hartman, linux-usb, linux-kernel, Matthias Brugger,
Rob Herring, linux-mediatek, Chunfeng Yun, linux-arm-kernel
On Wed, 12 Jun 2019 13:55:18 +0800, Chunfeng Yun wrote:
> Add a new property to indicate that the controller doesn't support Vbus
> detection due to non-exist Vbus PIN, and the driver should set force_vbus
> state for device mode
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> Documentation/devicetree/bindings/usb/mediatek,mtu3.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/5] dt-bindings: usb: mtk-xhci: add an optional xhci_ck clock
2019-06-12 5:55 ` [PATCH 3/5] dt-bindings: usb: mtk-xhci: add an optional xhci_ck clock Chunfeng Yun
@ 2019-07-09 14:22 ` Rob Herring
2019-07-12 1:53 ` Chunfeng Yun
0 siblings, 1 reply; 9+ messages in thread
From: Rob Herring @ 2019-07-09 14:22 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Mark Rutland, devicetree, Mathias Nyman, Greg Kroah-Hartman,
linux-usb, linux-kernel, Jumin Li, linux-mediatek,
Matthias Brugger, linux-arm-kernel
On Wed, Jun 12, 2019 at 01:55:19PM +0800, Chunfeng Yun wrote:
> Add a new optional clock xhci_ck
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> index 266c2d917a28..91c0704b586b 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> @@ -29,6 +29,7 @@ Required properties:
> "sys_ck": controller clock used by normal mode,
> the following ones are optional:
> "ref_ck": reference clock used by low power mode etc,
> + "xhci_ck": controller clock,
> "mcu_ck": mcu_bus clock for register access,
> "dma_ck": dma_bus clock for data transfer by DMA
A new clock should go at the end to stay backwards compatible.
>
> @@ -100,7 +101,7 @@ Required properties:
> - clocks : a list of phandle + clock-specifier pairs, one for each
> entry in clock-names
> - clock-names : must contain "sys_ck", and the following ones are optional:
> - "ref_ck", "mcu_ck" and "dma_ck"
> + "ref_ck", "xhci_ck", "mcu_ck" and "dma_ck"
>
> Optional properties:
> - vbus-supply : reference to the VBUS regulator;
> --
> 2.21.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/5] dt-bindings: usb: mtk-xhci: add an optional xhci_ck clock
2019-07-09 14:22 ` Rob Herring
@ 2019-07-12 1:53 ` Chunfeng Yun
0 siblings, 0 replies; 9+ messages in thread
From: Chunfeng Yun @ 2019-07-12 1:53 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, devicetree, Mathias Nyman, Greg Kroah-Hartman,
linux-usb, linux-kernel, Jumin Li, linux-mediatek,
Matthias Brugger, linux-arm-kernel
On Tue, 2019-07-09 at 08:22 -0600, Rob Herring wrote:
> On Wed, Jun 12, 2019 at 01:55:19PM +0800, Chunfeng Yun wrote:
> > Add a new optional clock xhci_ck
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> > index 266c2d917a28..91c0704b586b 100644
> > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> > @@ -29,6 +29,7 @@ Required properties:
> > "sys_ck": controller clock used by normal mode,
> > the following ones are optional:
> > "ref_ck": reference clock used by low power mode etc,
> > + "xhci_ck": controller clock,
> > "mcu_ck": mcu_bus clock for register access,
> > "dma_ck": dma_bus clock for data transfer by DMA
>
> A new clock should go at the end to stay backwards compatible.
Ok, will fix it, thanks
>
> >
> > @@ -100,7 +101,7 @@ Required properties:
> > - clocks : a list of phandle + clock-specifier pairs, one for each
> > entry in clock-names
> > - clock-names : must contain "sys_ck", and the following ones are optional:
> > - "ref_ck", "mcu_ck" and "dma_ck"
> > + "ref_ck", "xhci_ck", "mcu_ck" and "dma_ck"
> >
> > Optional properties:
> > - vbus-supply : reference to the VBUS regulator;
> > --
> > 2.21.0
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-07-12 1:54 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-12 5:55 [PATCH 1/5] dt-bindings: usb: mtu3: fix typo of DMA clock name Chunfeng Yun
2019-06-12 5:55 ` [PATCH 2/5] dt-bindings: usb: mtu3: support force_vbus mode Chunfeng Yun
2019-07-09 14:21 ` Rob Herring
2019-06-12 5:55 ` [PATCH 3/5] dt-bindings: usb: mtk-xhci: add an optional xhci_ck clock Chunfeng Yun
2019-07-09 14:22 ` Rob Herring
2019-07-12 1:53 ` Chunfeng Yun
2019-06-12 5:55 ` [PATCH 4/5] usb: mtu3: support force_vbus mode Chunfeng Yun
2019-06-12 5:55 ` [PATCH 5/5] usb: xhci-mtk: add an optional xhci_ck clock Chunfeng Yun
2019-07-09 14:20 ` [PATCH 1/5] dt-bindings: usb: mtu3: fix typo of DMA clock name Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).