* [PATCH 0/2] arm64: dts: rockchip: rk3399-khadas-edge: missed nodes
@ 2020-09-23 10:12 Artem Lapkin
2020-09-23 10:12 ` [PATCH 1/2] arm64: dts: rockchip: rk3399-khadas-edge: add missed spiflash node Artem Lapkin
2020-09-23 10:12 ` [PATCH 2/2] arm64: dts: rockchip: rk3399-khadas-edge add missed ir-receiver and ir_rx pinctl nodes Artem Lapkin
0 siblings, 2 replies; 5+ messages in thread
From: Artem Lapkin @ 2020-09-23 10:12 UTC (permalink / raw)
To: heiko
Cc: devicetree, linux-kernel, robh+dt, nick, jbx6244, art, linux-arm-kernel
From: Artem Lapkin <art@khadas.com>
add missed spiflash and ir-receiver dts nodes to Khadas Edge Board
Artem Lapkin (2):
arm64: dts: rockchip: rk3399-khadas-edge: add missed spiflash node
arm64: dts: rockchip: rk3399-khadas-edge: add missed ir-recevier and
ir_rx pinctl nodes
.../boot/dts/rockchip/rk3399-khadas-edge.dtsi | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] arm64: dts: rockchip: rk3399-khadas-edge: add missed spiflash node
2020-09-23 10:12 [PATCH 0/2] arm64: dts: rockchip: rk3399-khadas-edge: missed nodes Artem Lapkin
@ 2020-09-23 10:12 ` Artem Lapkin
2020-09-23 10:57 ` Heiko Stübner
2020-09-23 10:12 ` [PATCH 2/2] arm64: dts: rockchip: rk3399-khadas-edge add missed ir-receiver and ir_rx pinctl nodes Artem Lapkin
1 sibling, 1 reply; 5+ messages in thread
From: Artem Lapkin @ 2020-09-23 10:12 UTC (permalink / raw)
To: heiko
Cc: devicetree, linux-kernel, robh+dt, nick, jbx6244, art, linux-arm-kernel
From: Artem Lapkin <art@khadas.com>
The Khadas Edge Boards uses winbond - w25q128 spi flash with 104Mhz
---
.../boot/dts/rockchip/rk3399-khadas-edge.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
index e36837c04dc..42ebbd6fa46 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
@@ -805,3 +805,17 @@ &vopl {
&vopl_mmu {
status = "okay";
};
+
+
+&spi1 {
+ max-freq = <104000000>;
+ status = "okay";
+
+ spiflash: flash@0 {
+ u-boot,dm-pre-reloc;
+ compatible = "winbond,w25q128fw", "jedec,spi-nor";
+ reg = <0>;
+ spi-max-frequency = <104000000>;
+ };
+};
+
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] arm64: dts: rockchip: rk3399-khadas-edge add missed ir-receiver and ir_rx pinctl nodes
2020-09-23 10:12 [PATCH 0/2] arm64: dts: rockchip: rk3399-khadas-edge: missed nodes Artem Lapkin
2020-09-23 10:12 ` [PATCH 1/2] arm64: dts: rockchip: rk3399-khadas-edge: add missed spiflash node Artem Lapkin
@ 2020-09-23 10:12 ` Artem Lapkin
2020-09-23 11:02 ` Heiko Stübner
1 sibling, 1 reply; 5+ messages in thread
From: Artem Lapkin @ 2020-09-23 10:12 UTC (permalink / raw)
To: heiko
Cc: devicetree, linux-kernel, robh+dt, nick, jbx6244, art, linux-arm-kernel
From: Artem Lapkin <art@khadas.com>
add missed ir receivier to Khadas Edge board
Khadas Edge uses gpio-ir-receiver on RK_PB6 gpio
---
.../boot/dts/rockchip/rk3399-khadas-edge.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
index 42ebbd6fa46..389ae43d869 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
@@ -109,6 +109,14 @@ vsys_5v0: vsys-5v0 {
vin-supply = <&vsys>;
};
+ ir-receiver {
+ compatible = "gpio-ir-receiver";
+ gpios = <&gpio1 RK_PB6 GPIO_ACTIVE_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&ir_rx>;
+ linux,rc-map-name = "rc-khadas";
+ };
+
adc-keys {
compatible = "adc-keys";
io-channels = <&saradc 1>;
@@ -682,6 +690,14 @@ &sdmmc {
status = "okay";
};
+&pinctrl {
+ ir {
+ ir_rx: ir-rx {
+ rockchip,pins = <1 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+};
+
&sdhci {
bus-width = <8>;
mmc-hs400-1_8v;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] arm64: dts: rockchip: rk3399-khadas-edge: add missed spiflash node
2020-09-23 10:12 ` [PATCH 1/2] arm64: dts: rockchip: rk3399-khadas-edge: add missed spiflash node Artem Lapkin
@ 2020-09-23 10:57 ` Heiko Stübner
0 siblings, 0 replies; 5+ messages in thread
From: Heiko Stübner @ 2020-09-23 10:57 UTC (permalink / raw)
To: Artem Lapkin
Cc: devicetree, linux-kernel, robh+dt, nick, jbx6244, art, linux-arm-kernel
Hi Artem,
please make the subject something like
"arm64: dts: rockchip: add spiflash node to rk3399-khadas-edge"
Am Mittwoch, 23. September 2020, 12:12:24 CEST schrieb Artem Lapkin:
> From: Artem Lapkin <art@khadas.com>
>
> The Khadas Edge Boards uses winbond - w25q128 spi flash with 104Mhz
Missing "Signed-off-by: ..."
> ---
> .../boot/dts/rockchip/rk3399-khadas-edge.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> index e36837c04dc..42ebbd6fa46 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> @@ -805,3 +805,17 @@ &vopl {
> &vopl_mmu {
> status = "okay";
> };
> +
> +
no double empty lines please
> +&spi1 {
please group the &spi1 alphabetically in the file
> + max-freq = <104000000>;
not part of any binding, spi-max-frequency below should be enough.
> + status = "okay";
> +
> + spiflash: flash@0 {
> + u-boot,dm-pre-reloc;
u-boot specific, please drop
> + compatible = "winbond,w25q128fw", "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <104000000>;
> + };
> +};
> +
>
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] arm64: dts: rockchip: rk3399-khadas-edge add missed ir-receiver and ir_rx pinctl nodes
2020-09-23 10:12 ` [PATCH 2/2] arm64: dts: rockchip: rk3399-khadas-edge add missed ir-receiver and ir_rx pinctl nodes Artem Lapkin
@ 2020-09-23 11:02 ` Heiko Stübner
0 siblings, 0 replies; 5+ messages in thread
From: Heiko Stübner @ 2020-09-23 11:02 UTC (permalink / raw)
To: Artem Lapkin
Cc: devicetree, linux-kernel, robh+dt, nick, jbx6244, art, linux-arm-kernel
Hi Artem,
Am Mittwoch, 23. September 2020, 12:12:25 CEST schrieb Artem Lapkin:
> From: Artem Lapkin <art@khadas.com>
>
> add missed ir receivier to Khadas Edge board
> Khadas Edge uses gpio-ir-receiver on RK_PB6 gpio
Missing Signed-off-by
> ---
> .../boot/dts/rockchip/rk3399-khadas-edge.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> index 42ebbd6fa46..389ae43d869 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> @@ -109,6 +109,14 @@ vsys_5v0: vsys-5v0 {
> vin-supply = <&vsys>;
> };
>
> + ir-receiver {
please sort alphabetically.
Also more importantly, is this really part of all Khadas Edge board variants?
[just making sure ;-) ]
> + compatible = "gpio-ir-receiver";
> + gpios = <&gpio1 RK_PB6 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&ir_rx>;
> + linux,rc-map-name = "rc-khadas";
> + };
> +
> adc-keys {
> compatible = "adc-keys";
> io-channels = <&saradc 1>;
> @@ -682,6 +690,14 @@ &sdmmc {
> status = "okay";
> };
>
> +&pinctrl {
there is already a "&pinctrl" node in the "rk3399-khadas-edge.dtsi"
please don't add another one, and make sure things are somewhat
sorted alphabetically ;-) .
Thanks
Heiko
> + ir {
> + ir_rx: ir-rx {
> + rockchip,pins = <1 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> +};
> +
> &sdhci {
> bus-width = <8>;
> mmc-hs400-1_8v;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-23 11:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-23 10:12 [PATCH 0/2] arm64: dts: rockchip: rk3399-khadas-edge: missed nodes Artem Lapkin
2020-09-23 10:12 ` [PATCH 1/2] arm64: dts: rockchip: rk3399-khadas-edge: add missed spiflash node Artem Lapkin
2020-09-23 10:57 ` Heiko Stübner
2020-09-23 10:12 ` [PATCH 2/2] arm64: dts: rockchip: rk3399-khadas-edge add missed ir-receiver and ir_rx pinctl nodes Artem Lapkin
2020-09-23 11:02 ` Heiko Stübner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).