From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>,
"Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>
Cc: "tim.c.chen@linux.intel.com" <tim.c.chen@linux.intel.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"bp@alien8.de" <bp@alien8.de>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"lenb@kernel.org" <lenb@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"bsegall@google.com" <bsegall@google.com>,
"mgorman@suse.de" <mgorman@suse.de>,
"msys.mizuma@gmail.com" <msys.mizuma@gmail.com>,
"valentin.schneider@arm.com" <valentin.schneider@arm.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"sudeep.holla@arm.com" <sudeep.holla@arm.com>,
"aubrey.li@linux.intel.com" <aubrey.li@linux.intel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"xuwei (O)" <xuwei5@huawei.com>,
"Zengtao (B)" <prime.zeng@hisilicon.com>,
"guodong.xu@linaro.org" <guodong.xu@linaro.org>,
yangyicong <yangyicong@huawei.com>,
"Liguozhu (Kenneth)" <liguozhu@hisilicon.com>,
"linuxarm@openeuler.org" <linuxarm@openeuler.org>,
"hpa@zytor.com" <hpa@zytor.com>
Subject: Re: [RFC PATCH v6 3/4] scheduler: scan idle cpu in cluster for tasks within one LLC
Date: Wed, 28 Apr 2021 18:47:26 +0200 [thread overview]
Message-ID: <8b5277d9-e367-566d-6bd1-44ac78d21d3f@arm.com> (raw)
In-Reply-To: <CAKfTPtC51eO2mAuW6mHQ-SdznAtfDL3D4UOs4HmnXaPOOCN_cA@mail.gmail.com>
On 28/04/2021 15:04, Vincent Guittot wrote:
> On Wed, 28 Apr 2021 at 11:51, Song Bao Hua (Barry Song)
> <song.bao.hua@hisilicon.com> wrote:
>>
>>> -----Original Message-----
>>> From: Dietmar Eggemann [mailto:dietmar.eggemann@arm.com]
[...]
>>> On 20/04/2021 02:18, Barry Song wrote:
[...]
>> I am really confused. The whole code has only checked if wake_flags
>> has WF_TTWU, it has never checked if sd_domain has SD_BALANCE_WAKE flag.
>
> look at :
> #define WF_TTWU 0x08 /* Wakeup; maps to SD_BALANCE_WAKE */
>
> so when wake_wide return false, we use the wake_affine mecanism but
> if it's false then we fllback to default mode which looks for:
> if (tmp->flags & sd_flag)
>
> This means looking for SD_BALANCE_WAKE which is never set
>
> so sd will stay NULL and you will end up calling select_idle_sibling anyway
>
>>
>> static int
>> select_task_rq_fair(struct task_struct *p, int prev_cpu, int wake_flags)
>> {
>> ...
>>
>> if (wake_flags & WF_TTWU) {
>> record_wakee(p);
>>
>> if (sched_energy_enabled()) {
>> new_cpu = find_energy_efficient_cpu(p, prev_cpu);
>> if (new_cpu >= 0)
>> return new_cpu;
>> new_cpu = prev_cpu;
>> }
>>
>> want_affine = !wake_wide(p) && cpumask_test_cpu(cpu, p->cpus_ptr);
>> }
>> }
>>
>> And try_to_wake_up() has always set WF_TTWU:
>> static int
>> try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags)
>> {
>> cpu = select_task_rq(p, p->wake_cpu, wake_flags | WF_TTWU);
>> ...
>> }
>>
>> So the change in wake_wide will actually affect the value of want_affine.
>> And I did also see code entered slow path during my benchmark.
Yes, this is happening but IMHO not for wakeups. Check wake_flags for
the tasks which go through `slow path` on your machine. They should have
WF_EXEC or WF_FORK, not WF_TTWU (& WF_SYNC).
>> One issue I mentioned during linaro open discussion is that
>> since I have moved to use cluster size to decide the value
>> of wake_wide, relatively less tasks will make wake_wide()
>> decide to go to slow path, thus, tasks begin to spread to
>> other NUMA, but actually llc_size might be able to contain
>> those tasks. So a possible model might be:
>> static int wake_wide(struct task_struct *p)
>> {
>> tasksize < cluster : scan cluster
>> tasksize > llc : slow path
>> tasksize > cluster && tasksize < llc: scan llc
>> }
>>
>> thoughts?
Like Vincent explained, the return value of wake_wide() doesn't matter.
For wakeups you always end up in sis().
[...]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-28 16:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 0:18 [RFC PATCH v6 0/4] scheduler: expose the topology of clusters and add cluster scheduler Barry Song
2021-04-20 0:18 ` [RFC PATCH v6 1/4] topology: Represent clusters of CPUs within a die Barry Song
2021-04-28 9:48 ` Andrew Jones
2021-04-30 3:46 ` Song Bao Hua (Barry Song)
2021-04-20 0:18 ` [RFC PATCH v6 2/4] scheduler: add scheduler level for clusters Barry Song
2021-04-20 0:18 ` [RFC PATCH v6 3/4] scheduler: scan idle cpu in cluster for tasks within one LLC Barry Song
2021-04-27 11:35 ` Dietmar Eggemann
2021-04-28 9:51 ` Song Bao Hua (Barry Song)
2021-04-28 13:04 ` Vincent Guittot
2021-04-28 16:47 ` Dietmar Eggemann [this message]
[not found] ` <185746c4d02a485ca8f3509439328b26@hisilicon.com>
2021-04-30 10:42 ` Dietmar Eggemann
2021-05-03 6:19 ` Song Bao Hua (Barry Song)
2021-05-03 11:35 ` Song Bao Hua (Barry Song)
2021-05-05 12:29 ` Dietmar Eggemann
2021-05-07 13:07 ` Song Bao Hua (Barry Song)
2021-05-13 12:32 ` Dietmar Eggemann
2021-05-25 8:14 ` Song Bao Hua (Barry Song)
2021-05-26 9:54 ` Song Bao Hua (Barry Song)
2021-04-20 0:18 ` [RFC PATCH v6 4/4] scheduler: Add cluster scheduler level for x86 Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b5277d9-e367-566d-6bd1-44ac78d21d3f@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=aubrey.li@linux.intel.com \
--cc=bp@alien8.de \
--cc=bsegall@google.com \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=guodong.xu@linaro.org \
--cc=hpa@zytor.com \
--cc=jonathan.cameron@huawei.com \
--cc=juri.lelli@redhat.com \
--cc=lenb@kernel.org \
--cc=liguozhu@hisilicon.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=msys.mizuma@gmail.com \
--cc=peterz@infradead.org \
--cc=prime.zeng@hisilicon.com \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=song.bao.hua@hisilicon.com \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xuwei5@huawei.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).