* [PATCH v1 1/1] pinctrl: sunplus: sppctl: Remove duplicate assignment of of_gpio_n_cells
@ 2023-01-12 18:51 Andy Shevchenko
2023-01-16 14:03 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2023-01-12 18:51 UTC (permalink / raw)
To: Wells Lu, Arnd Bergmann, linux-arm-kernel, linux-gpio, linux-kernel
Cc: Dvorkin Dmitry, Linus Walleij, Andy Shevchenko
The of_gpio_n_cells default is 2 when ->of_xlate() callback is
not defined. No need to assign it explicitly in the driver.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/sunplus/sppctl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/sunplus/sppctl.c b/drivers/pinctrl/sunplus/sppctl.c
index 9c57bccc4bda..2ed0591fb51d 100644
--- a/drivers/pinctrl/sunplus/sppctl.c
+++ b/drivers/pinctrl/sunplus/sppctl.c
@@ -553,7 +553,6 @@ static int sppctl_gpio_new(struct platform_device *pdev, struct sppctl_pdata *pc
gchip->base = -1;
gchip->ngpio = sppctl_gpio_list_sz;
gchip->names = sppctl_gpio_list_s;
- gchip->of_gpio_n_cells = 2;
pctl->pctl_grange.npins = gchip->ngpio;
pctl->pctl_grange.name = gchip->label;
--
2.39.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: sunplus: sppctl: Remove duplicate assignment of of_gpio_n_cells
2023-01-12 18:51 [PATCH v1 1/1] pinctrl: sunplus: sppctl: Remove duplicate assignment of of_gpio_n_cells Andy Shevchenko
@ 2023-01-16 14:03 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2023-01-16 14:03 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Wells Lu, Arnd Bergmann, linux-arm-kernel, linux-gpio,
linux-kernel, Dvorkin Dmitry
On Thu, Jan 12, 2023 at 7:50 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> The of_gpio_n_cells default is 2 when ->of_xlate() callback is
> not defined. No need to assign it explicitly in the driver.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied!
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-16 14:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-12 18:51 [PATCH v1 1/1] pinctrl: sunplus: sppctl: Remove duplicate assignment of of_gpio_n_cells Andy Shevchenko
2023-01-16 14:03 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).