* [PATCH] rockchip: enabled LAN port on NanoPi R2S
@ 2021-04-05 7:44 Tianling Shen
2021-04-05 8:13 ` Chen-Yu Tsai
0 siblings, 1 reply; 4+ messages in thread
From: Tianling Shen @ 2021-04-05 7:44 UTC (permalink / raw)
To: Rob Herring, Heiko Stuebner, Johan Jonker, David Bauer, Robin Murphy
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
Tianling Shen
From: David Bauer <mail@david-bauer.net>
Enable the USB3 port on the FriendlyARM NanoPi R2S.
This is required for the USB3 attached LAN port to work.
Signed-off-by: David Bauer <mail@david-bauer.net>
Signed-off-by: Tianling Shen <cnsztl@gmail.com>
---
.../boot/dts/rockchip/rk3328-nanopi-r2s.dts | 23 +++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
index faf496d789cf..6ba9799a95c5 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
@@ -37,6 +37,18 @@
};
};
+ vcc_rtl8153: vcc-rtl8153-regulator {
+ compatible = "regulator-fixed";
+ gpio = <&gpio2 RK_PC6 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&rtl8153_en_drv>;
+ regulator-always-on;
+ regulator-name = "vcc_rtl8153";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ enable-active-high;
+ };
+
leds {
compatible = "gpio-leds";
pinctrl-0 = <&lan_led_pin>, <&sys_led_pin>, <&wan_led_pin>;
@@ -265,6 +277,12 @@
};
};
};
+
+ usb {
+ rtl8153_en_drv: rtl8153-en-drv {
+ rockchip,pins = <2 RK_PC6 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
};
&io_domains {
@@ -364,6 +382,11 @@
dr_mode = "host";
};
+&usbdrd3 {
+ dr_mode = "host";
+ status = "okay";
+};
+
&usb_host0_ehci {
status = "okay";
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] rockchip: enabled LAN port on NanoPi R2S
2021-04-05 7:44 [PATCH] rockchip: enabled LAN port on NanoPi R2S Tianling Shen
@ 2021-04-05 8:13 ` Chen-Yu Tsai
2021-04-05 8:52 ` Tianling Shen
0 siblings, 1 reply; 4+ messages in thread
From: Chen-Yu Tsai @ 2021-04-05 8:13 UTC (permalink / raw)
To: Tianling Shen
Cc: Rob Herring, Heiko Stuebner, Johan Jonker, David Bauer,
Robin Murphy, devicetree, linux-arm-kernel,
open list:ARM/Rockchip SoC...,
linux-kernel
Hi,
On Mon, Apr 5, 2021 at 3:46 PM Tianling Shen <cnsztl@gmail.com> wrote:
>
> From: David Bauer <mail@david-bauer.net>
>
> Enable the USB3 port on the FriendlyARM NanoPi R2S.
> This is required for the USB3 attached LAN port to work.
>
> Signed-off-by: David Bauer <mail@david-bauer.net>
> Signed-off-by: Tianling Shen <cnsztl@gmail.com>
> ---
> .../boot/dts/rockchip/rk3328-nanopi-r2s.dts | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> index faf496d789cf..6ba9799a95c5 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> @@ -37,6 +37,18 @@
> };
> };
>
> + vcc_rtl8153: vcc-rtl8153-regulator {
> + compatible = "regulator-fixed";
> + gpio = <&gpio2 RK_PC6 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&rtl8153_en_drv>;
> + regulator-always-on;
> + regulator-name = "vcc_rtl8153";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
This is just a simple switch, not an actual regulator.
It would make more sense to drop the voltage range and
instead have the implementation pass-through voltage
constraints from its parent.
> + enable-active-high;
> + };
> +
> leds {
> compatible = "gpio-leds";
> pinctrl-0 = <&lan_led_pin>, <&sys_led_pin>, <&wan_led_pin>;
> @@ -265,6 +277,12 @@
> };
> };
> };
> +
> + usb {
> + rtl8153_en_drv: rtl8153-en-drv {
> + rockchip,pins = <2 RK_PC6 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> };
>
> &io_domains {
> @@ -364,6 +382,11 @@
> dr_mode = "host";
> };
>
> +&usbdrd3 {
> + dr_mode = "host";
> + status = "okay";
Please also add a device node for the actual Ethernet controller, and
set up an aliases node for it, so that the bootloader has some place
to fill in a MAC address.
ChenYu
> +};
> +
> &usb_host0_ehci {
> status = "okay";
> };
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rockchip: enabled LAN port on NanoPi R2S
2021-04-05 8:13 ` Chen-Yu Tsai
@ 2021-04-05 8:52 ` Tianling Shen
2021-04-05 8:56 ` Chen-Yu Tsai
0 siblings, 1 reply; 4+ messages in thread
From: Tianling Shen @ 2021-04-05 8:52 UTC (permalink / raw)
To: wens
Cc: Rob Herring, Heiko Stuebner, Johan Jonker, David Bauer,
Robin Murphy, devicetree, linux-arm-kernel,
open list:ARM/Rockchip SoC...,
linux-kernel
Hi Chen-Yu,
On 2021-04-05 16:14, Chen-Yu Tsai <wens@kernel.org> wrote:
>
> Hi,
>
> On Mon, Apr 5, 2021 at 3:46 PM Tianling Shen <cnsztl@gmail.com> wrote:
> >
> > From: David Bauer <mail@david-bauer.net>
> >
> > Enable the USB3 port on the FriendlyARM NanoPi R2S.
> > This is required for the USB3 attached LAN port to work.
> >
> > Signed-off-by: David Bauer <mail@david-bauer.net>
> > Signed-off-by: Tianling Shen <cnsztl@gmail.com>
> > ---
> > .../boot/dts/rockchip/rk3328-nanopi-r2s.dts | 23 +++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> > index faf496d789cf..6ba9799a95c5 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> > @@ -37,6 +37,18 @@
> > };
> > };
> >
> > + vcc_rtl8153: vcc-rtl8153-regulator {
> > + compatible = "regulator-fixed";
> > + gpio = <&gpio2 RK_PC6 GPIO_ACTIVE_HIGH>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&rtl8153_en_drv>;
> > + regulator-always-on;
> > + regulator-name = "vcc_rtl8153";
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
>
> This is just a simple switch, not an actual regulator.
> It would make more sense to drop the voltage range and
> instead have the implementation pass-through voltage
> constraints from its parent.
Thanks, I'll remove them in v2.
>
> > + enable-active-high;
> > + };
> > +
> > leds {
> > compatible = "gpio-leds";
> > pinctrl-0 = <&lan_led_pin>, <&sys_led_pin>, <&wan_led_pin>;
> > @@ -265,6 +277,12 @@
> > };
> > };
> > };
> > +
> > + usb {
> > + rtl8153_en_drv: rtl8153-en-drv {
> > + rockchip,pins = <2 RK_PC6 RK_FUNC_GPIO &pcfg_pull_none>;
> > + };
> > + };
> > };
> >
> > &io_domains {
> > @@ -364,6 +382,11 @@
> > dr_mode = "host";
> > };
> >
> > +&usbdrd3 {
> > + dr_mode = "host";
> > + status = "okay";
>
> Please also add a device node for the actual Ethernet controller, and
> set up an aliases node for it, so that the bootloader has some place
> to fill in a MAC address.
But there's no valid (unique) MAC address for both this or on-board ethernet...
They're non-existent in design.
Thanks,
Tianling.
>
>
> ChenYu
>
> > +};
> > +
> > &usb_host0_ehci {
> > status = "okay";
> > };
> > --
> > 2.17.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rockchip: enabled LAN port on NanoPi R2S
2021-04-05 8:52 ` Tianling Shen
@ 2021-04-05 8:56 ` Chen-Yu Tsai
0 siblings, 0 replies; 4+ messages in thread
From: Chen-Yu Tsai @ 2021-04-05 8:56 UTC (permalink / raw)
To: Tianling Shen
Cc: Rob Herring, Heiko Stuebner, Johan Jonker, David Bauer,
Robin Murphy, devicetree, linux-arm-kernel,
open list:ARM/Rockchip SoC...,
linux-kernel
On Mon, Apr 5, 2021 at 4:53 PM Tianling Shen <cnsztl@gmail.com> wrote:
>
> Hi Chen-Yu,
>
> On 2021-04-05 16:14, Chen-Yu Tsai <wens@kernel.org> wrote:
> >
> > Hi,
> >
> > On Mon, Apr 5, 2021 at 3:46 PM Tianling Shen <cnsztl@gmail.com> wrote:
> > >
> > > From: David Bauer <mail@david-bauer.net>
> > >
> > > Enable the USB3 port on the FriendlyARM NanoPi R2S.
> > > This is required for the USB3 attached LAN port to work.
> > >
> > > Signed-off-by: David Bauer <mail@david-bauer.net>
> > > Signed-off-by: Tianling Shen <cnsztl@gmail.com>
> > > ---
> > > .../boot/dts/rockchip/rk3328-nanopi-r2s.dts | 23 +++++++++++++++++++
> > > 1 file changed, 23 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> > > index faf496d789cf..6ba9799a95c5 100644
> > > --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> > > @@ -37,6 +37,18 @@
> > > };
> > > };
> > >
> > > + vcc_rtl8153: vcc-rtl8153-regulator {
> > > + compatible = "regulator-fixed";
> > > + gpio = <&gpio2 RK_PC6 GPIO_ACTIVE_HIGH>;
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&rtl8153_en_drv>;
> > > + regulator-always-on;
> > > + regulator-name = "vcc_rtl8153";
> > > + regulator-min-microvolt = <5000000>;
> > > + regulator-max-microvolt = <5000000>;
> >
> > This is just a simple switch, not an actual regulator.
> > It would make more sense to drop the voltage range and
> > instead have the implementation pass-through voltage
> > constraints from its parent.
>
> Thanks, I'll remove them in v2.
>
> >
> > > + enable-active-high;
> > > + };
> > > +
> > > leds {
> > > compatible = "gpio-leds";
> > > pinctrl-0 = <&lan_led_pin>, <&sys_led_pin>, <&wan_led_pin>;
> > > @@ -265,6 +277,12 @@
> > > };
> > > };
> > > };
> > > +
> > > + usb {
> > > + rtl8153_en_drv: rtl8153-en-drv {
> > > + rockchip,pins = <2 RK_PC6 RK_FUNC_GPIO &pcfg_pull_none>;
> > > + };
> > > + };
> > > };
> > >
> > > &io_domains {
> > > @@ -364,6 +382,11 @@
> > > dr_mode = "host";
> > > };
> > >
> > > +&usbdrd3 {
> > > + dr_mode = "host";
> > > + status = "okay";
> >
> > Please also add a device node for the actual Ethernet controller, and
> > set up an aliases node for it, so that the bootloader has some place
> > to fill in a MAC address.
>
> But there's no valid (unique) MAC address for both this or on-board ethernet...
> They're non-existent in design.
Correct. And thanks for confirming that it's not just me and Robin that
got boards without the MAC address EEPROM...
If the user sets some MAC address in the bootloader environment by hand,
the bootloader could still potentially pass that MAC address to Linux
through the device tree. Whether the board has a valid address or not
is beside the point.
ChenYu
> Thanks,
> Tianling.
>
> >
> >
> > ChenYu
> >
> > > +};
> > > +
> > > &usb_host0_ehci {
> > > status = "okay";
> > > };
> > > --
> > > 2.17.1
> > >
> > >
> > > _______________________________________________
> > > linux-arm-kernel mailing list
> > > linux-arm-kernel@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-05 8:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-05 7:44 [PATCH] rockchip: enabled LAN port on NanoPi R2S Tianling Shen
2021-04-05 8:13 ` Chen-Yu Tsai
2021-04-05 8:52 ` Tianling Shen
2021-04-05 8:56 ` Chen-Yu Tsai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).