* [PATCH 1/2 v2] arm64: dts: ls1088a: add more thermal zone support
@ 2020-07-15 6:49 andy.tang
2020-07-15 6:49 ` [PATCH 2/2 v2] arm64: dts: ls208xa: " andy.tang
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: andy.tang @ 2020-07-15 6:49 UTC (permalink / raw)
To: shawnguo
Cc: devicetree, Yuantian Tang, linux-kernel, amit.kucheria,
leoyang.li, robh+dt, linux-arm-kernel
From: Yuantian Tang <andy.tang@nxp.com>
There are 2 thermal zones in ls1088a soc. Add the other thermal zone
node to enable it.
Also update the values in calibration table to make the temperatures
monitored more precise.
Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
---
v2:
- remove useless alert trip
.../arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 94 +++++++++++--------
1 file changed, 56 insertions(+), 38 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
index 169f4742ae3b..b961a896ede7 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
@@ -130,19 +130,19 @@
};
thermal-zones {
- cpu_thermal: cpu-thermal {
+ core-cluster {
polling-delay-passive = <1000>;
polling-delay = <5000>;
thermal-sensors = <&tmu 0>;
trips {
- cpu_alert: cpu-alert {
+ core_cluster_alert: core-cluster-alert {
temperature = <85000>;
hysteresis = <2000>;
type = "passive";
};
- cpu_crit: cpu-crit {
+ core-cluster-crit {
temperature = <95000>;
hysteresis = <2000>;
type = "critical";
@@ -151,7 +151,7 @@
cooling-maps {
map0 {
- trip = <&cpu_alert>;
+ trip = <&core_cluster_alert>;
cooling-device =
<&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
<&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
@@ -164,6 +164,20 @@
};
};
};
+
+ soc {
+ polling-delay-passive = <1000>;
+ polling-delay = <5000>;
+ thermal-sensors = <&tmu 1>;
+
+ trips {
+ soc-crit {
+ temperature = <95000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+ };
};
timer {
@@ -210,45 +224,49 @@
compatible = "fsl,qoriq-tmu";
reg = <0x0 0x1f80000 0x0 0x10000>;
interrupts = <0 23 0x4>;
- fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x30062>;
+ fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x70062>;
fsl,tmu-calibration =
/* Calibration data group 1 */
- <0x00000000 0x00000026
- 0x00000001 0x0000002d
- 0x00000002 0x00000032
- 0x00000003 0x00000039
- 0x00000004 0x0000003f
- 0x00000005 0x00000046
- 0x00000006 0x0000004d
- 0x00000007 0x00000054
- 0x00000008 0x0000005a
- 0x00000009 0x00000061
- 0x0000000a 0x0000006a
- 0x0000000b 0x00000071
+ <0x00000000 0x00000023
+ 0x00000001 0x0000002a
+ 0x00000002 0x00000030
+ 0x00000003 0x00000037
+ 0x00000004 0x0000003d
+ 0x00000005 0x00000044
+ 0x00000006 0x0000004a
+ 0x00000007 0x00000051
+ 0x00000008 0x00000057
+ 0x00000009 0x0000005e
+ 0x0000000a 0x00000064
+ 0x0000000b 0x0000006b
/* Calibration data group 2 */
- 0x00010000 0x00000025
- 0x00010001 0x0000002c
- 0x00010002 0x00000035
- 0x00010003 0x0000003d
- 0x00010004 0x00000045
- 0x00010005 0x0000004e
- 0x00010006 0x00000057
- 0x00010007 0x00000061
- 0x00010008 0x0000006b
- 0x00010009 0x00000076
+ 0x00010000 0x00000022
+ 0x00010001 0x0000002a
+ 0x00010002 0x00000032
+ 0x00010003 0x0000003a
+ 0x00010004 0x00000042
+ 0x00010005 0x0000004a
+ 0x00010006 0x00000052
+ 0x00010007 0x0000005a
+ 0x00010008 0x00000062
+ 0x00010009 0x0000006a
/* Calibration data group 3 */
- 0x00020000 0x00000029
- 0x00020001 0x00000033
- 0x00020002 0x0000003d
- 0x00020003 0x00000049
- 0x00020004 0x00000056
- 0x00020005 0x00000061
- 0x00020006 0x0000006d
+ 0x00020000 0x00000021
+ 0x00020001 0x0000002b
+ 0x00020002 0x00000035
+ 0x00020003 0x00000040
+ 0x00020004 0x0000004a
+ 0x00020005 0x00000054
+ 0x00020006 0x0000005e
/* Calibration data group 4 */
- 0x00030000 0x00000021
- 0x00030001 0x0000002a
- 0x00030002 0x0000003c
- 0x00030003 0x0000004e>;
+ 0x00030000 0x00000010
+ 0x00030001 0x0000001c
+ 0x00030002 0x00000027
+ 0x00030003 0x00000032
+ 0x00030004 0x0000003e
+ 0x00030005 0x00000049
+ 0x00030006 0x00000054
+ 0x00030007 0x00000060>;
little-endian;
#thermal-sensor-cells = <1>;
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2 v2] arm64: dts: ls208xa: add more thermal zone support
2020-07-15 6:49 [PATCH 1/2 v2] arm64: dts: ls1088a: add more thermal zone support andy.tang
@ 2020-07-15 6:49 ` andy.tang
2020-08-21 6:09 ` Amit Kucheria
2020-08-17 8:02 ` [PATCH 1/2 v2] arm64: dts: ls1088a: " Shawn Guo
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: andy.tang @ 2020-07-15 6:49 UTC (permalink / raw)
To: shawnguo
Cc: devicetree, Yuantian Tang, linux-kernel, amit.kucheria,
leoyang.li, robh+dt, linux-arm-kernel
From: Yuantian Tang <andy.tang@nxp.com>
There are 7 thermal zones in ls208xa soc. Add the other thermal zone
nodes to enable them.
Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
---
v2:
- remove useless alert trip
- add cooling-map to core cluster zones.
.../arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 141 ++++++++++++++++--
1 file changed, 132 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
index 41102dacc2e1..cc36c969dd9d 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
@@ -79,20 +79,62 @@
};
thermal-zones {
- cpu_thermal: cpu-thermal {
+ ddr-controller1 {
polling-delay-passive = <1000>;
polling-delay = <5000>;
+ thermal-sensors = <&tmu 1>;
+ trips {
+ ddr-ctrler1-crit {
+ temperature = <95000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+ };
+
+ ddr-controller2 {
+ polling-delay-passive = <1000>;
+ polling-delay = <5000>;
+ thermal-sensors = <&tmu 2>;
+
+ trips {
+ ddr-ctrler2-crit {
+ temperature = <95000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+ };
+
+ ddr-controller3 {
+ polling-delay-passive = <1000>;
+ polling-delay = <5000>;
+ thermal-sensors = <&tmu 3>;
+
+ trips {
+ ddr-ctrler3-crit {
+ temperature = <95000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+ };
+
+ core-cluster1 {
+ polling-delay-passive = <1000>;
+ polling-delay = <5000>;
thermal-sensors = <&tmu 4>;
trips {
- cpu_alert: cpu-alert {
- temperature = <75000>;
+ core_cluster1_alert: core-cluster1-alert {
+ temperature = <85000>;
hysteresis = <2000>;
type = "passive";
};
- cpu_crit: cpu-crit {
- temperature = <85000>;
+
+ core-cluster1-crit {
+ temperature = <95000>;
hysteresis = <2000>;
type = "critical";
};
@@ -100,14 +142,95 @@
cooling-maps {
map0 {
- trip = <&cpu_alert>;
+ trip = <&core_cluster1_alert>;
cooling-device =
<&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
- <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ };
+ };
+ };
+
+ core-cluster2 {
+ polling-delay-passive = <1000>;
+ polling-delay = <5000>;
+ thermal-sensors = <&tmu 5>;
+
+ trips {
+ core_cluster2_alert: core-cluster2-alert {
+ temperature = <85000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+
+ core-cluster2-crit {
+ temperature = <95000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+
+ cooling-maps {
+ map0 {
+ trip = <&core_cluster2_alert>;
+ cooling-device =
<&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
- <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ };
+ };
+ };
+
+ core-cluster3 {
+ polling-delay-passive = <1000>;
+ polling-delay = <5000>;
+ thermal-sensors = <&tmu 6>;
+
+ trips {
+ core_cluster3_alert: core-cluster3-alert {
+ temperature = <85000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+
+ core-cluster3-crit {
+ temperature = <95000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+
+ cooling-maps {
+ map0 {
+ trip = <&core_cluster3_alert>;
+ cooling-device =
<&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
- <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ };
+ };
+ };
+
+ core-cluster4 {
+ polling-delay-passive = <1000>;
+ polling-delay = <5000>;
+ thermal-sensors = <&tmu 7>;
+
+ trips {
+ core_cluster4_alert: core-cluster4-alert {
+ temperature = <85000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+
+ core-cluster4-crit {
+ temperature = <95000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+
+ cooling-maps {
+ map0 {
+ trip = <&core_cluster4_alert>;
+ cooling-device =
<&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
<&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2 v2] arm64: dts: ls1088a: add more thermal zone support
2020-07-15 6:49 [PATCH 1/2 v2] arm64: dts: ls1088a: add more thermal zone support andy.tang
2020-07-15 6:49 ` [PATCH 2/2 v2] arm64: dts: ls208xa: " andy.tang
@ 2020-08-17 8:02 ` Shawn Guo
2020-08-21 6:09 ` Amit Kucheria
2020-08-22 3:29 ` Shawn Guo
3 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2020-08-17 8:02 UTC (permalink / raw)
To: andy.tang, amit.kucheria
Cc: devicetree, robh+dt, linux-kernel, linux-arm-kernel, leoyang.li
On Wed, Jul 15, 2020 at 02:49:08PM +0800, andy.tang@nxp.com wrote:
> From: Yuantian Tang <andy.tang@nxp.com>
>
> There are 2 thermal zones in ls1088a soc. Add the other thermal zone
> node to enable it.
> Also update the values in calibration table to make the temperatures
> monitored more precise.
>
> Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
> ---
> v2:
> - remove useless alert trip
@Amit, looks good to you?
Shawn
>
> .../arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 94 +++++++++++--------
> 1 file changed, 56 insertions(+), 38 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index 169f4742ae3b..b961a896ede7 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -130,19 +130,19 @@
> };
>
> thermal-zones {
> - cpu_thermal: cpu-thermal {
> + core-cluster {
> polling-delay-passive = <1000>;
> polling-delay = <5000>;
> thermal-sensors = <&tmu 0>;
>
> trips {
> - cpu_alert: cpu-alert {
> + core_cluster_alert: core-cluster-alert {
> temperature = <85000>;
> hysteresis = <2000>;
> type = "passive";
> };
>
> - cpu_crit: cpu-crit {
> + core-cluster-crit {
> temperature = <95000>;
> hysteresis = <2000>;
> type = "critical";
> @@ -151,7 +151,7 @@
>
> cooling-maps {
> map0 {
> - trip = <&cpu_alert>;
> + trip = <&core_cluster_alert>;
> cooling-device =
> <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> @@ -164,6 +164,20 @@
> };
> };
> };
> +
> + soc {
> + polling-delay-passive = <1000>;
> + polling-delay = <5000>;
> + thermal-sensors = <&tmu 1>;
> +
> + trips {
> + soc-crit {
> + temperature = <95000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> + };
> };
>
> timer {
> @@ -210,45 +224,49 @@
> compatible = "fsl,qoriq-tmu";
> reg = <0x0 0x1f80000 0x0 0x10000>;
> interrupts = <0 23 0x4>;
> - fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x30062>;
> + fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x70062>;
> fsl,tmu-calibration =
> /* Calibration data group 1 */
> - <0x00000000 0x00000026
> - 0x00000001 0x0000002d
> - 0x00000002 0x00000032
> - 0x00000003 0x00000039
> - 0x00000004 0x0000003f
> - 0x00000005 0x00000046
> - 0x00000006 0x0000004d
> - 0x00000007 0x00000054
> - 0x00000008 0x0000005a
> - 0x00000009 0x00000061
> - 0x0000000a 0x0000006a
> - 0x0000000b 0x00000071
> + <0x00000000 0x00000023
> + 0x00000001 0x0000002a
> + 0x00000002 0x00000030
> + 0x00000003 0x00000037
> + 0x00000004 0x0000003d
> + 0x00000005 0x00000044
> + 0x00000006 0x0000004a
> + 0x00000007 0x00000051
> + 0x00000008 0x00000057
> + 0x00000009 0x0000005e
> + 0x0000000a 0x00000064
> + 0x0000000b 0x0000006b
> /* Calibration data group 2 */
> - 0x00010000 0x00000025
> - 0x00010001 0x0000002c
> - 0x00010002 0x00000035
> - 0x00010003 0x0000003d
> - 0x00010004 0x00000045
> - 0x00010005 0x0000004e
> - 0x00010006 0x00000057
> - 0x00010007 0x00000061
> - 0x00010008 0x0000006b
> - 0x00010009 0x00000076
> + 0x00010000 0x00000022
> + 0x00010001 0x0000002a
> + 0x00010002 0x00000032
> + 0x00010003 0x0000003a
> + 0x00010004 0x00000042
> + 0x00010005 0x0000004a
> + 0x00010006 0x00000052
> + 0x00010007 0x0000005a
> + 0x00010008 0x00000062
> + 0x00010009 0x0000006a
> /* Calibration data group 3 */
> - 0x00020000 0x00000029
> - 0x00020001 0x00000033
> - 0x00020002 0x0000003d
> - 0x00020003 0x00000049
> - 0x00020004 0x00000056
> - 0x00020005 0x00000061
> - 0x00020006 0x0000006d
> + 0x00020000 0x00000021
> + 0x00020001 0x0000002b
> + 0x00020002 0x00000035
> + 0x00020003 0x00000040
> + 0x00020004 0x0000004a
> + 0x00020005 0x00000054
> + 0x00020006 0x0000005e
> /* Calibration data group 4 */
> - 0x00030000 0x00000021
> - 0x00030001 0x0000002a
> - 0x00030002 0x0000003c
> - 0x00030003 0x0000004e>;
> + 0x00030000 0x00000010
> + 0x00030001 0x0000001c
> + 0x00030002 0x00000027
> + 0x00030003 0x00000032
> + 0x00030004 0x0000003e
> + 0x00030005 0x00000049
> + 0x00030006 0x00000054
> + 0x00030007 0x00000060>;
> little-endian;
> #thermal-sensor-cells = <1>;
> };
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2 v2] arm64: dts: ls1088a: add more thermal zone support
2020-07-15 6:49 [PATCH 1/2 v2] arm64: dts: ls1088a: add more thermal zone support andy.tang
2020-07-15 6:49 ` [PATCH 2/2 v2] arm64: dts: ls208xa: " andy.tang
2020-08-17 8:02 ` [PATCH 1/2 v2] arm64: dts: ls1088a: " Shawn Guo
@ 2020-08-21 6:09 ` Amit Kucheria
2020-08-22 3:29 ` Shawn Guo
3 siblings, 0 replies; 6+ messages in thread
From: Amit Kucheria @ 2020-08-21 6:09 UTC (permalink / raw)
To: Yuantian Tang
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
Li Yang, Rob Herring, Shawn Guo, lakml
On Wed, Jul 15, 2020 at 12:25 PM <andy.tang@nxp.com> wrote:
>
> From: Yuantian Tang <andy.tang@nxp.com>
>
> There are 2 thermal zones in ls1088a soc. Add the other thermal zone
> node to enable it.
> Also update the values in calibration table to make the temperatures
> monitored more precise.
>
> Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
Reviewed-by: Amit Kucheria <amitk@kernel.org>
> ---
> v2:
> - remove useless alert trip
>
> .../arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 94 +++++++++++--------
> 1 file changed, 56 insertions(+), 38 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index 169f4742ae3b..b961a896ede7 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -130,19 +130,19 @@
> };
>
> thermal-zones {
> - cpu_thermal: cpu-thermal {
> + core-cluster {
> polling-delay-passive = <1000>;
> polling-delay = <5000>;
> thermal-sensors = <&tmu 0>;
>
> trips {
> - cpu_alert: cpu-alert {
> + core_cluster_alert: core-cluster-alert {
> temperature = <85000>;
> hysteresis = <2000>;
> type = "passive";
> };
>
> - cpu_crit: cpu-crit {
> + core-cluster-crit {
> temperature = <95000>;
> hysteresis = <2000>;
> type = "critical";
> @@ -151,7 +151,7 @@
>
> cooling-maps {
> map0 {
> - trip = <&cpu_alert>;
> + trip = <&core_cluster_alert>;
> cooling-device =
> <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> @@ -164,6 +164,20 @@
> };
> };
> };
> +
> + soc {
> + polling-delay-passive = <1000>;
> + polling-delay = <5000>;
> + thermal-sensors = <&tmu 1>;
> +
> + trips {
> + soc-crit {
> + temperature = <95000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> + };
> };
>
> timer {
> @@ -210,45 +224,49 @@
> compatible = "fsl,qoriq-tmu";
> reg = <0x0 0x1f80000 0x0 0x10000>;
> interrupts = <0 23 0x4>;
> - fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x30062>;
> + fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x70062>;
> fsl,tmu-calibration =
> /* Calibration data group 1 */
> - <0x00000000 0x00000026
> - 0x00000001 0x0000002d
> - 0x00000002 0x00000032
> - 0x00000003 0x00000039
> - 0x00000004 0x0000003f
> - 0x00000005 0x00000046
> - 0x00000006 0x0000004d
> - 0x00000007 0x00000054
> - 0x00000008 0x0000005a
> - 0x00000009 0x00000061
> - 0x0000000a 0x0000006a
> - 0x0000000b 0x00000071
> + <0x00000000 0x00000023
> + 0x00000001 0x0000002a
> + 0x00000002 0x00000030
> + 0x00000003 0x00000037
> + 0x00000004 0x0000003d
> + 0x00000005 0x00000044
> + 0x00000006 0x0000004a
> + 0x00000007 0x00000051
> + 0x00000008 0x00000057
> + 0x00000009 0x0000005e
> + 0x0000000a 0x00000064
> + 0x0000000b 0x0000006b
> /* Calibration data group 2 */
> - 0x00010000 0x00000025
> - 0x00010001 0x0000002c
> - 0x00010002 0x00000035
> - 0x00010003 0x0000003d
> - 0x00010004 0x00000045
> - 0x00010005 0x0000004e
> - 0x00010006 0x00000057
> - 0x00010007 0x00000061
> - 0x00010008 0x0000006b
> - 0x00010009 0x00000076
> + 0x00010000 0x00000022
> + 0x00010001 0x0000002a
> + 0x00010002 0x00000032
> + 0x00010003 0x0000003a
> + 0x00010004 0x00000042
> + 0x00010005 0x0000004a
> + 0x00010006 0x00000052
> + 0x00010007 0x0000005a
> + 0x00010008 0x00000062
> + 0x00010009 0x0000006a
> /* Calibration data group 3 */
> - 0x00020000 0x00000029
> - 0x00020001 0x00000033
> - 0x00020002 0x0000003d
> - 0x00020003 0x00000049
> - 0x00020004 0x00000056
> - 0x00020005 0x00000061
> - 0x00020006 0x0000006d
> + 0x00020000 0x00000021
> + 0x00020001 0x0000002b
> + 0x00020002 0x00000035
> + 0x00020003 0x00000040
> + 0x00020004 0x0000004a
> + 0x00020005 0x00000054
> + 0x00020006 0x0000005e
> /* Calibration data group 4 */
> - 0x00030000 0x00000021
> - 0x00030001 0x0000002a
> - 0x00030002 0x0000003c
> - 0x00030003 0x0000004e>;
> + 0x00030000 0x00000010
> + 0x00030001 0x0000001c
> + 0x00030002 0x00000027
> + 0x00030003 0x00000032
> + 0x00030004 0x0000003e
> + 0x00030005 0x00000049
> + 0x00030006 0x00000054
> + 0x00030007 0x00000060>;
> little-endian;
> #thermal-sensor-cells = <1>;
> };
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2 v2] arm64: dts: ls208xa: add more thermal zone support
2020-07-15 6:49 ` [PATCH 2/2 v2] arm64: dts: ls208xa: " andy.tang
@ 2020-08-21 6:09 ` Amit Kucheria
0 siblings, 0 replies; 6+ messages in thread
From: Amit Kucheria @ 2020-08-21 6:09 UTC (permalink / raw)
To: Yuantian Tang
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
Li Yang, Rob Herring, Shawn Guo, lakml
On Wed, Jul 15, 2020 at 12:25 PM <andy.tang@nxp.com> wrote:
>
> From: Yuantian Tang <andy.tang@nxp.com>
>
> There are 7 thermal zones in ls208xa soc. Add the other thermal zone
> nodes to enable them.
>
> Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
Reviewed-by: Amit Kucheria <amitk@kernel.org>
> ---
> v2:
> - remove useless alert trip
> - add cooling-map to core cluster zones.
>
> .../arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 141 ++++++++++++++++--
> 1 file changed, 132 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> index 41102dacc2e1..cc36c969dd9d 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> @@ -79,20 +79,62 @@
> };
>
> thermal-zones {
> - cpu_thermal: cpu-thermal {
> + ddr-controller1 {
> polling-delay-passive = <1000>;
> polling-delay = <5000>;
> + thermal-sensors = <&tmu 1>;
>
> + trips {
> + ddr-ctrler1-crit {
> + temperature = <95000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + ddr-controller2 {
> + polling-delay-passive = <1000>;
> + polling-delay = <5000>;
> + thermal-sensors = <&tmu 2>;
> +
> + trips {
> + ddr-ctrler2-crit {
> + temperature = <95000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + ddr-controller3 {
> + polling-delay-passive = <1000>;
> + polling-delay = <5000>;
> + thermal-sensors = <&tmu 3>;
> +
> + trips {
> + ddr-ctrler3-crit {
> + temperature = <95000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + core-cluster1 {
> + polling-delay-passive = <1000>;
> + polling-delay = <5000>;
> thermal-sensors = <&tmu 4>;
>
> trips {
> - cpu_alert: cpu-alert {
> - temperature = <75000>;
> + core_cluster1_alert: core-cluster1-alert {
> + temperature = <85000>;
> hysteresis = <2000>;
> type = "passive";
> };
> - cpu_crit: cpu-crit {
> - temperature = <85000>;
> +
> + core-cluster1-crit {
> + temperature = <95000>;
> hysteresis = <2000>;
> type = "critical";
> };
> @@ -100,14 +142,95 @@
>
> cooling-maps {
> map0 {
> - trip = <&cpu_alert>;
> + trip = <&core_cluster1_alert>;
> cooling-device =
> <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> - <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> + };
> +
> + core-cluster2 {
> + polling-delay-passive = <1000>;
> + polling-delay = <5000>;
> + thermal-sensors = <&tmu 5>;
> +
> + trips {
> + core_cluster2_alert: core-cluster2-alert {
> + temperature = <85000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + core-cluster2-crit {
> + temperature = <95000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> +
> + cooling-maps {
> + map0 {
> + trip = <&core_cluster2_alert>;
> + cooling-device =
> <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> - <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> + };
> +
> + core-cluster3 {
> + polling-delay-passive = <1000>;
> + polling-delay = <5000>;
> + thermal-sensors = <&tmu 6>;
> +
> + trips {
> + core_cluster3_alert: core-cluster3-alert {
> + temperature = <85000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + core-cluster3-crit {
> + temperature = <95000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> +
> + cooling-maps {
> + map0 {
> + trip = <&core_cluster3_alert>;
> + cooling-device =
> <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> - <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> + };
> +
> + core-cluster4 {
> + polling-delay-passive = <1000>;
> + polling-delay = <5000>;
> + thermal-sensors = <&tmu 7>;
> +
> + trips {
> + core_cluster4_alert: core-cluster4-alert {
> + temperature = <85000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + core-cluster4-crit {
> + temperature = <95000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> +
> + cooling-maps {
> + map0 {
> + trip = <&core_cluster4_alert>;
> + cooling-device =
> <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> };
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2 v2] arm64: dts: ls1088a: add more thermal zone support
2020-07-15 6:49 [PATCH 1/2 v2] arm64: dts: ls1088a: add more thermal zone support andy.tang
` (2 preceding siblings ...)
2020-08-21 6:09 ` Amit Kucheria
@ 2020-08-22 3:29 ` Shawn Guo
3 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2020-08-22 3:29 UTC (permalink / raw)
To: andy.tang
Cc: devicetree, linux-kernel, amit.kucheria, leoyang.li, robh+dt,
linux-arm-kernel
On Wed, Jul 15, 2020 at 02:49:08PM +0800, andy.tang@nxp.com wrote:
> From: Yuantian Tang <andy.tang@nxp.com>
>
> There are 2 thermal zones in ls1088a soc. Add the other thermal zone
> node to enable it.
> Also update the values in calibration table to make the temperatures
> monitored more precise.
>
> Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
Applied both, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-22 3:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-15 6:49 [PATCH 1/2 v2] arm64: dts: ls1088a: add more thermal zone support andy.tang
2020-07-15 6:49 ` [PATCH 2/2 v2] arm64: dts: ls208xa: " andy.tang
2020-08-21 6:09 ` Amit Kucheria
2020-08-17 8:02 ` [PATCH 1/2 v2] arm64: dts: ls1088a: " Shawn Guo
2020-08-21 6:09 ` Amit Kucheria
2020-08-22 3:29 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).