* [PATCH] soc: ixp4xx: Protect IXP4xx SoC drivers by ARCH_IXP4XX || COMPILE_TEST
@ 2019-08-19 8:00 Geert Uytterhoeven
2019-08-23 8:26 ` Linus Walleij
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2019-08-19 8:00 UTC (permalink / raw)
To: Linus Walleij, Imre Kaloz, Krzysztof Halasa
Cc: Geert Uytterhoeven, linux-arm-kernel, Arnd Bergmann, linux-kernel
The move of the IXP4xx SoC drivers exposed their config options on all
platforms.
Fix this by wrapping them inside an ARCH_IXP4XX or COMPILE_TEST block.
Fixes: fcf2d8978cd538a5 ("ARM: ixp4xx: Move NPE and QMGR to drivers/soc")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
v2:
- Rebased on top of commit ec8f24b7faaf3d47 ("treewide: Add SPDX
license identifier - Makefile/Kconfig").
---
drivers/soc/ixp4xx/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/soc/ixp4xx/Kconfig b/drivers/soc/ixp4xx/Kconfig
index de2e62c3310a37d0..e3eb19b85fa4b358 100644
--- a/drivers/soc/ixp4xx/Kconfig
+++ b/drivers/soc/ixp4xx/Kconfig
@@ -1,4 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
+if ARCH_IXP4XX || COMPILE_TEST
+
menu "IXP4xx SoC drivers"
config IXP4XX_QMGR
@@ -15,3 +17,5 @@ config IXP4XX_NPE
and is automatically selected by Ethernet and HSS drivers.
endmenu
+
+endif
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] soc: ixp4xx: Protect IXP4xx SoC drivers by ARCH_IXP4XX || COMPILE_TEST
2019-08-19 8:00 [PATCH] soc: ixp4xx: Protect IXP4xx SoC drivers by ARCH_IXP4XX || COMPILE_TEST Geert Uytterhoeven
@ 2019-08-23 8:26 ` Linus Walleij
2019-08-23 8:28 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2019-08-23 8:26 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Arnd Bergmann, Linus Walleij, linux-kernel, Krzysztof Halasa,
Imre Kaloz, Linux ARM
On Mon, Aug 19, 2019 at 10:46 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> The move of the IXP4xx SoC drivers exposed their config options on all
> platforms.
>
> Fix this by wrapping them inside an ARCH_IXP4XX or COMPILE_TEST block.
>
> Fixes: fcf2d8978cd538a5 ("ARM: ixp4xx: Move NPE and QMGR to drivers/soc")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> v2:
> - Rebased on top of commit ec8f24b7faaf3d47 ("treewide: Add SPDX
> license identifier - Makefile/Kconfig").
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Do you want me to also take care of sending this into the ARM SoC tree?
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] soc: ixp4xx: Protect IXP4xx SoC drivers by ARCH_IXP4XX || COMPILE_TEST
2019-08-23 8:26 ` Linus Walleij
@ 2019-08-23 8:28 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2019-08-23 8:28 UTC (permalink / raw)
To: Linus Walleij
Cc: Arnd Bergmann, Linus Walleij, linux-kernel, Krzysztof Halasa,
Imre Kaloz, Linux ARM
Hi Linus,
On Fri, Aug 23, 2019 at 10:26 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Aug 19, 2019 at 10:46 AM Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > The move of the IXP4xx SoC drivers exposed their config options on all
> > platforms.
> >
> > Fix this by wrapping them inside an ARCH_IXP4XX or COMPILE_TEST block.
> >
> > Fixes: fcf2d8978cd538a5 ("ARM: ixp4xx: Move NPE and QMGR to drivers/soc")
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
> > v2:
> > - Rebased on top of commit ec8f24b7faaf3d47 ("treewide: Add SPDX
> > license identifier - Makefile/Kconfig").
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Do you want me to also take care of sending this into the ARM SoC tree?
Given you're listed as (one of) the maintainer(s), I think that would make
perfect sense.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] soc: ixp4xx: Protect IXP4xx SoC drivers by ARCH_IXP4XX || COMPILE_TEST
@ 2019-08-23 9:03 Linus Walleij
0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2019-08-23 9:03 UTC (permalink / raw)
To: arm, soc; +Cc: Linus Walleij, Geert Uytterhoeven, linux-arm-kernel
From: Geert Uytterhoeven <geert@linux-m68k.org>
The move of the IXP4xx SoC drivers exposed their config options on all
platforms.
Fix this by wrapping them inside an ARCH_IXP4XX or COMPILE_TEST block.
Fixes: fcf2d8978cd538a5 ("ARM: ixp4xx: Move NPE and QMGR to drivers/soc")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Hi ARM SoC folks, please apply this directly for fixes.
---
drivers/soc/ixp4xx/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/soc/ixp4xx/Kconfig b/drivers/soc/ixp4xx/Kconfig
index de2e62c3310a..e3eb19b85fa4 100644
--- a/drivers/soc/ixp4xx/Kconfig
+++ b/drivers/soc/ixp4xx/Kconfig
@@ -1,4 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
+if ARCH_IXP4XX || COMPILE_TEST
+
menu "IXP4xx SoC drivers"
config IXP4XX_QMGR
@@ -15,3 +17,5 @@ config IXP4XX_NPE
and is automatically selected by Ethernet and HSS drivers.
endmenu
+
+endif
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] soc: ixp4xx: Protect IXP4xx SoC drivers by ARCH_IXP4XX || COMPILE_TEST
@ 2019-05-20 9:14 Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2019-05-20 9:14 UTC (permalink / raw)
To: Linus Walleij, Imre Kaloz, Krzysztof Halasa
Cc: Olof Johansson, Geert Uytterhoeven, linux-arm-kernel
The move of the IXP4xx SoC drivers exposed their config options on all
platforms.
Fix this by wrapping them inside an ARCH_IXP4XX or COMPILE_TEST block.
Fixes: fcf2d8978cd538a5 ("ARM: ixp4xx: Move NPE and QMGR to drivers/soc")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/soc/ixp4xx/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/soc/ixp4xx/Kconfig b/drivers/soc/ixp4xx/Kconfig
index de6becdc78a25ff7..93c852d53223359c 100644
--- a/drivers/soc/ixp4xx/Kconfig
+++ b/drivers/soc/ixp4xx/Kconfig
@@ -1,3 +1,5 @@
+if ARCH_IXP4XX || COMPILE_TEST
+
menu "IXP4xx SoC drivers"
config IXP4XX_QMGR
@@ -14,3 +16,5 @@ config IXP4XX_NPE
and is automatically selected by Ethernet and HSS drivers.
endmenu
+
+endif
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-23 9:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 8:00 [PATCH] soc: ixp4xx: Protect IXP4xx SoC drivers by ARCH_IXP4XX || COMPILE_TEST Geert Uytterhoeven
2019-08-23 8:26 ` Linus Walleij
2019-08-23 8:28 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2019-08-23 9:03 Linus Walleij
2019-05-20 9:14 Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).