* [PATCH -next] media: imx: imx7_mipi_csis: Fix error return code in mipi_csis_async_register()
@ 2021-05-24 13:35 Wei Yongjun
2021-05-25 20:49 ` Rui Miguel Silva
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2021-05-24 13:35 UTC (permalink / raw)
To: weiyongjun1, Rui Miguel Silva, Laurent Pinchart,
Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Shawn Guo, Sascha Hauer
Cc: linux-media, linux-staging, linux-arm-kernel, kernel-janitors,
Hulk Robot
Fix to return negative error code -EINVAL from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 88fc81388df9 ("media: imx: imx7_mipi_csis: Reject invalid data-lanes settings")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/staging/media/imx/imx7-mipi-csis.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c
index d573f3475d28..9cd3c86fee58 100644
--- a/drivers/staging/media/imx/imx7-mipi-csis.c
+++ b/drivers/staging/media/imx/imx7-mipi-csis.c
@@ -1175,6 +1175,7 @@ static int mipi_csis_async_register(struct csi_state *state)
if (vep.bus.mipi_csi2.data_lanes[i] != i + 1) {
dev_err(state->dev,
"data lanes reordering is not supported");
+ ret = -EINVAL;
goto err_parse;
}
}
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] media: imx: imx7_mipi_csis: Fix error return code in mipi_csis_async_register()
2021-05-24 13:35 [PATCH -next] media: imx: imx7_mipi_csis: Fix error return code in mipi_csis_async_register() Wei Yongjun
@ 2021-05-25 20:49 ` Rui Miguel Silva
0 siblings, 0 replies; 2+ messages in thread
From: Rui Miguel Silva @ 2021-05-25 20:49 UTC (permalink / raw)
To: Wei Yongjun, Laurent Pinchart, Steve Longerbeam, Philipp Zabel,
Mauro Carvalho Chehab, Greg Kroah-Hartman, Shawn Guo,
Sascha Hauer
Cc: linux-media, linux-staging, linux-arm-kernel, kernel-janitors,
Hulk Robot
Hi Yongjun,
Thanks for the patch.
On Mon May 24, 2021 at 2:35 PM WEST, Wei Yongjun wrote:
> Fix to return negative error code -EINVAL from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 88fc81388df9 ("media: imx: imx7_mipi_csis: Reject invalid data-lanes settings")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Looks good to me, thanks.
Acked-by: Rui Miguel Silva <rmfrfs@gmail.com>
------
Cheers,
Rui
> ---
> drivers/staging/media/imx/imx7-mipi-csis.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c
> index d573f3475d28..9cd3c86fee58 100644
> --- a/drivers/staging/media/imx/imx7-mipi-csis.c
> +++ b/drivers/staging/media/imx/imx7-mipi-csis.c
> @@ -1175,6 +1175,7 @@ static int mipi_csis_async_register(struct csi_state *state)
> if (vep.bus.mipi_csi2.data_lanes[i] != i + 1) {
> dev_err(state->dev,
> "data lanes reordering is not supported");
> + ret = -EINVAL;
> goto err_parse;
> }
> }
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-25 20:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24 13:35 [PATCH -next] media: imx: imx7_mipi_csis: Fix error return code in mipi_csis_async_register() Wei Yongjun
2021-05-25 20:49 ` Rui Miguel Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).