From: Anson Huang <anson.huang@nxp.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Peng Fan <peng.fan@nxp.com>,
linux-clk <linux-clk@vger.kernel.org>,
Andy Duan <fugang.duan@nxp.com>, Abel Vesa <abel.vesa@nxp.com>,
Stefan Agner <stefan.agner@toradex.com>,
Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
YueHaibing <yuehaibing@huawei.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Daniel Baluta <daniel.baluta@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"oleksandr.suvorov@toradex.com" <oleksandr.suvorov@toradex.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V3 02/10] init.h: Fix the __setup_param() macro for module build
Date: Wed, 1 Jul 2020 10:20:30 +0000 [thread overview]
Message-ID: <DB3PR0402MB39168BDB947322F9C159E42CF56C0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAK8P3a0YKsiKx66ESwvVmsubv=x=UB8JafisCY0Ct8VBMi-JhQ@mail.gmail.com>
Hi, Arnd
> Subject: Re: [PATCH V3 02/10] init.h: Fix the __setup_param() macro for
> module build
>
> On Wed, Jul 1, 2020 at 12:02 PM Anson Huang <anson.huang@nxp.com>
> wrote:
> > > Subject: Re: [PATCH V3 02/10] init.h: Fix the __setup_param() macro
> > > for module build On Wed, Jul 1, 2020 at 11:27 AM Anson Huang
> > > <anson.huang@nxp.com>
> > > wrote:
> > > > > Subject: Re: [PATCH V3 02/10] init.h: Fix the __setup_param()
> > > > > macro for module build
> > > Why not move this all to a separate file then and only build it when
> > > CONFIG_CLK_IMX=y?
> > > It seems that you don't need the imx_keep_uart_clocks_param() if the
> > > clk driver is loaded as a module, but then you also don't need the
> > > imx_clk_disable_uart() and imx_register_uart_clocks() functions or
> > > the associated variables.
> >
> > If so, how about just adding "#ifndef MODULE" check for this part of
> > code? I think it should be easier/better than adding a file and build it
> conditionally?
>
> The #ifdef is clearly a simpler change, but I think a separate file is a cleaner
> way to do it. Up to you (unless one of the imx or clk maintainers has a
> preference -- I'm only helping out here, not making decisions).
>
OK, the first version of this patch introduced two __setup_param() implementation
for built-in and loadable module, that leads to all the discussion of fixing __setup_param()
in init.h etc., but you just remind me that __setup_param() is NOT necessary at all when
building loadable module, so I think just add '#ifndef MODULE' should be acceptable, I will
go with this change in V4 patch series, and see if anyone has comment.
Please help review V4 patch series which will be sent out soon.
Thanks,
Anson
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-01 10:21 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 5:53 [PATCH V3 00/10] Support building i.MX8 SoCs clock driver as module Anson Huang
2020-06-29 5:53 ` [PATCH V3 01/10] clk: composite: Export clk_hw_register_composite() Anson Huang
2020-06-29 5:53 ` [PATCH V3 02/10] init.h: Fix the __setup_param() macro for module build Anson Huang
2020-06-29 11:33 ` Arnd Bergmann
2020-06-29 11:40 ` Anson Huang
2020-06-29 11:58 ` Arnd Bergmann
2020-07-01 5:14 ` Anson Huang
2020-07-01 8:37 ` Arnd Bergmann
2020-07-01 9:27 ` Anson Huang
2020-07-01 9:53 ` Arnd Bergmann
2020-07-01 10:02 ` Anson Huang
2020-07-01 10:13 ` Arnd Bergmann
2020-07-01 10:20 ` Anson Huang [this message]
2020-06-29 5:53 ` [PATCH V3 03/10] ARM: imx: Select MXC_CLK for each SoC Anson Huang
2020-06-29 7:27 ` Aisheng Dong
2020-06-29 8:21 ` Anson Huang
2020-06-29 5:53 ` [PATCH V3 04/10] clk: imx: Support building SCU clock driver as module Anson Huang
2020-06-29 11:37 ` Arnd Bergmann
2020-06-29 12:53 ` Anson Huang
2020-06-29 13:20 ` Arnd Bergmann
2020-06-29 14:52 ` Anson Huang
2020-06-29 15:08 ` Arnd Bergmann
2020-06-29 15:19 ` Anson Huang
2020-06-30 3:55 ` Dong Aisheng
2020-07-01 7:19 ` Anson Huang
2020-07-01 8:46 ` Arnd Bergmann
2020-07-01 9:28 ` Anson Huang
2020-07-01 9:40 ` Anson Huang
2020-07-01 9:54 ` Arnd Bergmann
2020-06-30 3:36 ` Dong Aisheng
2020-06-29 5:53 ` [PATCH V3 05/10] clk: imx: Support building i.MX common " Anson Huang
2020-06-29 5:53 ` [PATCH V3 06/10] clk: imx8mm: Support module build Anson Huang
2020-06-29 5:53 ` [PATCH V3 07/10] clk: imx8mn: " Anson Huang
2020-06-29 5:54 ` [PATCH V3 08/10] clk: imx8mp: " Anson Huang
2020-06-29 5:54 ` [PATCH V3 09/10] clk: imx8mq: " Anson Huang
2020-06-29 5:54 ` [PATCH V3 10/10] clk: imx8qxp: " Anson Huang
2020-06-29 11:40 ` Arnd Bergmann
2020-06-29 11:43 ` Anson Huang
2020-06-29 11:58 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB39168BDB947322F9C159E42CF56C0@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=arnd@arndb.de \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=oleksandr.suvorov@toradex.com \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=shawnguo@kernel.org \
--cc=stefan.agner@toradex.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).